On 19 Oct 2019, at 05:51, Jeremy <jeremy.m....@gmail.com> wrote: > > While I was doing a buildworld for FreeBSD 12 stable (r353745) for amd64, I > noticed the target triple was set at x86_64-unknown-freebsd12.0 while it > was building the 32 bit libraries. I was wondering if it was necessary to > bump it to 12.1 now that 12.1 is getting ready for release, or if it > doesn't matter either way. I believe the relevant commit was from > (r338268). In any case, buildworld completed with no issues. > > If it's not necessary, sorry for the noise.
You are right, this is coming from Makefile.libcompat: $ grep freebsd12 Makefile.libcompat LIB32CPUFLAGS+= -target x86_64-unknown-freebsd12.0 LIB32CPUFLAGS= -target mipsel-unknown-freebsd12.0 LIB32CPUFLAGS= -target mips-unknown-freebsd12.0 Glen, I think you have a list somewhere of the files that need to have their versions bumped for releng branches, could you please add Makefile.libcompat to it too? Maybe at one point we should have one source of truth for that obtaining that version number... :) -Dimitry
signature.asc
Description: Message signed with OpenPGP