Re: if_cxgbev build error on -stable

2016-12-04 Thread John Baldwin
On Sunday, December 04, 2016 03:53:23 PM Konstantin Belousov wrote: > On Sun, Dec 04, 2016 at 04:23:00PM +0300, Andrey Chernov wrote: > > It seems counter.h is included before systm.h where critical_* are declared. > It is more weird, since sys/counter.h was added in the stable/10 > merge, but the

Re: if_cxgbev build error on -stable

2016-12-04 Thread Konstantin Belousov
On Sun, Dec 04, 2016 at 04:23:00PM +0300, Andrey Chernov wrote: > It seems counter.h is included before systm.h where critical_* are declared. It is more weird, since sys/counter.h was added in the stable/10 merge, but the header is not used in the HEAD sources. It is indeed needed for stable/10

Re: if_cxgbev build error on -stable

2016-12-04 Thread Andrey Chernov
It seems counter.h is included before systm.h where critical_* are declared. On 04.12.2016 16:12, Andrey Chernov wrote: > On recent i386 -stable I got: > > ... > /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c -o t4_vf.o > In file included from >

if_cxgbev build error on -stable

2016-12-04 Thread Andrey Chernov
On recent i386 -stable I got: ... /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c -o t4_vf.o In file included from /usr/src/sys/modules/cxgbe/if_cxgbev/../../../dev/cxgbe/t4_vf.c:37: In file included from @/sys/counter.h:35: ./machine/counter.h:170:3: error: implicit declaration