[Differential] [Request, 191 lines] D1428: readelf: Handle note types from different operating systems

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Previously elftoolchain readelf(1) only displayed correct names for Linux note types. Upstream elftoolchain ticket #473 https://sourceforge.net/p/elftoolchain/tickets/473/ REVISION DETAIL

[Differential] [Changed Subscribers] D1428: readelf: Handle note types from different operating systems

rpaulo added a subscriber: rpaulo. rpaulo added a comment. This looks odd. Why are we relying on magic numbers instead of constants/enums like before? REVISION DETAIL https://reviews.freebsd.org/D1428 To: emaste Cc: rpaulo, freebsd-toolchain ___

[Differential] [Commented On] D1428: readelf: Handle note types from different operating systems

emaste added a comment. ! In D1428#3, @rpaulo wrote: This looks odd. Why are we relying on magic numbers instead of constants/enums like before? Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers. We could make up our own constants (e.g.

[Differential] [Commented On] D1428: readelf: Handle note types from different operating systems

rpaulo added a comment. ! In D1428#5, @emaste wrote: ! In D1428#3, @rpaulo wrote: This looks odd. Why are we relying on magic numbers instead of constants/enums like before? Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers. We could