emaste added a comment.
Apart from the bit of ugliness in lib/Makefile
Perhaps the ugliness needs a comment, at least.
Also a BSD.debug.mk entry for `WITH_DEBUG_FILES=yes`?
REVISION DETAIL
https://reviews.freebsd.org/D1505
To: dim, andrew, bapt, imp, emaste
Cc: freebsd-toolchain
dim updated this revision to Diff 3131.
dim added a comment.
Avoid specifically listing architectures.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1505?vs=3130id=3131
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1505
AFFECTED FILES
etc/mtree/BSD.debug.dist
dim added a comment.
Minor note: this survived a make universe on one of the FreeBSD.org reference
machines.
REVISION DETAIL
https://reviews.freebsd.org/D1505
To: dim, andrew, bapt, emaste, imp
Cc: freebsd-toolchain
___
dim created this revision.
dim added reviewers: andrew, bapt, emaste, imp.
dim added a subscriber: freebsd-toolchain.
REVISION SUMMARY
I added the libclang_rt libraries (Address Sanitizer, Undefined Behavior
Sanitizer and Profile Guided Optimization) from compiler-rt to the tree
recently,
emaste added a comment.
Note that I also did not introduce yet another WITH_LIBCLANG_RT knob,
This is fine in my opinion; we don't need another knob.
REVISION DETAIL
https://reviews.freebsd.org/D1505
To: dim, andrew, bapt, imp, emaste
Cc: freebsd-toolchain
