dim added inline comments.
INLINE COMMENTS
usr.sbin/ypbind/ypbind.c:622 While we are here, can we please update this to
a post-KR definition? E.g.:
static bool_t broadcast_result(caddr_t out, struct sockaddr_in *addr)
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
araujo added a comment.
In https://reviews.freebsd.org/D2690#54413, @rodrigc wrote:
Sorry for the late response. Please address @dim 's comment, if you have not
addressed it already.
Yes, I have addressed @dim's comment already.
Also, removing the type-alias punned warnings is trickier
rodrigc added a comment.
Sorry for the late response. Please address @dim 's comment, if you have not
addressed it already.
Also, removing the type-alias punned warnings is trickier than the other types
of fixes that we have done to clean up the code.
For this change, I would feel more
dim added inline comments.
INLINE COMMENTS
usr.sbin/ypbind/ypbind.c:952 Missing an here?
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D2690
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rodrigc, bapt, emaste,