Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread Dimitry Andric
On 2011-12-26 11:10, Alexander Best wrote: that's why i'd like to propose the following patch. i ran a full tinderbox run against r228878 and it suceeded. Did you also try this with clang? For example the xfs module alone gets a whole slew of warnings, which would be fatal if WERROR= was

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread David Chisnall
On 30 Dec 2011, at 13:06, Dimitry Andric wrote: sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1' indexes past the end of an array (that contains 1 element) [-Warray-bounds] I recall some discussion of this warning on the clang list a few months ago, and I believe that it

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread Dimitry Andric
On 2011-12-30 14:28, David Chisnall wrote: On 30 Dec 2011, at 13:06, Dimitry Andric wrote: sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1' indexes past the end of an array (that contains 1 element) [-Warray-bounds] I recall some discussion of this warning on the clang

[rfc] removing/conditionalising WERROR= in Makefiles

2011-12-26 Thread Alexander Best
hi there, i grep'ed through src/sys and found several places where WERROR= was set in order to get rid of the default -Werror setting. i tried to remove those WERROR= overrides from any Makefile, where doing so did not break tinderbox. in those cases, where it couldn't be completely removed, i