Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 13:41, Andriy Gapon wrote: > On 04/11/2017 12:32, Mark Millard wrote: >> if (int Err = ::posix_fallocate(FD, 0, Size)) { >> if (Err != EOPNOTSUPP) >> return std::error_code(Err, std::generic_category()); >> } > > The commit message that you didn't include into your

Re: Head build unsafe for /etc today

2017-11-04 Thread Pete Wright
On 11/03/2017 13:14, Bryan Drewery wrote: On 11/2/2017 8:58 PM, Warner Losh wrote: FreeBSD has grown too big to test every possible thing before you commit. The build itself is massive. I usually forget about release/ and the new 'make packages', external toolchain, "old style" kernel

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 13:58, Ed Maste wrote: > I have no idea how they decided EINVAL was a reasonable errno for this case. I completely agree. That's a weird choice that I have not seen for any other API. -- Andriy Gapon ___ freebsd-toolchain@freebsd.org

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
> Author: avg > Date: Thu Nov 2 13:49:08 2017 > New Revision: 325320 > URL: > https://svnweb.freebsd.org/changeset/base/325320 > > > Log: > Disable posix_fallocate(2) for ZFS > . . . Turns out lld uses fallocate and so can fail on zfs now. The following is the lld for a amd64 -> aarch64

Re: ld (a.k.a. ld.lld) for amd64 -r325369 -> aarch64 cross buildworld is messed up: ld just says "Invalid argument" [vs. binutils ld: R_AARCH64_ABS64 used with TLS symbol]

2017-11-04 Thread Mark Millard
It turns out that svn commit: r325320 breaks lld. lld has code that uses fallocate and now can fail (stop the link) on zfs. I've sent a separate reply to the notice below that gives the details. I added the [...] part of the title. Re: svn commit: r325320 -

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 12:32, Mark Millard wrote: > if (int Err = ::posix_fallocate(FD, 0, Size)) { > if (Err != EOPNOTSUPP) > return std::error_code(Err, std::generic_category()); > } The commit message that you didn't include into your reply contains some useful information that authors /

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Ed Maste
On 4 November 2017 at 07:41, Andriy Gapon wrote: > On 04/11/2017 12:32, Mark Millard wrote: >> if (int Err = ::posix_fallocate(FD, 0, Size)) { >> if (Err != EOPNOTSUPP) >> return std::error_code(Err, std::generic_category()); >> } > > The commit message that you

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
[The patch allowed the amd64 -> aarch64 cross-buildworld to complete instead of failing in lld.] On 2017-Nov-4, at 10:13 AM, Mark Millard wrote: > On 2017-Nov-4, at 10:02 AM, Mark Millard wrote: > > >> On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: >> >>> On 4 November 2017 at 07:41, Andriy

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > On 4 November 2017 at 07:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err = ::posix_fallocate(FD, 0, Size)) { >>>if (Err != EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > On 4 November 2017 at 07:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err = ::posix_fallocate(FD, 0, Size)) { >>>if (Err != EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>

Re: Head build unsafe for /etc today

2017-11-04 Thread Rodney W. Grimes
> On 11/2/2017 8:58 PM, Warner Losh wrote: > > FreeBSD has grown too big to test every possible thing before you commit. I would say that it has always been too big to test every possible thing before a commit. Breakage is just going to happen, we make great efforts to minimize it, but like all

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 10:02 AM, Mark Millard wrote: > On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > >> On 4 November 2017 at 07:41, Andriy Gapon wrote: >>> On 04/11/2017 12:32, Mark Millard wrote: if (int Err = ::posix_fallocate(FD, 0, Size)) { if (Err != EOPNOTSUPP) return

Re: ld (a.k.a. ld.lld) for amd64 -r325369 -> aarch64 cross buildworld is messed up: ld just says "Invalid argument" [vs. binutils ld: R_AARCH64_ABS64 used with TLS symbol]

2017-11-04 Thread Mark Millard
[Top post: contrast with a combination using aarch64-binutils-2.28,1 that does build.] I've found one combination that works: Use of /usr/local/aarch64-freebsd/bin/* binutils materials mixed with use of WITHOUT_DEBUG_FILES= With that it was able to build libc.so.7 and, so, continue with the

Re: [toolchain] lib/clan/llvm.build.mk: Shouldn't BUILD_TRIPLE definition rely host 'cc -dumpmachine'?

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 3:57 PM, Gerald Pfeifer wrote: > On Sun, 29 Oct 2017, Eddy Petrișor wrote: >> Yep --and it is even more complicated: gcc vs. clang are sometimes >> different for the target listed. . . >> >> For example -m32 for amd64 changes the clang result: >> >> # clang -dumpmachine >>

Re: [toolchain] lib/clan/llvm.build.mk: Shouldn't BUILD_TRIPLE definition rely host 'cc -dumpmachine'?

2017-11-04 Thread Eddy Petrișor
Pe 5 nov. 2017 12:57 AM, "Gerald Pfeifer" a scris: On Sun, 29 Oct 2017, Eddy Petrișor wrote: > Yep --and it is even more complicated: gcc vs. clang are sometimes > different for the target listed. . . > > For example -m32 for amd64 changes the clang result: > > # clang

Re: [toolchain] lib/clan/llvm.build.mk: Shouldn't BUILD_TRIPLE definition rely host 'cc -dumpmachine'?

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 5:19 PM, Eddy Petrișor wrote: > Pe 5 nov. 2017 12:57 AM, "Gerald Pfeifer" a scris: > On Sun, 29 Oct 2017, Eddy Petrișor wrote: > > Yep --and it is even more complicated: gcc vs. clang are sometimes > > different for the target listed. . . > > > > For example -m32 for amd64

Re: [toolchain] lib/clan/llvm.build.mk: Shouldn't BUILD_TRIPLE definition rely host 'cc -dumpmachine'?

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 6:02 PM, Mark Millard wrote: > On 2017-Nov-4, at 5:19 PM, Eddy Petrișor wrote: > >> Pe 5 nov. 2017 12:57 AM, "Gerald Pfeifer" a scris: >> On Sun, 29 Oct 2017, Eddy Petrișor wrote: >>> Yep --and it is even more complicated: gcc vs. clang are sometimes >>>

[Bug 223420] [patch] rtld(1): fix formatting glitch

2017-11-04 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223420 Bryan Drewery changed: What|Removed |Added Assignee|freebsd-toolchain@FreeBSD.o

Re: Head build unsafe for /etc today

2017-11-04 Thread Cy Schubert
In message <201711041723.va4hnanj001...@pdx.rh.cn85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > On 11/2/2017 8:58 PM, Warner Losh wrote: > > > FreeBSD has grown too big to test every possible thing before you commit. > > I would say that it has always been too big to test every possible > thing