Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > On 4 November 2017 at 07:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err = ::posix_fallocate(FD, 0, Size)) { >>>if (Err != EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
[The patch allowed the amd64 -> aarch64 cross-buildworld to complete instead of failing in lld.] On 2017-Nov-4, at 10:13 AM, Mark Millard wrote: > On 2017-Nov-4, at 10:02 AM, Mark Millard wrote: > > >> On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: >> >>> On 4 November 2017 at 07:41, Andriy

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 10:02 AM, Mark Millard wrote: > On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > >> On 4 November 2017 at 07:41, Andriy Gapon wrote: >>> On 04/11/2017 12:32, Mark Millard wrote: if (int Err = ::posix_fallocate(FD, 0, Size)) { if (Err != EOPNOTSUPP) return

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
On 2017-Nov-4, at 4:58 AM, Ed Maste wrote: > On 4 November 2017 at 07:41, Andriy Gapon wrote: >> On 04/11/2017 12:32, Mark Millard wrote: >>> if (int Err = ::posix_fallocate(FD, 0, Size)) { >>>if (Err != EOPNOTSUPP) >>> return std::error_code(Err, std::generic_category()); >>> } >>

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 13:58, Ed Maste wrote: > I have no idea how they decided EINVAL was a reasonable errno for this case. I completely agree. That's a weird choice that I have not seen for any other API. -- Andriy Gapon ___ freebsd-toolchain@freebsd.org

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 13:41, Andriy Gapon wrote: > On 04/11/2017 12:32, Mark Millard wrote: >> if (int Err = ::posix_fallocate(FD, 0, Size)) { >> if (Err != EOPNOTSUPP) >> return std::error_code(Err, std::generic_category()); >> } > > The commit message that you didn't include into your

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Ed Maste
On 4 November 2017 at 07:41, Andriy Gapon wrote: > On 04/11/2017 12:32, Mark Millard wrote: >> if (int Err = ::posix_fallocate(FD, 0, Size)) { >> if (Err != EOPNOTSUPP) >> return std::error_code(Err, std::generic_category()); >> } > > The commit message that you

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Andriy Gapon
On 04/11/2017 12:32, Mark Millard wrote: > if (int Err = ::posix_fallocate(FD, 0, Size)) { > if (Err != EOPNOTSUPP) > return std::error_code(Err, std::generic_category()); > } The commit message that you didn't include into your reply contains some useful information that authors /

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]

2017-11-04 Thread Mark Millard
> Author: avg > Date: Thu Nov 2 13:49:08 2017 > New Revision: 325320 > URL: > https://svnweb.freebsd.org/changeset/base/325320 > > > Log: > Disable posix_fallocate(2) for ZFS > . . . Turns out lld uses fallocate and so can fail on zfs now. The following is the lld for a amd64 -> aarch64