Re: usb/107642: [patch]Ralink Technology RT2501USB/RT2601USB chipset driver
Valery V.Chikalov wrote:
Hans Petter Selasky wrote:
On Sunday 29 April 2007 15:02, Valery V.Chikalov wrote:
Kevin Lo wrote:
Valery V.Chikalov wrote:
The following reply was made to PR usb/107642; it has been noted by
GNATS.
From: Valery V.Chikalov [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Cc:
Subject: Re: usb/107642: [patch]Ralink Technology RT2501USB/RT2601USB
chipset driver
Date: Sun, 22 Apr 2007 11:32:18 +0300
This is a multi-part message in MIME format.
--030900090303000507070905
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
if_rum(4) for 7.0-CURRENT
replaced amrr_* functions by standard ones already existed in
net80211/ieee80211_amrr.c
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGKx14760S3kDvEC4RAn8PAKCn990QJE0wZRKcwdxAZ61MY0JRgACeI2W5
ZosSlh6pIqi7JdZ5Wi1BUYc=
=LvWZ
-END PGP SIGNATURE-
Hi Valery,
I guess you wasn't aware that I've already ported rum(4) to FreeBSD.
The patch is available at: http://people.freebsd.org/~kevlo/patch-rum
Maybe you can test my patch? Thanks.
Kevin
Hi, Kevin,
Your driver not working for me. Fortunately, the errors that I see
exactly the same which i fight when I made my driver.
$ uname -a
FreeBSD tiger.novakom.dp.ua 7.0-CURRENT FreeBSD 7.0-CURRENT #6: Sun Apr
29 13:58:48 EEST 2007
[EMAIL PROTECTED]:/usr/obj/usr/src/sys/TIGER64 amd64
$ sysctl kern.osreldate
kern.osreldate: 700037
cvsup'ed 29.04.2007
kernel with:
makeoptions DEBUG=-g
options KDB
options DDB
options INVARIANTS
options INVARIANT_SUPPORT
options WITNESS
At first, when I make kldload if_rum, I get kernel panic.
But I cant get saved core, as ddb just hangs during call doadump
I have a solution for all of this locking stuff!
So I add
#define RUM_LOCK(sc)do { ((sc) = (sc)); mtx_lock(Giant); } while
(0)
#define RUM_UNLOCK(sc) mtx_unlock(Giant)
in if_rumvar.h
I spend a lot of time in attempts get rid of Giant ant always got only
panics.
You _cannot_ do that with the old USB stack, because you must lock Giant
before calling into the usbxxx functions. Then in the USB callback, Giant
is
locked, and then you cannot lock RUM_LOCK()! That means you will most
likely
end up with a deadlock pretty soon, if you see that.
Thanks, for explanations. I suspected that thing are like that, and I
have tried make porting by analogue with other drivers which I can find
in dev/usb, but I was not can find the description of doing right way
locking before.
Firstly, thanks for taking the time to test my patch.
I think your issue is related to watchdog timers. The revised patch is
at http://people.freebsd.org/~kevlo/patch-rum
Besides, I don't get a panic during high load when getting a file about
400MB via ftp.
After that I get hangs,
which i resolved by modifying rum_ioctl:
I'm almost finished converting if_rum.c() to the new USB stack.
In some hours I will update it with support for if_rum.
If you can test that and forget about the old USB stack, I will be very
happy :-)
I will do it with pleasure. I was almost ready to do it (converting to
new USB stack) by myself, but I was stopped by the fact that I cant make
it compiled under CURRENT. I have seen your mail that your are working
on this. Is new the USB stack ready for CURRENT now?
Valery.
--HPS
http://www.turbocat.net/~hselasky/usb4bsd
Kevin
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: usb/107642: [patch]Ralink Technology RT2501USB/RT2601USB chipset driver
Hans Petter Selasky wrote:
On Monday 30 April 2007 14:34, Valery V.Chikalov wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kevin Lo пишет:
Valery V.Chikalov wrote:
Hans Petter Selasky wrote:
On Sunday 29 April 2007 15:02, Valery V.Chikalov wrote:
Kevin Lo wrote:
Valery V.Chikalov wrote:
The following reply was made to PR usb/107642; it has been noted by
GNATS.
From: Valery V.Chikalov [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Cc:
Subject: Re: usb/107642: [patch]Ralink Technology
RT2501USB/RT2601USB chipset driver
Date: Sun, 22 Apr 2007 11:32:18 +0300
This is a multi-part message in MIME format.
--030900090303000507070905
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
if_rum(4) for 7.0-CURRENT
replaced amrr_* functions by standard ones already existed in
net80211/ieee80211_amrr.c
Hi Valery,
I guess you wasn't aware that I've already ported rum(4) to FreeBSD.
The patch is available at: http://people.freebsd.org/~kevlo/patch-rum
Maybe you can test my patch? Thanks.
Kevin
Hi, Kevin,
Your driver not working for me. Fortunately, the errors that I see
exactly the same which i fight when I made my driver.
$ uname -a
FreeBSD tiger.novakom.dp.ua 7.0-CURRENT FreeBSD 7.0-CURRENT #6: Sun
Apr 29 13:58:48 EEST 2007
[EMAIL PROTECTED]:/usr/obj/usr/src/sys/TIGER64 amd64
$ sysctl kern.osreldate
kern.osreldate: 700037
cvsup'ed 29.04.2007
kernel with:
makeoptions DEBUG=-g
options KDB
options DDB
options INVARIANTS
options INVARIANT_SUPPORT
options WITNESS
At first, when I make kldload if_rum, I get kernel panic.
But I cant get saved core, as ddb just hangs during call doadump
I have a solution for all of this locking stuff!
So I add
#define RUM_LOCK(sc)do { ((sc) = (sc)); mtx_lock(Giant); } while
(0)
#define RUM_UNLOCK(sc) mtx_unlock(Giant)
in if_rumvar.h
I spend a lot of time in attempts get rid of Giant ant always got only
panics.
You _cannot_ do that with the old USB stack, because you must lock
Giant before calling into the usbxxx functions. Then in the USB
callback, Giant is locked, and then you cannot lock RUM_LOCK()! That
means you will most likely end up with a deadlock pretty soon, if you
see that.
Thanks, for explanations. I suspected that thing are like that, and I
have tried make porting by analogue with other drivers which I can find
in dev/usb, but I was not can find the description of doing right way
locking before.
Firstly, thanks for taking the time to test my patch.
I think your issue is related to watchdog timers. The revised patch is
at http://people.freebsd.org/~kevlo/patch-rum
Besides, I don't get a panic during high load when getting a file about
400MB via ftp.
Sorry, but the error that I see the same, just after inserting dongle,
or if it was inserted before - after kldload if_rum:
panic: sleeping without a lock
the top of stack:
at usbd_transfer +0x1fe
rum_ioctl
And I cant get saved kernel coredump at the end.
I have not serial console configured so it was just subscribed by hand.
Of course I can reproduce it again and subscribe what you will ask.
I have SMP kernel and use AMD64 architecture, maybe this are the reasons
why we are getting different results.
Can you please, explain me in two words(or give a reference) why you are
dropping mtx_lock(Giant). Yes I have seen the same in if_ural.c and as
i have wrote before unsuccessfully have tried repeat it in if_rum. I
know that current USB stack is not Giant free, and Hans noted that this
is impossible (if I understand him right). Maybe exists some tunable or
kernel option or another trick that allows drivers working without the
Giant under current USB stack, which I must use.
Thank you for your time and patience.
Sorry for my english.
Valery.
After that I get hangs,
which i resolved by modifying rum_ioctl:
I'm almost finished converting if_rum.c() to the new USB stack.
In some hours I will update it with support for if_rum.
If you can test that and forget about the old USB stack, I will be very
happy :-)
I will do it with pleasure. I was almost ready to do it (converting to
new USB stack) by myself, but I was stopped by the fact that I cant make
it compiled under CURRENT. I have seen your mail that your are working
on this. Is new the USB stack ready for CURRENT now?
Valery.
--HPS
http://www.turbocat.net/~hselasky/usb4bsd
Kevin
Hi,
Hi,
I have just imported if_rum.c to SVN and my P4 tree.
Just do a SVN update. Build a new USB package install that.
cp -r i4b/trunk/i4b/src/sys/modules/rum /usr
Re: usb/107642: [patch] add Ralink Technology RT2501USB/RT2601USB chipset driver from OpenBSD
Mark Linimon wrote: Synopsis: [patch] add Ralink Technology RT2501USB/RT2601USB chipset driver from OpenBSD Responsible-Changed-From-To: freebsd-usb-kevlo Responsible-Changed-By: linimon Responsible-Changed-When: Fri Jul 6 08:30:46 UTC 2007 Responsible-Changed-Why: kevlo: is this an MFC candidate? If not, I will go ahead and close this PR. Thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=107642 No. Please close this PR, thanks. Kevin ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: Ralink(0x15a9) and FreeBSD
Lystopad Oleksandr wrote: Hello, Hans Petter Selasky! Hi, I looked at the descriptor dump and I cannot immediately recognize any USB wireless drivers that match that profile. You will have to dig up some more information about what chipset is used. Maybe ask the manufacturer of your laptop? Dear Hans Petter! Thanks for your reply. This is well-known HP Pavilion s3200n. Can you help me to activate wifi on this? The rum(4) supports SparkLAN RT2573 adapter, I committed it yesterday: http://lists.freebsd.org/pipermail/cvs-all/2008-January/243087.html Thanks. Kevin ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to [EMAIL PROTECTED]
High speed isochronous transfer patch
Hi,
The attached patch that adds support for high speed isochronous
transfer, which is taken from NetBSD.
Kevin
diff -ruN sys.orig/dev/usb/ehci.c sys/dev/usb/ehci.c
--- sys.orig/dev/usb/ehci.c 2008-08-15 17:16:07.0 +0800
+++ sys/dev/usb/ehci.c 2008-08-15 17:15:44.0 +0800
@@ -129,7 +129,10 @@
u_int length;
} bulk;
/* Iso pipe */
- /* XXX */
+ struct {
+ u_int next_frame;
+ u_int cur_xfers;
+ } isoc;
} u;
};
@@ -139,6 +142,8 @@
static int ehci_intr1(ehci_softc_t *);
static void ehci_waitintr(ehci_softc_t *, usbd_xfer_handle);
static void ehci_check_intr(ehci_softc_t *, struct ehci_xfer *);
+static void ehci_check_qh_intr(ehci_softc_t *, struct ehci_xfer *);
+static void ehci_check_itd_intr(ehci_softc_t *, struct ehci_xfer *);
static void ehci_idone(struct ehci_xfer *);
static void ehci_timeout(void *);
static void ehci_timeout_task(void *);
@@ -205,6 +210,12 @@
static void ehci_free_sqtd_chain(ehci_softc_t *, ehci_soft_qh_t *,
ehci_soft_qtd_t *, ehci_soft_qtd_t *);
+static ehci_soft_itd_t *ehci_alloc_itd(ehci_softc_t *);
+static void ehci_free_itd(ehci_softc_t *, ehci_soft_itd_t *);
+static void ehci_rem_free_itd_chain(ehci_softc_t *,
+ struct ehci_xfer *);
+static void ehci_abort_isoc_xfer(usbd_xfer_handle, usbd_status);
+
static usbd_status ehci_device_request(usbd_xfer_handle xfer);
static usbd_status ehci_device_setintr(ehci_softc_t *, ehci_soft_qh_t *,
@@ -228,6 +239,10 @@
static void ehci_dump_sqtd(ehci_soft_qtd_t *);
static void ehci_dump_qtd(ehci_qtd_t *);
static void ehci_dump_sqh(ehci_soft_qh_t *);
+#if notyet
+static void ehci_dump_sitd(struct ehci_soft_itd *);
+static void ehci_dump_itd(struct ehci_soft_itd *);
+#endif
#ifdef DIAGNOSTIC
static void ehci_dump_exfer(struct ehci_xfer *);
#endif
@@ -414,8 +429,19 @@
return (err);
DPRINTF((%s: flsize=%d\n, device_get_nameunit(sc-sc_bus.bdev),sc-sc_flsize));
sc-sc_flist = KERNADDR(sc-sc_fldma, 0);
+
+ for (i = 0; i sc-sc_flsize; i++) {
+ sc-sc_flist[i] = EHCI_NULL;
+ }
+
EOWRITE4(sc, EHCI_PERIODICLISTBASE, DMAADDR(sc-sc_fldma, 0));
+ sc-sc_softitds = malloc(sc-sc_flsize * sizeof(ehci_soft_itd_t *),
+ M_USB, M_NOWAIT | M_ZERO);
+ if (sc-sc_softitds == NULL)
+ return (ENOMEM);
+ LIST_INIT(sc-sc_freeitds);
+
/* Set up the bus struct. */
sc-sc_bus.methods = ehci_bus_methods;
sc-sc_bus.pipe_size = sizeof(struct ehci_pipe);
@@ -714,19 +740,31 @@
void
ehci_check_intr(ehci_softc_t *sc, struct ehci_xfer *ex)
{
- ehci_soft_qtd_t *sqtd, *lsqtd;
- u_int32_t status;
+ int attr;
DPRINTFN(/*15*/2, (ehci_check_intr: ex=%p\n, ex));
+ attr = ex-xfer.pipe-endpoint-edesc-bmAttributes;
+ if (UE_GET_XFERTYPE(attr) == UE_ISOCHRONOUS)
+ ehci_check_itd_intr(sc, ex);
+ else
+ ehci_check_qh_intr(sc, ex);
+}
+
+void
+ehci_check_qh_intr(ehci_softc_t *sc, struct ehci_xfer *ex)
+{
+ ehci_soft_qtd_t *sqtd, *lsqtd;
+ u_int32_t status;
+
if (ex-sqtdstart == NULL) {
- printf(ehci_check_intr: sqtdstart=NULL\n);
+ printf(ehci_check_qh_intr: not valid sqtd\n);
return;
}
lsqtd = ex-sqtdend;
#ifdef DIAGNOSTIC
if (lsqtd == NULL) {
- printf(ehci_check_intr: lsqtd==0\n);
+ printf(ehci_check_qh_intr: lsqtd==0\n);
return;
}
#endif
@@ -761,6 +799,64 @@
}
void
+ehci_check_itd_intr(ehci_softc_t *sc, struct ehci_xfer *ex)
+{
+ ehci_soft_itd_t *itd;
+ int i;
+
+ if (ex-itdstart == NULL) {
+ printf(ehci_check_itd_intr: not valid itd\n);
+ return;
+ }
+
+ itd = ex-itdend;
+#ifdef DIAGNOSTIC
+ if (itd == NULL) {
+ printf(ehci_check_itd_intr: itdend == 0\n);
+ return;
+ }
+#endif
+
+ /*
+ * Step 1, check no active transfers in last itd, meaning we're finished
+ */
+ for (i = 0; i 8; i++) {
+ if (le32toh(itd-itd.itd_ctl[i]) EHCI_ITD_ACTIVE)
+ break;
+ }
+
+ if (i == 8) {
+ goto done; /* All 8 descriptors inactive, it's done */
+ }
+
+ /*
+ * Step 2, check for errors in status bits, throughout chain...
+ */
+
+ DPRINTFN(12, (ehci_check_itd_intr: active ex=%p\n, ex));
+
+ for (itd = ex-itdstart; itd != ex-itdend; itd = itd-xfer_next) {
+ for (i = 0; i 8; i++) {
+ if (le32toh(itd-itd.itd_ctl[i]) (EHCI_ITD_BUF_ERR |
+ EHCI_ITD_BABBLE | EHCI_ITD_ERROR))
+break;
+ }
+ if (i != 8) { /* Error in one of the itds */
+ goto done;
+ }
+ } /* itd search loop */
+
+ DPRINTFN(12, (ehci_check_itd_intr: ex %p itd %p still active\n, ex,
+ ex-itdstart));
+ return;
+done:
+ DPRINTFN(12, (ehci_check_itd_intr: ex=%p done\n, ex));
+ callout_stop(ex-xfer.timeout_handle);
+ usb_rem_task(ex-xfer.pipe-device, ex-abort_task);
+ ehci_idone(ex);
+}
+
+void
ehci_idone(struct ehci_xfer *ex)
{
usbd_xfer_handle xfer = ex-xfer;
@@ -826,9 +922,56 @@
}
/* The transfer is done, compute actual length and status. */
+ if (UE_GET_XFERTYPE(xfer-pipe-endpoint-edesc-bmAttributes)
+ == UE_ISOCHRONOUS) {
+ /* Isoc transfer */
+ struct ehci_soft_itd *itd;
+ int i, nframes, len, uframes;
+
+ nframes = 0;
+ actlen = 0;
+
+ switch
Re: DWA-110 is supported by if_rum
Jonathan Lee wrote:
I've tested D-LINK's DWA-110 on
% uname -a
FreeBSD johnny.mnemoni.ca 7.0-STABLE
FreeBSD 7.0-STABLE #5: Sun Aug 10 15:26:30 EEST 2008
[EMAIL PROTECTED]:/usr/obj/usr/src/sys/JOHNNY i386
It works OK, except for some errors:
Aug 12 11:00:36 johnny kernel: wpi0: timeout resetting Tx ring 1
Aug 12 11:00:36 johnny kernel: wpi0: timeout resetting Tx ring 3
Aug 12 11:00:36 johnny kernel: wpi0: timeout resetting Tx ring 4
Aug 14 22:49:26 johnny kernel: rum0: Ralink 802.11 bg WLAN, class 0/0, rev
2.00/0.01, addr 3 on uhub4
Aug 14 22:49:26 johnny kernel: rum0: MAC/BBP RT2573 (rev 0x2573a), RF RT2528
Aug 14 22:49:27 johnny kernel: rum0: WARNING: using obsoleted IFF_NEEDSGIANT
flag
You can see my original message to freebsd-drivers:
http://lists.freebsd.org/pipermail/freebsd-drivers/2008-August/000753.html
Anyway, the device is supported. Someone responsible
could add the following to /usr/src/sys/dev/usb/:
usbdevs:
product DLINK2 DWA110 0x3c07 DWA-110
if_rum.c:
{ USB_VENDOR_DLINK2, USB_PRODUCT_DLINK2_DWA110 },
Added, thanks.
EOF.
Kevin
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HEADSUP: urtw(4) to be committed soon
Weongyo Jeong wrote: Hello, Hi Weongyo, I would like to commit urtw(4) driver for supporting Realtek's 8187L wireless chipset based on USB into HEAD by the end of the week if there are no objections. And the license of files would be as follows that AFAIK it's based on OpenBSD's template license file: /*- * Copyright (c) 2008 Weongyo Jeong weon...@freebsd.org * * Permission to use, copy, modify, and distribute this software for any * purpose with or without fee is hereby granted, provided that the above * copyright notice and this permission notice appear in all copies. * * THE SOFTWARE IS PROVIDED AS IS AND THE AUTHOR DISCLAIMS ALL WARRANTIES * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ Because I'm not a lawyer it'd definitely fail to answer about your detailed questions. Just one thing I want to is that it's okay if it's enough to use in *BSD, OpenSolaris and etc. Not want to go into troubles. :-) I'm looking for a person to port from USB to NEWUSB and if you want to test you can find the sources at: http://people.freebsd.org/~weongyo/urtw_20090119.tar.gz Works for me, thanks. Though it's quite a bit slower, that's a job for another day :-) $ dmesg | grep urtw0 urtw0: vendor 0x0bda RTL8187_Wireless, class 0/0, rev 1.10/1.00, addr 2 on uhub0 urtw0: WARNING: using obsoleted IFF_NEEDSGIANT flag $ ifconfig plip0: flags=108810POINTOPOINT,SIMPLEX,MULTICAST,NEEDSGIANT metric 0 mtu 1500 lo0: flags=8049UP,LOOPBACK,RUNNING,MULTICAST metric 0 mtu 16384 inet6 fe80::1%lo0 prefixlen 64 scopeid 0x5 inet6 ::1 prefixlen 128 inet 127.0.0.1 netmask 0xff00 urtw0: flags=108843UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST,NEEDSGIANT metric 0 mtu 2290 ether 00:40:0c:04:3b:2a media: IEEE 802.11 Wireless Ethernet autoselect mode 11g status: associated wlan0: flags=8843UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST metric 0 mtu 1500 ether 00:40:0c:04:3b:2a inet 192.168.1.116 netmask 0xff00 broadcast 192.168.1.255 media: IEEE 802.11 Wireless Ethernet autoselect mode 11g status: associated ssid MSI channel 11 (2462 Mhz 11g) bssid 00:11:09:0c:2f:91 country US authmode OPEN privacy OFF txpower 0 bmiss 7 scanvalid 60 bgscan bgscanintvl 300 bgscanidle 250 roam:rssi 7 roam:rate 5 protmode CTS regards, Weongyo Jeong Kevin ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: USB 3.0 support by default?
Hans Petter Selasky wrote: Hi, Should the device xhci be included by default in GENERIC for amd64 and i386 before FreeBSD 9 is released? I can't find any reason why it's not here :) --HPS Kevin ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb quirks for ugen0.2: at usbus0
Fixed in r325787, thanks. On Tue, Nov 14, 2017 at 09:50:24AM +1000, Kris G wrote: > > It doesn't use "ure" it makes use of "rue" > > ure - RealTek RTL8152 USB to Fast Ethernet controller driver > rue - RealTek RTL8150 USB to Fast Ethernet controller driver > > The TP-LINK USB 3.0 NIC is RTL8153 chipset - > http://www.tp-link.com/us/products/details/cat-5523_TL-UE300.html#specifications > > I don't even have ure in my kernel.. the only lines I had to add was.. > > device cdce > device rue > > /var/log/dmesg.today:ue0: on cdce0 > /var/log/dmesg.today:ue0: Ethernet address: d4:6e:0e:0c:67:c5 > > I am now confused as to what you would like me to patch and test...? > > > > On Tue, Nov 14, 2017 at 1:01 AM, Hans Petter Selasky <h...@selasky.org> > wrote: > > > On 11/13/17 14:54, Kevin Lo wrote: > > > >> On Fri, Nov 10, 2017 at 08:42:45AM +0100, Hans Petter Selasky wrote: > >> > >>> > >>> On 11/10/17 02:59, Kris G wrote: > >>> > >>>> USB_QUIRK(TPLINK, RTL8153, 0x, 0x, UQ_CFG_INDEX_1), > >>>> > >>> > >>> Thank you for your quirk: > >>> > >>> https://svnweb.freebsd.org/changeset/base/325630 > >>> > >> > >> Err, that's incorrect. The quirk is not necessary and you should add > >> vid/pid > >> to ure(4) instead. > >> > >> > > Hi Kris, > > > > Can you make a new patch for ure(4) and test? > > > > --HPS > > > > > ___ > freebsd-usb@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-usb > To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org" > ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
Re: usb quirks for ugen0.2: at usbus0
On Fri, Nov 10, 2017 at 08:42:45AM +0100, Hans Petter Selasky wrote: > > On 11/10/17 02:59, Kris G wrote: > > USB_QUIRK(TPLINK, RTL8153, 0x, 0x, UQ_CFG_INDEX_1), > > Thank you for your quirk: > > https://svnweb.freebsd.org/changeset/base/325630 Err, that's incorrect. The quirk is not necessary and you should add vid/pid to ure(4) instead. > --HPS Kevin ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
