Re: Quirk for a USB mass storage device

2011-11-01 Thread Pawel Jakub Dawidek
On Sun, Oct 30, 2011 at 09:15:40PM +0100, Hans Petter Selasky wrote: On Saturday 29 October 2011 20:38:07 Pawel Jakub Dawidek wrote: + err = usbd_do_request(udev, NULL, req, buf); + if (err) + buf = 0; + + return (buf); +} You could drop 'err'

Re: Quirk for a USB mass storage device

2011-11-01 Thread Hans Petter Selasky
On Tuesday 01 November 2011 13:15:33 Pawel Jakub Dawidek wrote: On Sun, Oct 30, 2011 at 09:15:40PM +0100, Hans Petter Selasky wrote: On Saturday 29 October 2011 20:38:07 Pawel Jakub Dawidek wrote: + err = usbd_do_request(udev, NULL, req, buf); + if (err) + buf =

Re: Quirk for a USB mass storage device

2011-10-30 Thread Hans Petter Selasky
On Saturday 29 October 2011 20:38:07 Pawel Jakub Dawidek wrote: + err = usbd_do_request(udev, NULL, req, buf); + if (err) + buf = 0; + + return (buf); +} You could drop 'err' variable and just check function return directly. There is only one extra empty

Re: Quirk for a USB mass storage device

2011-10-29 Thread Hans Petter Selasky
On Friday 28 October 2011 17:08:18 Gustau Pérez wrote: Do you want the patch? I can generate it in a second if you wish. Yes, please do. This one applies over both current and 9.0RC1. Gus Hi Pawel and Gustau, Can you both clean out your own patches and try the attached one?

Re: Quirk for a USB mass storage device

2011-10-29 Thread Gustau Pérez
Al 29/10/2011 08:51, En/na Hans Petter Selasky ha escrit: On Friday 28 October 2011 17:08:18 Gustau Pérez wrote: Do you want the patch? I can generate it in a second if you wish. Yes, please do. This one applies over both current and 9.0RC1. Gus Hi Pawel and Gustau, Can you both

Re: Quirk for a USB mass storage device

2011-10-29 Thread Hans Petter Selasky
Will be MFC'ed in a few days. http://svn.freebsd.org/changeset/base/226903 --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org

Re: Quirk for a USB mass storage device

2011-10-29 Thread Pawel Jakub Dawidek
On Sat, Oct 29, 2011 at 08:51:15AM +0200, Hans Petter Selasky wrote: On Friday 28 October 2011 17:08:18 Gustau Pérez wrote: Do you want the patch? I can generate it in a second if you wish. Yes, please do. This one applies over both current and 9.0RC1. Gus Hi Pawel

Re: Quirk for a USB mass storage device

2011-10-28 Thread Hans Petter Selasky
On Friday 28 October 2011 07:27:19 Gustau Pérez wrote: Al 27/10/2011 20:28, En/na Hans Petter Selasky ha escrit: On Thursday 27 October 2011 10:12:46 Gustau Pérez wrote: Hi, I'm running FreeBSD 10.0 r226042 on AMD64 and I'm having problems with the following device:

Quirk for a USB mass storage device

2011-10-27 Thread Gustau Pérez
Hi, I'm running FreeBSD 10.0 r226042 on AMD64 and I'm having problems with the following device: umass0: Kingston DataTraveler 200, class 0/0, rev 2.00/1.10, addr 7 on usbus0 umass0: SCSI over Bulk-Only; quirks = 0x4001 umass0: Get Max Lun not supported

Re: Quirk for a USB mass storage device

2011-10-27 Thread Hans Petter Selasky
On Thursday 27 October 2011 10:12:46 Gustau Pérez wrote: Hi, I'm running FreeBSD 10.0 r226042 on AMD64 and I'm having problems with the following device: umass0: Kingston DataTraveler 200, class 0/0, rev 2.00/1.10, addr 7 on usbus0 umass0: SCSI over Bulk-Only;

Re: Quirk for a USB mass storage device

2011-10-27 Thread Gustau Pérez
Al 27/10/2011 20:28, En/na Hans Petter Selasky ha escrit: On Thursday 27 October 2011 10:12:46 Gustau Pérez wrote: Hi, I'm running FreeBSD 10.0 r226042 on AMD64 and I'm having problems with the following device: umass0: Kingston DataTraveler 200, class 0/0, rev 2.00/1.10,