Re: may I commit this small umodem patch ?

2008-07-05 Thread Hans Petter Selasky
On Saturday 05 July 2008, Luigi Rizzo wrote: On Sat, Jul 05, 2008 at 12:28:47AM +0200, Hans Petter Selasky wrote: On Friday 04 July 2008, Luigi Rizzo wrote: On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky wrote: On Thursday 03 July 2008, Luigi Rizzo wrote: On Thu, Jul

Re: may I commit this small umodem patch ?

2008-07-05 Thread Luigi Rizzo
On Sat, Jul 05, 2008 at 09:57:06AM +0200, Hans Petter Selasky wrote: On Saturday 05 July 2008, Luigi Rizzo wrote: On Sat, Jul 05, 2008 at 12:28:47AM +0200, Hans Petter Selasky wrote: On Friday 04 July 2008, Luigi Rizzo wrote: On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky

Re: may I commit this small umodem patch ?

2008-07-05 Thread Bernd Walter
On Sat, Jul 05, 2008 at 10:56:14PM +0200, Hans Petter Selasky wrote: On Saturday 05 July 2008, Bernd Walter wrote: On Sat, Jul 05, 2008 at 09:57:06AM +0200, Hans Petter Selasky wrote: Yes, but you know that umodem can drop data, if the buffers overflow ? Do you mean the driver can

Re: may I commit this small umodem patch ?

2008-07-05 Thread Hans Petter Selasky
On Saturday 05 July 2008, Bernd Walter wrote: On Sat, Jul 05, 2008 at 09:57:06AM +0200, Hans Petter Selasky wrote: On Saturday 05 July 2008, Luigi Rizzo wrote: On Sat, Jul 05, 2008 at 12:28:47AM +0200, Hans Petter Selasky wrote: On Friday 04 July 2008, Luigi Rizzo wrote: On Fri, Jul

Re: may I commit this small umodem patch ?

2008-07-05 Thread Bernd Walter
On Sat, Jul 05, 2008 at 11:50:32PM +0200, Bernd Walter wrote: On Sat, Jul 05, 2008 at 10:56:14PM +0200, Hans Petter Selasky wrote: On Saturday 05 July 2008, Bernd Walter wrote: On Sat, Jul 05, 2008 at 09:57:06AM +0200, Hans Petter Selasky wrote: Yes, but you know that umodem can drop

Re: may I commit this small umodem patch ?

2008-07-04 Thread Hans Petter Selasky
On Friday 04 July 2008, Luigi Rizzo wrote: On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky wrote: On Thursday 03 July 2008, Luigi Rizzo wrote: On Thu, Jul 03, 2008 at 05:07:00PM +0200, Gary Jennejohn wrote: On Thu, 3 Jul 2008 16:07:19 +0200 Luigi Rizzo [EMAIL

Re: may I commit this small umodem patch ?

2008-07-04 Thread Luigi Rizzo
On Sat, Jul 05, 2008 at 12:28:47AM +0200, Hans Petter Selasky wrote: On Friday 04 July 2008, Luigi Rizzo wrote: On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky wrote: On Thursday 03 July 2008, Luigi Rizzo wrote: On Thu, Jul 03, 2008 at 05:07:00PM +0200, Gary Jennejohn

Re: may I commit this small umodem patch ?

2008-07-04 Thread Xiaofan Chen
On Sat, Jul 5, 2008 at 5:39 AM, Luigi Rizzo [EMAIL PROTECTED] wrote: What about flow control? Is flow control required for these devices? the ones I am talking about don't implement any form of flow control. I suppose they would otherwise match the previous check. They are many of this

Re: may I commit this small umodem patch ?

2008-07-03 Thread Gary Jennejohn
On Thu, 3 Jul 2008 16:07:19 +0200 Luigi Rizzo [EMAIL PROTECTED] wrote: There was a discussion back in september about adding support for basic CDC tty devices in umodem.c. This lets you talk to a number of usb devices built around microcontrollers (e.g. Atmel), and puts us on par with Linux

Re: may I commit this small umodem patch ?

2008-07-03 Thread Luigi Rizzo
On Thu, Jul 03, 2008 at 05:07:00PM +0200, Gary Jennejohn wrote: On Thu, 3 Jul 2008 16:07:19 +0200 Luigi Rizzo [EMAIL PROTECTED] wrote: There was a discussion back in september about adding support for basic CDC tty devices in umodem.c. This lets you talk to a number of usb devices built

Re: may I commit this small umodem patch ?

2008-07-03 Thread Alexander Sabourenkov
Gary Jennejohn wrote: On Thu, 3 Jul 2008 16:07:19 +0200 Luigi Rizzo [EMAIL PROTECTED] wrote: [...] +#if 1 + if (ret == UMATCH_NONE + id-bInterfaceClass == UICLASS_CDC_DATA + id-bInterfaceSubClass == UISUBCLASS_DATA + id-bInterfaceProtocol == 0x00) +