[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Kyle Evans changed: What|Removed |Added CC||kev...@freebsd.org Flags||mfc-stable11? Assignee|freebsd-usb@FreeBSD.org |kev...@freebsd.org --- Comment #14 from Kyle Evans --- This feature had been committed (in a different form) as r314467. Hijacking this PR for MFC tracking, and wsp(4) should probably be updated in a similar fashion to the patch attached here to indicate the existence of this new sysctl. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #13 from David O'Rourke --- This feature has now been updated for 10.3. I'll be looking at FreeBSD 11 shortly and providing a new patch if needed. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Attachment #151510|0 |1 is obsolete|| --- Comment #12 from David O'Rourke --- Created attachment 179771 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179771&action=edit wsp.4 man page update Updated man page for 10.3. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Attachment #151509|0 |1 is obsolete|| --- Comment #11 from David O'Rourke --- Created attachment 179770 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179770&action=edit wsp.c one finger tap One finger tap patch updated for 10.3 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Severity|Affects Only Me |Affects Some People -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Version|10.1-RELEASE|10.3-RELEASE -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Dave Cottlehuber changed: What|Removed |Added CC||d...@skunkwerks.at --- Comment #10 from Dave Cottlehuber --- I would be interested in this too if it can be bumped for 11 or 12. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #9 from Thomas Brierley --- No I'm wrong... it fails, sorry. I can submit a new one based on the same changes later today if you like, I need it anyway. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #7 from Thomas Brierley --- The patch still needs to be applied. None of the branches have this in wsp.c (or anything equivalent). wsp.c in STABLE is at the same commit as RELEASE. CURRENT has a couple of small changes that aren't for touch click. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #6 from David O'Rourke --- A quick look at the source for wsp.c on github suggests that the patch is still needed, however work on wsp.c since I submitted this patch means it won't apply cleanly anymore. If there is still interest in this feature, I should be able to clean up the .diff later on so that it once again apples to HEAD. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Hans Petter Selasky changed: What|Removed |Added CC||hsela...@freebsd.org --- Comment #5 from Hans Petter Selasky --- Hi, Is this issue fixed in 10-stable? Or is this patch still needed? --HPS -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Thomas Brierley changed: What|Removed |Added CC||tom...@gmail.com --- Comment #4 from Thomas Brierley --- I did exactly the same thing under a different OID before seeing this :D Tested on 10.3-RELEASE -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #3 from David O'Rourke --- Created attachment 151510 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151510&action=edit wsp(4) updated to include details of one finger tap. wsp(4) man page with one finger tap details. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #2 from David O'Rourke --- Created attachment 151509 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151509&action=edit wsp.c one finger tap. One finger tap left-click for wsp.c. Resubmitting after Bugzilla maintenance issues. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #1 from Gavin Atkinson --- Hi, Due to an issue with the backend FreeBSD Bugzilla database, your original PR and any updates to it since have been lost. I've recreated the original PR as best as I can, however any attachments and updates you submitted to the PR have been lost. Please could you resubmit them? Thanks, and apologies. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Attachment #151530|0 |1 is obsolete|| --- Comment #8 from David O'Rourke --- Created attachment 151554 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151554&action=edit Updated wsp.4 detailing one finger tap support. Small change regarding the enabled value. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Attachment #151529|0 |1 is obsolete|| --- Comment #7 from David O'Rourke --- Created attachment 151553 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151553&action=edit One finger tap support, defaulting to 1 (ON), value clamped. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #6 from David O'Rourke --- Just noticed that I failed to clamp the values. I'll have some updated diffs shortly. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #5 from David O'Rourke --- Created attachment 151530 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151530&action=edit Updated wsp.4 detailing one finger tap support. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 David O'Rourke changed: What|Removed |Added Attachment #151508|0 |1 is obsolete|| --- Comment #4 from David O'Rourke --- Created attachment 151529 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151529&action=edit One finger tap support, defaulting to 1 (ON). Change .one_finger_tap to be on by default, as suggested by HPS. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #3 from David O'Rourke --- I can change the default to enabled if you think that would be preferred, I wasn't sure how others would feel about the default functionality of the trackpad suddenly changing. I'll make that change and submit both the wsp.c patch and the man page patch later today. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 --- Comment #2 from Hans Petter Selasky --- Is there a reason for not leaving the default: +.one_finger_tap = 0, Enabled? Left clicking this way is quite useful. --HPS -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Hans Petter Selasky changed: What|Removed |Added Status|New |In Progress CC||hsela...@freebsd.org --- Comment #1 from Hans Petter Selasky --- Patch looks good. Will commit it once you have updated the manual page too. Thanks! --HPS -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"
[Bug 196624] [patch] wsp.c toggle for one finger tap when integrated button is detected.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196624 Bug ID: 196624 Summary: [patch] wsp.c toggle for one finger tap when integrated button is detected. Product: Base System Version: 10.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: usb Assignee: freebsd-usb@FreeBSD.org Reporter: dor@fastmail.fm Created attachment 151508 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151508&action=edit Add one_finger_tap setting to wsp.c This patch adds hw.usb.wsp.one_finger_tap which allows toggling left clicking by tapping on the trackpad with a single finger. Setting it to 0 disables, setting it to >= 1 enables. I have not updated the wsp(4) man page yet, but will be doing so shortly. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"