Re: RFC: new USB quirk
Hi, Looks good. Go ahead and commit. BTW: Is it possible to auto detect this quirk? Then you might consider adding some code to dev/usb/usb_msctest.c . --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: RFC: new USB quirk
On Nov 5, 2012, at 9:58 AM, Hans Petter Selasky hsela...@c2i.net wrote: Hi, Looks good. Go ahead and commit. Thanks. BTW: Is it possible to auto detect this quirk? Then you might consider adding some code to dev/usb/usb_msctest.c . I don't know enough to say anything with confidence. It looks to me that you first want to know if the device has removable media and whether there's a medium inserted before you reach conclusions about whether a failed prevent/allow media removal command is an indication that UQ_MSC_NO_PREVENT_ALLOW should be used for the device. -- Marcel Moolenaar mar...@xcllnt.net ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: RFC: new USB quirk
On Saturday 03 November 2012 22:42:33 Marcel Moolenaar wrote:
Hans,
Juniper has a few products that use STmicro USB-NAND controllers
(the ST72682 in particular) and they really don't like the SCSI
command for prevent/allow medium removal. The attached patch
adds a quirk for this to avoid spamming the console with errors
or warnings.
Does it look good to you?
Ok to commit?
Thanks,
Hi,
You also need to update this table in usb_quirk.c:
static const char *usb_quirk_str[USB_QUIRK_MAX] = {
[UQ_NONE] = UQ_NONE,
Can you do that and send a new patch for review?
--HPS
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: RFC: new USB quirk
On Nov 4, 2012, at 2:47 AM, Hans Petter Selasky hsela...@c2i.net wrote:
On Saturday 03 November 2012 22:42:33 Marcel Moolenaar wrote:
Hans,
Juniper has a few products that use STmicro USB-NAND controllers
(the ST72682 in particular) and they really don't like the SCSI
command for prevent/allow medium removal. The attached patch
adds a quirk for this to avoid spamming the console with errors
or warnings.
Does it look good to you?
Ok to commit?
Thanks,
Hi,
You also need to update this table in usb_quirk.c:
static const char *usb_quirk_str[USB_QUIRK_MAX] = {
[UQ_NONE] = UQ_NONE,
Can you do that and send a new patch for review?
See attached.
FYI,
--
Marcel Moolenaar
mar...@xcllnt.net
usb.diff
Description: Binary data
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
