Re: use_generic and usb probing

2011-05-18 Thread Andriy Gapon
on 17/05/2011 10:19 Andriy Gapon said the following: > So I am going to commit this. > If it breaks anything for anyone and the problem would not be really trivial, > the I'll just revert the change. > r222051. Please take this commit in consideration if you run into any USB-related problems. -

Re: use_generic and usb probing

2011-05-17 Thread Andriy Gapon
on 06/04/2011 16:28 Hans Petter Selasky said the following: > > Run a kernel test compile including all modules. If that's OK it should be > fine. So I am going to commit this. If it breaks anything for anyone and the problem would not be really trivial, the I'll just revert the change. -- And

Re: use_generic and usb probing

2011-04-13 Thread Andriy Gapon
on 13/04/2011 00:48 Nick Hibma said the following: >> Well, I think that that's what probe priorities actually for. I also think >> that typically ivars should be set by a bus driver. So maybe it's not such a >> good idea to pass data from probe to attach via ivars in child drivers. But I >> could

Re: use_generic and usb probing

2011-04-12 Thread Nick Hibma
> Well, I think that that's what probe priorities actually for. > I also think that typically ivars should be set by a bus driver. So maybe > it's > not such a good idea to pass data from probe to attach via ivars in child > drivers. > But I could be mistaken about that. > > Practically speakin

Re: use_generic and usb probing

2011-04-06 Thread Andriy Gapon
on 06/04/2011 16:28 Hans Petter Selasky said the following: > On Wednesday 06 April 2011 15:21:19 Andriy Gapon wrote: >> on 06/04/2011 10:33 Hans Petter Selasky said the following: > >> >> Which drivers I have missed? >> Thanks! > > Run a kernel test compile including all modules. If that's OK it

Re: use_generic and usb probing

2011-04-06 Thread Hans Petter Selasky
On Wednesday 06 April 2011 15:21:19 Andriy Gapon wrote: > on 06/04/2011 10:33 Hans Petter Selasky said the following: > > Which drivers I have missed? > Thanks! Run a kernel test compile including all modules. If that's OK it should be fine. --HPS __

Re: use_generic and usb probing

2011-04-06 Thread Andriy Gapon
on 06/04/2011 10:33 Hans Petter Selasky said the following: > After looking at subr_usb.c I see your solution is fine as long as the > PROBE() > method that it attaches is the last one called before ATTACH(). If this is > documented in how newbus should function, then please go ahead updating yo

Re: use_generic and usb probing

2011-04-06 Thread John Baldwin
On Wednesday, April 06, 2011 3:33:47 am Hans Petter Selasky wrote: > On Tuesday 05 April 2011 18:45:51 Andriy Gapon wrote: > > on 05/04/2011 15:55 Hans Petter Selasky said the following: > > > On Tuesday 05 April 2011 14:50:43 Andriy Gapon wrote: > > >> I believe that newbus already supports orderi

Re: use_generic and usb probing

2011-04-06 Thread Hans Petter Selasky
On Tuesday 05 April 2011 18:45:51 Andriy Gapon wrote: > on 05/04/2011 15:55 Hans Petter Selasky said the following: > > On Tuesday 05 April 2011 14:50:43 Andriy Gapon wrote: > >> I believe that newbus already supports ordering of children on a bus. > >> > >> BTW, does USB have to pass anything fro

Re: use_generic and usb probing

2011-04-05 Thread Andriy Gapon
on 05/04/2011 15:55 Hans Petter Selasky said the following: > On Tuesday 05 April 2011 14:50:43 Andriy Gapon wrote: >> >> I believe that newbus already supports ordering of children on a bus. >> >> BTW, does USB have to pass anything from probe to attach? > > Mostly only the driver info field. To

Re: use_generic and usb probing

2011-04-05 Thread Hans Petter Selasky
On Tuesday 05 April 2011 14:50:43 Andriy Gapon wrote: > > I believe that newbus already supports ordering of children on a bus. > > BTW, does USB have to pass anything from probe to attach? Mostly only the driver info field. To avoid duplicate lookups. > Duplicate lookup is of course not very n

Re: use_generic and usb probing

2011-04-05 Thread Andriy Gapon
on 05/04/2011 14:21 Hans Petter Selasky said the following: > On Tuesday 05 April 2011 13:06:22 Andriy Gapon wrote: >> on 03/04/2011 13:46 Andriy Gapon said the following: >>> Mostly out of curiosity (but not only because of that) I wonder why the >>> use_generic flag and two probing passes are nee

Re: use_generic and usb probing

2011-04-05 Thread Hans Petter Selasky
On Tuesday 05 April 2011 13:06:22 Andriy Gapon wrote: > on 03/04/2011 13:46 Andriy Gapon said the following: > > Mostly out of curiosity (but not only because of that) I wonder why the > > use_generic flag and two probing passes are needed in USB driver probing > > code. That is, why the standard a

Re: use_generic and usb probing

2011-04-05 Thread Andriy Gapon
on 03/04/2011 13:46 Andriy Gapon said the following: > > Mostly out of curiosity (but not only because of that) I wonder why the > use_generic flag and two probing passes are needed in USB driver probing code. > That is, why the standard approach of using different probing return values > (e.g. BU