[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

rgrimes added reviewers: bhyve, grehan. rgrimes added a comment. I dont know why it did that, I tried to simply "accept revision" and it removed all other reviewers, so put them back. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENC

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

rgrimes removed reviewers: bhyve, grehan. rgrimes accepted this revision as: rgrimes. This revision is now accepted and ready to land. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailp

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de marked 5 inline comments as done. fabian.freyer_physik.tu-berlin.de added a comment. I hope I got them all now REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/setting

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de updated this revision to Diff 39622. fabian.freyer_physik.tu-berlin.de added a comment. addressed @grehan's comments regarding style(9) REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D14473?vs=39619&id=39622 RE

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

grehan added inline comments. INLINE COMMENTS > bhyveload.c:566 > +{ > + return (vm_get_capability(ctx, vcpu, > + VM_CAP_UNRESTRICTED_GUEST, retval)); Minor style(9) - should be an empty line before the rreturn - see the routine above. > bhyveload.c:567 > + return (

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de marked an inline comment as done. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: fabian.freyer_physik.tu-berlin.de, imp, #bhyve, gr

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de updated this revision to Diff 39619. fabian.freyer_physik.tu-berlin.de edited the summary of this revision. fabian.freyer_physik.tu-berlin.de edited the test plan for this revision. fabian.freyer_physik.tu-berlin.de added a comment. This revision now requires revie

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

grehan accepted this revision. grehan added a comment. You may be able to get away with just the "set" call. Given that all h/w that is supported by bhyve, with the exception of only Nehalem systems, support this, you may want to use just the error from the set call to handle this low-probab

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

rgrimes added a reviewer: bhyve. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: fabian.freyer_physik.tu-berlin.de, imp, #bhyve Cc: imp, freebsd-virtualization-list,

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de added a comment. I may also add a vcpu_reset callback still, would be nice to have that in as well. INLINE COMMENTS > userboot.h:45 > +/* > + * Version 5 adds callbacks to set up long mode and set > + * unrestricted guest capabilities. The callback structure

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

imp accepted this revision. This revision is now accepted and ready to land. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D14473 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: fabian.freyer_physik.tu-berlin.de, imp Cc

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

fabian.freyer_physik.tu-berlin.de created this revision. fabian.freyer_physik.tu-berlin.de added a project: bhyve. Herald added subscribers: Contributor Reviews (base), imp. REVISION SUMMARY The current userboot interface sets this capability using `vm_setup_freebsd_registers_i386` in lib/libvm