Re: RFC: ipfw nat VIMAGE improvements

2013-08-25 Thread Mikolaj Golub
On Thu, Aug 15, 2013 at 12:25:34AM +0200, Marko Zec wrote: > Anyhow, this looks fine to me... Thanks, committed as r254776. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/free

Re: RFC: ipfw nat VIMAGE improvements

2013-08-14 Thread Mikolaj Golub
On Wed, Aug 14, 2013 at 05:28:31PM +0200, Marko Zec wrote: > On Sunday 11 August 2013 22:01:12 Mikolaj Golub wrote: > > Hi, > > > > I would like to commit this patch that fixes some issues related to > > ipfw nat module load/unload on VIMAGE featured system. >

Re: RFC: carp(4): improved VIMAGE support

2013-08-14 Thread Mikolaj Golub
On Tue, Aug 13, 2013 at 11:26:31AM +0400, Gleb Smirnoff wrote: > On Mon, Aug 12, 2013 at 10:45:17PM +0300, Mikolaj Golub wrote: > M> On Mon, Aug 12, 2013 at 02:16:15PM +0400, Gleb Smirnoff wrote: > M> > On Sun, Aug 11, 2013 at 11:08:35PM +0300, Mikolaj Golub wrote: > M>

Re: RFC: carp(4): improved VIMAGE support

2013-08-12 Thread Mikolaj Golub
On Mon, Aug 12, 2013 at 02:16:15PM +0400, Gleb Smirnoff wrote: > On Sun, Aug 11, 2013 at 11:08:35PM +0300, Mikolaj Golub wrote: > M> Hi, > M> > M> I would like to virtualize carp(4) variables to have per vnet control. > M> > M> Any comments, objections? >

RFC: carp(4): improved VIMAGE support

2013-08-11 Thread Mikolaj Golub
Hi, I would like to virtualize carp(4) variables to have per vnet control. Any comments, objections? -- Mikolaj Golub commit 646e0b161ae7782259335cec652e178652ed7af3 Author: Mikolaj Golub Date: Tue Aug 6 23:47:31 2013 +0300 Virtualize carp(4) variables for per vnet control. diff --git

RFC: ipfw nat VIMAGE improvements

2013-08-11 Thread Mikolaj Golub
Hi, I would like to commit this patch that fixes some issues related to ipfw nat module load/unload on VIMAGE featured system. Any comments, objections? -- Mikolaj Golub commit 47338ad7fea6d0280461562f0345570557b0d9b1 Author: Mikolaj Golub Date: Sun Aug 4 13:49:50 2013 +0300 Make ipfw

Re: lagg panic

2013-06-07 Thread Mikolaj Golub
On Mon, Feb 11, 2013 at 02:36:17PM +0200, Nikos Vassiliadis wrote: > Hi, > > I just noticed this is not committed. Could somebody commit it? > > http://lists.freebsd.org/pipermail/freebsd-net/2011-November/030526.html > Committed (r251490). Thanks.

Re: pf + vimage patch

2013-06-06 Thread Mikolaj Golub
ly your patch looks like a partial revert of that commit. So I think you need to think about this issue from start. At least it should not crash non-vimage kernel and there should be understanding how to fix it for vimage kernel. Your approach with keeping only one purge thread might make it simp

Re: pf + vimage patch

2013-06-05 Thread Mikolaj Golub
/* > - * Order is important: > - * - states and src nodes reference rules > - * - states and rules reference kifs > - */ > - pf_purge_expired_fragments(); > -

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-09 Thread Mikolaj Golub
On Mon, 9 Jul 2012 06:07:05 + Bjoern A. Zeeb wrote: BAZ> On 9. Jul 2012, at 06:01 , Mikolaj Golub wrote: >> >> On Sun, 8 Jul 2012 20:52:55 + Bjoern A. Zeeb wrote: >> >> BAZ> Situation 1) >> >> BAZ> epairNa is in base, eipar

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-08 Thread Mikolaj Golub
n provide the patch. BAZ> The moment cloners will handle this it'll all be centrally managed BAZ> and individual device drivers shouldn't need to worry about it anymore. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailin

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-08 Thread Mikolaj Golub
On Sat, 7 Jul 2012 20:38:23 + Bjoern A. Zeeb wrote: BAZ> On 6. Jul 2012, at 05:53 , Mikolaj Golub wrote: >> >> On Thu, 5 Jul 2012 20:21:53 + Bjoern A. Zeeb wrote: >> >> BAZ> On 5. Jul 2012, at 19:53 , Mikolaj Golub wrote: >> >>>&g

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-05 Thread Mikolaj Golub
On Thu, 5 Jul 2012 20:21:53 + Bjoern A. Zeeb wrote: BAZ> On 5. Jul 2012, at 19:53 , Mikolaj Golub wrote: >> >> On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: >> >> XL> Hi, Mikolaj, >> >> XL> On 07/04/12 00:00, Mikolaj Golub wrote:

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-05 Thread Mikolaj Golub
On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: XL> Hi, Mikolaj, XL> On 07/04/12 00:00, Mikolaj Golub wrote: >> Is this observed after destroying epair? There is an issue with >> epair: on destroy, when epair_clone_destroy() calls >> ether_ifdetach() for its second

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-04 Thread Mikolaj Golub
t find the interface and just returns. As a result V_ifnet list is left with dead reference. http://lists.freebsd.org/pipermail/freebsd-virtualization/2011-January/000628.html Here is an updated patch against CURRENT: http://people.freebsd.org/~trociny/if_epair.c.epair_clone_destroy.1.patch -- Mikola

Re: panic when epair is removed (VNET)

2012-06-17 Thread Mikolaj Golub
ore details: freebsd version/revision, scenario, backtrace, so I could try to reproduce. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to "freebsd-virtualization-unsubscr...@freebsd.org"

Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap

2012-06-16 Thread Mikolaj Golub
The following reply was made to PR kern/158686; it has been noted by GNATS. From: Mikolaj Golub To: "Daan Vreeken \[PA4DAN\]" Cc: bug-follo...@freebsd.org, Alexander V. Chernikov Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap Date: Sat, 16 Jun 2012 10:2

Re: kern/152047: [vimage] [panic] TUN\TAP under jail with vimage crashes system

2012-06-16 Thread Mikolaj Golub
The following reply was made to PR kern/152047; it has been noted by GNATS. From: Mikolaj Golub To: Anton Cc: bug-follo...@freebsd.org Subject: Re: kern/152047: [vimage] [panic] TUN\TAP under jail with vimage crashes system Date: Sat, 16 Jun 2012 09:54:39 +0300 Hi, Anton, I just have

Re: [patch] VirtualBox-4.0.14 + FreeBSD/CURRENT + VIMAGE: crash on vm shutdown

2012-04-01 Thread Mikolaj Golub
s: the first one is for VBoxNetFlt (the same I sent to the list but against 4.1.10) and the second one for VBoxNetAdp (a fix for the panic above). BF> Do you aggree that this patch is under MIT License so that I can push BF> it upstream? Sure for both patches. Thanks for taking it! -- Mi

Re: [patch] VirtualBox-4.0.14 + FreeBSD/CURRENT + VIMAGE: crash on vm shutdown

2012-03-20 Thread Mikolaj Golub
On Tue, 20 Mar 2012 09:24:46 +1100 Petro Rossini wrote: PR> On Tue, Mar 20, 2012 at 5:48 AM, Mikolaj Golub wrote: >> Hi, >> >> Here is a patch that fixes the issue I have been observing recently: running >> on VIMAGE enabled kernel VirtualBox causes the kernel cr

[patch] VirtualBox-4.0.14 + FreeBSD/CURRENT + VIMAGE: crash on vm shutdown

2012-03-19 Thread Mikolaj Golub
Xint0x80_syscall+0x21 -- Mikolaj Golub --- VirtualBox-4.0.14_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig 2012-03-18 00:21:42.0 +0200 +++ VirtualBox-4.0.14_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c 2012-03-18 00:22:18.0 +0200 @@ -651,13

Re: FIX: accessing module's virtualized global variables from another module

2011-07-25 Thread Mikolaj Golub
On Sun, 24 Jul 2011 18:11:14 +0300 Kostik Belousov wrote: KB> On Sun, Jul 24, 2011 at 11:02:21AM +0300, Mikolaj Golub wrote: >> Also, could someone explain what is kern/link_elf_obj.c for? The patch does >> not deal with this file, but I see the reloactions here simi

FIX: accessing module's virtualized global variables from another module

2011-07-24 Thread Mikolaj Golub
rn/link_elf_obj.c for? The patch does not deal with this file, but I see the reloactions here similar to those in link_elf.c. So I might need to do similar modifiactions in link_elf_obj.c too, but I don't know where this code is used (it looks like it is not executed on my box, so I don&

Re: vnet: acessing module's virtualized global variables from another module

2011-05-09 Thread Mikolaj Golub
On Mon, 9 May 2011 16:21:15 +0200 Marko Zec wrote: MZ> On Monday 09 May 2011 14:48:25 Mikolaj Golub wrote: >> Hi, >> >> Trying ipfw_nat under VIMAGE kernel I got this panic on the module load: MZ> Hi, MZ> I think the problem here is that curvnet context is not

vnet: acessing module's virtualized global variables from another module

2011-05-09 Thread Mikolaj Golub
t I suppose the problem is not a new and there might be better approach already invented to deal with this? -- Mikolaj Golub Index: sys/netinet/ipfw/ip_fw_private.h === --- sys/netinet/ipfw/ip_fw_private.h (revision 221673) +++

Re: VirtualBox + VIMAGE

2011-03-17 Thread Mikolaj Golub
rts/revision/?rev=1264 BF> It got also reviewed from upstream and it looks fine so far. Will BF> hopefully be committed soon. Thank you! -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailma

Re: HEADS UP: tenetative plan to merge VIMAGE parts

2011-02-15 Thread Mikolaj Golub
Running my notebook (stable/8) with these patches. BAZ> I'd suggest we'll check an updated smbfs patch after that and get it BAZ> in (if still needed). Previously I patched smb_trantcp.c in order to prevent crashes when mounting smbfs. Now it looks likes I don't need it any

Re: VirtualBox + VIMAGE

2011-01-27 Thread Mikolaj Golub
anks! BF> It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere BF> check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for BF> VIMAGE in the #if defined line or is this already done somewhere deep in BF> the included headers? All magic is in ne

Re: VirtualBox + VIMAGE

2011-01-26 Thread Mikolaj Golub
On Wed, 26 Jan 2011 14:18:03 + (UTC) Bjoern A. Zeeb wrote: BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote: >> >> On Wed, 26 Jan 2011 09:15:46 + (UTC) Bjoern A. Zeeb wrote: >> >> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version &

Re: VirtualBox + VIMAGE

2011-01-26 Thread Mikolaj Golub
ernel" off .endif and if it is on set VIMAGE make environment variable. Or may be you have a better solution. BF> For Mikolaj Golub to get this patch upstream we need that you either BF> agree that his patch is under the MIT License or sign a Sun Contributors BF> Agreement. Then we

Re: VirtualBox + VIMAGE

2011-01-26 Thread Mikolaj Golub
BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500 BAZ> #endif BAZ> might be a save bet. Thanks. Something like in the patch below? Note, I have not run this version yet. Will test it tonight or tomorrow. -- Mikolaj Golub diff -rpu VirtualBox-3.2.12_OSE.orig/sr

Re: VirtualBox + VIMAGE

2011-01-25 Thread Mikolaj Golub
On Sun, 23 Jan 2011 23:44:41 -0800 Julian Elischer wrote: JE> On 1/23/11 6:33 AM, Mikolaj Golub wrote: >> As a quick fix I added in VBoxNetFlt-freebsd.c in all "problem" functions >> CURVNET_SET_QUIET(vnet0) macro, which sets td->td_vnet to default vnet (see

VirtualBox + VIMAGE

2011-01-23 Thread Mikolaj Golub
emulators/virtualbox-ose-kmod make patch cd work patch -p0 < /path/to/VirtualBox-3.2.12.VIMAGE.patch cd .. VIMAGE=1 make -- Mikolaj Golub diff -rpu VirtualBox-3.2.12_OSE.orig/src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile VirtualBox-3.2.12_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile --

epair: panic after destroying

2011-01-20 Thread Mikolaj Golub
ached? Also it looks wrong that if_detach_internal() silently returned in that case. I think it should panic or at least warns (like in the third patch). -- Mikolaj Golub Index: sys/net/if.c === --- sys/net/if.c (revision 217617) +

Re: smbfs on VIMAGE kernel

2011-01-11 Thread Mikolaj Golub
On Tue, 11 Jan 2011 16:20:11 -0800 Julian Elischer wrote: JE> On 1/11/11 11:42 AM, Mikolaj Golub wrote: >> Hi, >> >> With the attached patch I can mount and use samba fs on current built with >> VIMAGE option. >> JE> but what does that actually MEAN

smbfs on VIMAGE kernel

2011-01-11 Thread Mikolaj Golub
Hi, With the attached patch I can mount and use samba fs on current built with VIMAGE option. -- Mikolaj Golub Index: sys/netsmb/smb_trantcp.c === --- sys/netsmb/smb_trantcp.c (revision 217275) +++ sys/netsmb/smb_trantcp.c