Re: RFC: ipfw nat VIMAGE improvements

2013-08-25 Thread Mikolaj Golub
On Thu, Aug 15, 2013 at 12:25:34AM +0200, Marko Zec wrote: Anyhow, this looks fine to me... Thanks, committed as r254776. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd

Re: RFC: carp(4): improved VIMAGE support

2013-08-14 Thread Mikolaj Golub
On Tue, Aug 13, 2013 at 11:26:31AM +0400, Gleb Smirnoff wrote: On Mon, Aug 12, 2013 at 10:45:17PM +0300, Mikolaj Golub wrote: M On Mon, Aug 12, 2013 at 02:16:15PM +0400, Gleb Smirnoff wrote: M On Sun, Aug 11, 2013 at 11:08:35PM +0300, Mikolaj Golub wrote: M M Hi, M M M M I would like

Re: RFC: carp(4): improved VIMAGE support

2013-08-12 Thread Mikolaj Golub
On Mon, Aug 12, 2013 at 02:16:15PM +0400, Gleb Smirnoff wrote: On Sun, Aug 11, 2013 at 11:08:35PM +0300, Mikolaj Golub wrote: M Hi, M M I would like to virtualize carp(4) variables to have per vnet control. M M Any comments, objections? No objections! Andrey pointed out (on irc

RFC: carp(4): improved VIMAGE support

2013-08-11 Thread Mikolaj Golub
Hi, I would like to virtualize carp(4) variables to have per vnet control. Any comments, objections? -- Mikolaj Golub commit 646e0b161ae7782259335cec652e178652ed7af3 Author: Mikolaj Golub troc...@freebsd.org Date: Tue Aug 6 23:47:31 2013 +0300 Virtualize carp(4) variables for per vnet

Re: lagg panic

2013-06-07 Thread Mikolaj Golub
On Mon, Feb 11, 2013 at 02:36:17PM +0200, Nikos Vassiliadis wrote: Hi, I just noticed this is not committed. Could somebody commit it? http://lists.freebsd.org/pipermail/freebsd-net/2011-November/030526.html Committed (r251490). Thanks. -- Mikolaj Golub

Re: pf + vimage patch

2013-06-06 Thread Mikolaj Golub
be understanding how to fix it for vimage kernel. Your approach with keeping only one purge thread might make it simpler. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-05 Thread Mikolaj Golub
On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: XL Hi, Mikolaj, XL On 07/04/12 00:00, Mikolaj Golub wrote: Is this observed after destroying epair? There is an issue with epair: on destroy, when epair_clone_destroy() calls ether_ifdetach() for its second half it does not switch to its

Re: GPF when doing jail -r, possibly an use-after-free

2012-07-05 Thread Mikolaj Golub
On Thu, 5 Jul 2012 20:21:53 + Bjoern A. Zeeb wrote: BAZ On 5. Jul 2012, at 19:53 , Mikolaj Golub wrote: On Thu, 05 Jul 2012 12:18:20 -0700 Xin Li wrote: XL Hi, Mikolaj, XL On 07/04/12 00:00, Mikolaj Golub wrote: Is this observed after destroying epair? There is an issue

Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap

2012-06-16 Thread Mikolaj Golub
The following reply was made to PR kern/158686; it has been noted by GNATS. From: Mikolaj Golub troc...@freebsd.org To: Daan Vreeken \[PA4DAN\] pa4...@bliksem.vehosting.nl Cc: bug-follo...@freebsd.org, Alexander V. Chernikov melif...@freebsd.org Subject: Re: kern/158686: [vimage] [tap] [patch

[patch] VirtualBox-4.0.14 + FreeBSD/CURRENT + VIMAGE: crash on vm shutdown

2012-03-19 Thread Mikolaj Golub
() at Xint0x80_syscall+0x21 -- Mikolaj Golub --- VirtualBox-4.0.14_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig 2012-03-18 00:21:42.0 +0200 +++ VirtualBox-4.0.14_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c 2012-03-18 00:22:18.0 +0200 @@ -651,13

FIX: accessing module's virtualized global variables from another module

2011-07-24 Thread Mikolaj Golub
modifiactions in link_elf_obj.c too, but I don't know where this code is used (it looks like it is not executed on my box, so I don't know how to test it). -- Mikolaj Golub Index: sys/net/vnet.c === --- sys/net/vnet.c (revision 224286

Re: vnet: acessing module's virtualized global variables from another module

2011-05-09 Thread Mikolaj Golub
On Mon, 9 May 2011 16:21:15 +0200 Marko Zec wrote: MZ On Monday 09 May 2011 14:48:25 Mikolaj Golub wrote: Hi, Trying ipfw_nat under VIMAGE kernel I got this panic on the module load: MZ Hi, MZ I think the problem here is that curvnet context is not set properly on entry MZ

Re: HEADS UP: tenetative plan to merge VIMAGE parts

2011-02-15 Thread Mikolaj Golub
in (if still needed). Previously I patched smb_trantcp.c in order to prevent crashes when mounting smbfs. Now it looks likes I don't need it any more -- smb works without that patch. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http

Re: VirtualBox + VIMAGE

2011-01-27 Thread Mikolaj Golub
It is currently unclear to me why you add VIMAGE to CFLAGS but nowhere BF check for VIMAGE in VBoxNetFlt-freebsd.c. Shouldn't we add a check for BF VIMAGE in the #if defined line or is this already done somewhere deep in BF the included headers? All magic is in net/vnet.h :-) -- Mikolaj Golub

Re: VirtualBox + VIMAGE

2011-01-26 Thread Mikolaj Golub
and if it is on set VIMAGE make environment variable. Or may be you have a better solution. BF For Mikolaj Golub to get this patch upstream we need that you either BF agree that his patch is under the MIT License or sign a Sun Contributors BF Agreement. Then we can submit that patch upstream or you can do it BF

Re: VirtualBox + VIMAGE

2011-01-25 Thread Mikolaj Golub
On Sun, 23 Jan 2011 23:44:41 -0800 Julian Elischer wrote: JE On 1/23/11 6:33 AM, Mikolaj Golub wrote: As a quick fix I added in VBoxNetFlt-freebsd.c in all problem functions CURVNET_SET_QUIET(vnet0) macro, which sets td-td_vnet to default vnet (see the attached patch). This has fixed

VirtualBox + VIMAGE

2011-01-23 Thread Mikolaj Golub
patch cd work patch -p0 /path/to/VirtualBox-3.2.12.VIMAGE.patch cd .. VIMAGE=1 make -- Mikolaj Golub diff -rpu VirtualBox-3.2.12_OSE.orig/src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile VirtualBox-3.2.12_OSE/src/VBox/HostDrivers/VBoxNetFlt/freebsd/Makefile --- VirtualBox-3.2.12_OSE.orig/src/VBox

epair: panic after destroying

2011-01-20 Thread Mikolaj Golub
panic or at least warns (like in the third patch). -- Mikolaj Golub Index: sys/net/if.c === --- sys/net/if.c (revision 217617) +++ sys/net/if.c (working copy) @@ -828,11 +828,8 @@ if_detach_internal(struct ifnet *ifp, int vmove) #endif

smbfs on VIMAGE kernel

2011-01-11 Thread Mikolaj Golub
Hi, With the attached patch I can mount and use samba fs on current built with VIMAGE option. -- Mikolaj Golub Index: sys/netsmb/smb_trantcp.c === --- sys/netsmb/smb_trantcp.c (revision 217275) +++ sys/netsmb/smb_trantcp.c

Re: smbfs on VIMAGE kernel

2011-01-11 Thread Mikolaj Golub
On Tue, 11 Jan 2011 16:20:11 -0800 Julian Elischer wrote: JE On 1/11/11 11:42 AM, Mikolaj Golub wrote: Hi, With the attached patch I can mount and use samba fs on current built with VIMAGE option. JE but what does that actually MEAN? Without the patch when you try to mount samba fs