sepherosa_gmail.com accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D9904
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: decui_microsoft.com, imp, jhb, will, kib, delphij, emaste, marcel,
sepherosa_gmail.com abandoned this revision.
REVISION DETAIL
https://reviews.freebsd.org/D5291
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, adrian, delphij, decui_microsoft.com,
honzhan_microsoft.com, howard0su_gmail.com, royger
sepherosa_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D5316
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com,
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5316#113452, @howard0su_gmail.com wrote:
> I worried so many options just brings headache to the end user without the
clearly instruction on how to tune it. Please introduce new option when it is
really needed. Maybe
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION DETAIL
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
Tested on
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION DETAIL
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5291#112900, @royger wrote:
> I guess this supersedes https://reviews.freebsd.org/D5254? I would expand
the commit message so that it's explicitly stated why the hypervisor vector
should have a lower priority.
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added a subscriber: freebsd-virtualization-list.
REVISION SUMMARY
Better and simple solution is to do
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
So one
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
This paves
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
Performance
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
This paves
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
This also
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5276#112396, @howard0su_gmail.com wrote:
> This change is a noop since two functions are identical.
Yeah, that's the purpose of this change!
REVISION DETAIL
https://reviews.freebsd.org/D5276
EMAIL PREFERENCES
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
And use
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
It is off
sepherosa_gmail.com updated this revision to Diff 13282.
sepherosa_gmail.com added a comment.
Expand length limitation to 32 bits. Suggested by hselasky.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D5185?vs=13028=13282
REVISION DETAIL
https://reviews.freebsd.org/D5185
sepherosa_gmail.com added a comment.
In https://reviews.freebsd.org/D5185#110952, @hselasky wrote:
> The size of lro_ctrl already changed when the statistics was made 64-bit.
Just remember to bump the FreeBSD_version. Might not be possible to MFC.
OK, let's wait for others inputs
sepherosa_gmail.com added inline comments.
INLINE COMMENTS
sys/netinet/tcp_lro.h:94 My intention here is too keep the size of lro_ctrl
unchanged on amd64 (I think there is an implicit 4 bytes padding after
lro_mbuf_max :). But I am fine to change them into unsigned int.
Does anyone know
sepherosa_gmail.com added a comment.
I will adjust the patch accordingly.
INLINE COMMENTS
sys/netinet/tcp_lro.c:655 Sure :)
sys/netinet/tcp_lro.c:684 Sounds fine to me. I did the byte limit before
(https://reviews.freebsd.org/D4825). But it turns out the ACKs need seperate
limit
sepherosa_gmail.com added inline comments.
INLINE COMMENTS
sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:455 OK, I will split it out.
REVISION DETAIL
https://reviews.freebsd.org/D5185
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com,
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, gallatin,
hselasky, np.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
Herald
sepherosa_gmail.com updated the summary for this revision.
REVISION DETAIL
https://reviews.freebsd.org/D5185
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com,
sepherosa_gmail.com created this revision.
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger,
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added subscribers: freebsd-net-list,
freebsd-virtualization-list.
REVISION SUMMARY
It is off
25 matches
Mail list logo