[Differential] [Updated] D1944: PF and VIMAGE fixes

2015-07-19 Thread zec (Marko Zec)
zec added a comment. In https://reviews.freebsd.org/D1944#62124, @robak wrote: > I managed to crash freshly fetched and built 10-S today, with > GENERIC+VIMAGE+RACCT while stopping a jail, attaching console screenshots. > > F183647: Screen Shot 2015-07-19 at 17.48.26.png >

[Differential] [Commented On] D1309: VIMAGE PF fixes #1

2014-12-14 Thread zec (Marko Zec)
zec added inline comments. INLINE COMMENTS sys/netpfil/pf/pf_ioctl.c:3804 Perhaps SI_ORDER_MIDDLE could work here instead of (SI_ORDER_ANY - 255)? REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwa

[Differential] [Changed Subscribers] D1315: VIMAGE PF fixes #4

2014-12-14 Thread zec (Marko Zec)
zec added a subscriber: zec. INLINE COMMENTS sys/netpfil/pf/pf.c:1384 *v could be marked as __unused sys/netpfil/pf/pf_ioctl.c:282 Passing curvnet as an argument here is redundant now. REVISION DETAIL https://reviews.freebsd.org/D1315 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs,