[Differential] D13995: NVMe controller emulator for bhyve.

grehan abandoned this revision. grehan added a comment. Closing this revision - moving to https://reviews.freebsd.org/D14022 REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: grehan, trasz, imp,

[Differential] D13995: NVMe controller emulator for bhyve.

grehan commandeered this revision. grehan edited reviewers, added: sux2mfgj_gmail.com; removed: grehan. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: grehan, trasz, imp, sux2mfgj_gmail.com Cc: chuck,

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. Yep, that's correct. The code in the new review is based on this code so it's really a continuation of the effort. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] D13995: NVMe controller emulator for bhyve.

chuck added a comment. @grehan OK. So is the thought that this review be closed and efforts should focus on https://reviews.freebsd.org/D14022? REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] D13995: NVMe controller emulator for bhyve.

grehan requested changes to this revision. grehan added a comment. This revision now requires changes to proceed. Chuck - the review for this is now in https://reviews.freebsd.org/D14022, where I believe your comments have already been addressed. REVISION DETAIL

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. The updated version of this code is at https://reviews.freebsd.org/D14022 I've moved the reviewer/subscriber list over as well. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. Leon Dang has also been working on NVMe emulation, and his version works with Linux, Windows and UEFI boot. I'll post that code for review since it is a bit more recent and tested. In the meantime, that version can be seen at www.freebsd.org/~grehan/pci_nvme.c

[Differential] D13995: NVMe controller emulator for bhyve.

rgrimes added a comment. I did a very quick one time scan down the code just to see what was here, these are my comments about it. None of the functions have block start comments stating what that function does. INLINE COMMENTS > pci_nvme.c:1 > +#include > +#include File is missing a

[Differential] D13995: NVMe controller emulator for bhyve.

cem added a reviewer: imp. cem added a comment. Awesome! I can't speak to the NVMe emulation itself (I know almost nothing about the protocol and nothing about Bhyve HW emu interfaces). Maybe Warner can. INLINE COMMENTS > nvme.h:127 > enum shn_value { > +NVME_SHN_NOEFCT =

[Differential] D13995: NVMe controller emulator for bhyve.

sux2mfgj_gmail.com edited the summary of this revision. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sux2mfgj_gmail.com, grehan, trasz Cc: freebsd-virtualization-list, chuck

[Differential] D13995: NVMe controller emulator for bhyve.

sux2mfgj_gmail.com edited the summary of this revision. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sux2mfgj_gmail.com, grehan, trasz Cc: freebsd-virtualization-list, chuck

[Differential] D13995: NVMe controller emulator for bhyve.

sux2mfgj_gmail.com created this revision. sux2mfgj_gmail.com added reviewers: grehan, trasz. sux2mfgj_gmail.com added a project: bhyve. REVISION SUMMARY This emulator is implemented according to NVMe specification 1.0, and didn't covered all. However, I tested using `newfs` and `nvmecontrol