[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

2017-05-11 Thread jan.dakinevich_gmail.com (Jan Dakinevich)
jan.dakinevich_gmail.com added inline comments. INLINE COMMENTS > anish wrote in ept.c:58-59 > This is cryptic, better to have separate macros for it > #define INVVPID_SINGLE_CTX_SUP(cap) ((cap) & (1UL << 41)) > #define INVVPID_ALL_CTX_SUP(cap) ((cap) & (1UL << 42)) It was

[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

2017-05-01 Thread grehan (Peter Grehan)
grehan added inline comments. INLINE COMMENTS > ept.c:68 > + (((cap) & INVEPT_REQUIRED_TYPES_MASK) == INVEPT_REQUIRED_TYPES_MASK) > > #define EPT_PWLEVELS4 /* page walk levels */ Might be worth splitting these out into individual tests, since I have a

[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

2017-04-28 Thread anish (Anish Gupta)
anish added inline comments. INLINE COMMENTS > ept.c:58-59 > +#define INVVPID_REQUIRED_TYPES_MASK \ > + ((1UL << (INVVPID_TYPE_SINGLE_CONTEXT + 40)) | \ > + (1UL << (INVVPID_TYPE_ALL_CONTEXTS + 40))) > +#define INVVPID_REQUIRED_TYPES_SUPPORTED(cap)

[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

2017-04-28 Thread jan.dakinevich_gmail.com (Jan Dakinevich)
jan.dakinevich_gmail.com created this revision. Herald added a subscriber: imp. REVISION SUMMARY Currently, during EPT initialization it is checked that invvpid instruction supports all possible invalidation types, however only two of them are used (single context and all contexts