[Differential] [Accepted] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

2016-02-05 Thread gallatin (Andrew Gallatin)
gallatin accepted this revision. gallatin added a comment. Thanks for addressing my concerns.. Does anybody else want to comment? REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com,

[Differential] [Accepted] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

2016-02-05 Thread adrian (Adrian Chadd)
adrian accepted this revision. adrian added a comment. Nice! Thanks for all this work! REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

2016-02-05 Thread hselasky (Hans Petter Selasky)
hselasky added inline comments. INLINE COMMENTS sys/netinet/tcp_lro.h:94 Might be worth set this limit to unsigned instead of unsigned short. Technically we can LRO more than 64KBytes worth of data! REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES

RE: Hyper-V networking: problem after upgrade to 10.2

2016-02-05 Thread Jac Backus
Hello Dexuan, I build a new kernel and the problem is gone. I tried to understand your description of the patch. What I find remarkable is, that there is apparently no fixed relation between the virtual nics defined in Hyper-V (with a fixed mac address) and the devices, hn0, hn1, etc in the

RE: Hyper-V networking: problem after upgrade to 10.2

2016-02-05 Thread Dexuan Cui
Hi Jac, Thanks for confirming the fixes! Please let me explain the issue a little more. The issue exists in the VMBus driver. Since the network driver depends on the VMBus driver, we have the issue. The issue is: the VMBus doesn't guarantee the serialization of registering multiple NICs, e.g.,

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

2016-02-05 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added inline comments. INLINE COMMENTS sys/netinet/tcp_lro.h:94 My intention here is too keep the size of lro_ctrl unchanged on amd64 (I think there is an implicit 4 bytes padding after lro_mbuf_max :). But I am fine to change them into unsigned int. Does anyone know