sux2mfgj_gmail.com created this revision.
sux2mfgj_gmail.com added reviewers: grehan, trasz.
sux2mfgj_gmail.com added a project: bhyve.
REVISION SUMMARY
This emulator is implemented according to NVMe specification 1.0, and didn't
covered all. However, I tested using `newfs` and `nvmecontrol per
sux2mfgj_gmail.com edited the summary of this revision.
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sux2mfgj_gmail.com, grehan, trasz
Cc: freebsd-virtualization-list, chuck
_
sux2mfgj_gmail.com edited the summary of this revision.
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sux2mfgj_gmail.com, grehan, trasz
Cc: freebsd-virtualization-list, chuck
_
cem added a reviewer: imp.
cem added a comment.
Awesome!
I can't speak to the NVMe emulation itself (I know almost nothing about the
protocol and nothing about Bhyve HW emu interfaces). Maybe Warner can.
INLINE COMMENTS
> nvme.h:127
> enum shn_value {
> +NVME_SHN_NOEFCT = 0x0,
rgrimes added a comment.
I did a very quick one time scan down the code just to see what was here,
these are my comments about it.
None of the functions have block start comments stating what that function
does.
INLINE COMMENTS
> pci_nvme.c:1
> +#include
> +#include
File is missing a c
grehan added a comment.
Leon Dang has also been working on NVMe emulation, and his version works with
Linux, Windows and UEFI boot. I'll post that code for review since it is a bit
more recent and tested. In the meantime, that version can be seen at
www.freebsd.org/~grehan/pci_nvme.c
(T
