[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Sure, I will take a look REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_ovi_yahoo.co

[Differential] [Commented On] D1944: PF and VIMAGE fixes

mmoll added a comment. Nikos, could you have a look into PR 205743? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. @bz: you've made some commits to VIMAGE code in past few days, how do they relate to this revision? Any chance you could review it and comment/commit on this? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Any news on that review? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_ovi_yahoo.com, farro

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Hi from me as well, just want to say that I am here too and I am willing to work on this even if i have to do it scratch;) Please review:) Nikos REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/setti

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Just to add an end-user update, this stuff keeps leaking, even in 10.2-p7, every single time a VIMAGE jail is being stopped. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius : if you have time can you review this? you have expressed interest in PF + VIMAGE fixes in the past. @bz : do you have time to review this? I understand you are going to be doing some VIMAGE work REVISION DETAIL https://reviews.freebsd.org/D1944 E

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @mmoll : It would be nice if @glebius could review this patch. He previously committed some patches I committed to FreeBSD which attempted to fix this problem, so he has an interest in this area. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES

[Differential] [Commented On] D1944: PF and VIMAGE fixes

mmoll added a subscriber: mmoll. mmoll added a comment. what's the status here? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmol

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius: Nikos updated the patch. Can you review it? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: farr

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Hi, could you write an email to me and freebsd-virtualization@freebsd.org with the necessary steps to re-produce the problem? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there anything else I can do to provide some useful information? I've attached these screenshots only because the machine becomes unresponsive when this happens (and drops active ssh connections). I am happy to execute any test/information gathering suite you may need.

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. I managed to crash freshly fetched and built 10-S today, with GENERIC+VIMAGE+RACCT while stopping a jail, attaching console screenshots. F183647: Screen Shot 2015-07-19 at 17.48.26.png F183649: Screen Shot 2015-07-19 at 18.33.39.png

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there any update on those fixes? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, kristof, gnn, glebius, rodrigc Cc: julian, robak, freebsd-virtual

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there any chance to get these changes committed in time for 10.2-RELEASE? It would be great if we could have working VNET/PF before 11.0-R comes out... REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/e

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47915, @glebius wrote: > Thanks a lot, Nikos. > > I've fixed the problem of sleeping in UMA on kldunload. It was out the scope > of the patch. I also committed the first part of the patch - mutexes > initialization. > > Nikos,

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I can confirm that: kldunload -f pf.ko does work to unload the module. That is good. I saw this warning message in dmesg: lock order reversal: (sleepable after non-sleepable) 1st 0x823b72e0 pf rulesets (pf rulesets) @ /opt2/branches/head/sys/modules/pf

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47231, @rodrigc wrote: > I tested this patch. > > # kldload pf > # kldunload pf > kldunload: can't unload file: Device busy > > > The fact that the pf module cannot be unloaded was one of the > reasons that @glebius used t

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I tested this patch. # kldload pf # kldunload pf kldunload: can't unload file: Device busy The fact that the pf module cannot be unloaded was one of the reasons that @glebius used to back out the entire changeset last time I committed your pf changes. Can you fix

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. In https://reviews.freebsd.org/D1944#46127, @julian wrote: > in case I didn't point you at this before... > > http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.tx

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. This guilde is definitely invaluable, I have seen it. It would be great if we could move it in the source tree. Regarding PF it can be further simplified. I think the logic right is OK but there are many *init* functions for sure and some of these functions can go

[Differential] [Commented On] D1944: PF and VIMAGE fixes

julian added a subscriber: julian. julian added a comment. in case I didn't point you at this before... http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.txt?ac=22 REVISION DETAIL https:

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Yes, I am trying to fix the issues. It needs more work. I will update when I have a new patch REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny

[Differential] [Commented On] D1944: PF and VIMAGE fixes

glebius added a comment. Recently Nikos has asked questions on kernel debugging. So, I guess, he is working. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, glebius, rodri

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a subscriber: robak. robak added a comment. Is there any update on these fixes? I've just happened to bump my 10.1-RELEASE into 10-STABLE and created few VIMAGE based jails. As soon as I stop any of them, and I can reproduce it every time, the host OS crashes. That makes the entire

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. >>! In D1944#11, @kristof wrote: > Don't we still need to do all of this somewhere? >>! In D1944#11, @kristof wrote: > Don't we still need to do all of this somewhere? INLINE COMMENTS sys/netpfil/pf/pf_ioctl.c:325 pf_unload is called before pf_vnet_unit, this

[Differential] [Commented On] D1944: PF and VIMAGE fixes

kristof added inline comments. INLINE COMMENTS sys/netpfil/pf/pf_ioctl.c:325 It's not clear to me why this is done here, rather than in pf_unload(). The initialisation is done in pf_load() after all. sys/netpfil/pf/pf_ioctl.c:3725 Don't we still need to do all of this somewhere? REVISION DE

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. >>! In D1944#8, @glebius wrote: > Nikos, > > acking that I see the patches. Right now I'm waiting for pf to stablize after > recent patches to fragment handling. Kristof is working on the known problem. > Meanwhile you can finish your patch moving from "almost there