Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
The following reply was made to PR kern/158686; it has been noted by GNATS. From: Alexander V. Chernikov melif...@freebsd.org To: Daan Vreeken d...@vitsch.nl Cc: Mikolaj Golub troc...@freebsd.org, bug-follo...@freebsd.org Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap Date: Tue, 19 Jun 2012 13:52:59 +0400 I don't have a working test setup or use case at this moment where we use multiple FIBs in combination with tap(4), but if I remember correctly, the kernel would instantly panic upon receiving the first packet through the interface without the call to M_SETFIB(). It is quite strange since M_SETFIB does nothing more than setting 4 bits in mbuf flags which are zero by default (fib 0). If I run in to this again I'll submit a separate PR for this problem. Can you please drop e-mail to me if this happens? ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to freebsd-virtualization-unsubscr...@freebsd.org
Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
Synopsis: [vimage] [tap] [patch] Add VIMAGE support to if_tap State-Changed-From-To: open-closed State-Changed-By: trociny State-Changed-When: Sat Jun 16 07:26:59 UTC 2012 State-Changed-Why: Fixed. http://www.freebsd.org/cgi/query-pr.cgi?pr=158686 ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to freebsd-virtualization-unsubscr...@freebsd.org
Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap
The following reply was made to PR kern/158686; it has been noted by GNATS. From: Mikolaj Golub troc...@freebsd.org To: Daan Vreeken \[PA4DAN\] pa4...@bliksem.vehosting.nl Cc: bug-follo...@freebsd.org, Alexander V. Chernikov melif...@freebsd.org Subject: Re: kern/158686: [vimage] [tap] [patch] Add VIMAGE support to if_tap Date: Sat, 16 Jun 2012 10:25:26 +0300 Hi Daan, The patch is committed. Thank you! Note, I have not committed the FIB part of the patch though because I am not sure it was supposed to be done in this way. Your change looks reasonable for me, as it looks like without it mbufs of all incoming packets are not tagged on tap interface. On the other hand I don't see examples in kernel where tag is set before if_input() call (only before netisr_queue() or netisr_dispatch()). if_input() is actually ether_input(). May be it is supposed to just add this tag in ether_input()? I cc Alexander Chernikov, who is the author of the original patch that added mbuf tagging of incoming packets (r223741), and close this pr as the vimage part is fixed. -- Mikolaj Golub ___ freebsd-virtualization@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to freebsd-virtualization-unsubscr...@freebsd.org
