On 3 August 2013 04:23, Cedric GROSS c...@cgross.info wrote:
Can you please post an updated diff against what's in -HEAD now?
As requested here is full patch.
Thanks!
It should. 4965 part was not impacted. But Don't you said that full patch
break your 5100 ?
Yup, it is breaking it very
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
de Adrian Chadd
Envoyé : samedi 3 août 2013 20:20
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
On 3 August 2013 04:23, Cedric GROSS c...@cgross.info wrote:
Can you please post
Ok, why'd you change the debug print macro to check if the debug flags
match the check, rather than if the debug flags are set in the check?
ie
(f) (v)
versus
( (f) (v) == (v) )
?
I'd like to tidy up the debugging changes that are left in your source
file before we move onto the next bits.
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
de Adrian Chadd
Envoyé : samedi 3 août 2013 21:37
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Ok, why'd you change the debug print macro to check if the debug flags
match
On 3 August 2013 12:43, Cedric GROSS c...@cgross.info wrote:
Ok, why'd you change the debug print macro to check if the debug flags
match the check, rather than if the debug flags are set in the check?
ie
(f) (v)
versus
( (f) (v) == (v) )
?
It's for reducing tracing verbosity and
-Message d'origine-
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
de Adrian Chadd
Envoyé : samedi 3 août 2013 21:50
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
On 3 August 2013 12:43, Cedric GROSS c...@cgross.info
Nah, let's take it easier for now.
Just leave the trace flags where they are in your diff, remove the
flags check so the debug mask works the way it is, and submit a diff
with _just_ the remaining debug flags line changes.
That way we know what the required changes are, it will only bug
people
-Message d'origine-
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
de Adrian Chadd
Envoyé : jeudi 1 août 2013 23:49
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Committed!
I'm about to commit the config options
...@gmail.com] De la part
de Adrian Chadd
Envoyé : mercredi 31 juillet 2013 17:08
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Hi,
There's some more whitespace things to fix in your diff.
-
-bus_dmamap_sync(sc-rxq.data_dmat, data-map
Hi,
There's some more whitespace things to fix in your diff.
-
-bus_dmamap_sync(sc-rxq.data_dmat, data-map,
-BUS_DMASYNC_POSTREAD);
-DPRINTF(sc, IWN_DEBUG_ANY,
+...DPRINTF(sc, IWN_DEBUG_ANY,
-Message d'origine-
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
de Adrian Chadd
Envoyé : mercredi 31 juillet 2013 17:08
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Hi,
There's some more whitespace things to fix
: freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Hi,
There's some more whitespace things to fix in your diff.
-
-bus_dmamap_sync(sc-rxq.data_dmat, data-map,
-BUS_DMASYNC_POSTREAD);
-DPRINTF(sc, IWN_DEBUG_ANY
-Message d'origine-
De : owner-freebsd-wirel...@freebsd.org [mailto:owner-freebsd-
wirel...@freebsd.org] De la part de Adrian Chadd
Envoyé : dimanche 28 juillet 2013 21:25
À : Cedric GROSS
Cc : freebsd-wireless@freebsd.org
Objet : Re: [IWN] Reviw split 2
Hi!
Feedback time
Hi!
Feedback time!
- DPRINTF(sc, IWN_DEBUG_TRACE, -%s done\n, __func__);
+ DPRINTF(sc, IWN_DEBUG_TRACE, -%s: end\n,__func__);
+
.. all that did was delete a space and add a new line. Just add the
space back in there, delete the new line; then that part of the diff
will disappear.
-
14 matches
Mail list logo
