[Bug 210799] if_bwi broken after upgrade from 9 to 10

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

Andriy Voskoboinyk  changed:

   What|Removed |Added

   See Also||https://bugs.freebsd.org/bu
   ||gzilla/show_bug.cgi?id=2142
   ||35

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken after upgrade from 9 to 10

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

Mark Linimon  changed:

   What|Removed |Added

Summary|if_bwi broken   |if_bwi broken after upgrade
   ||from 9 to 10
   Keywords||patch, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

Andriy Voskoboinyk  changed:

   What|Removed |Added

 CC||a...@freebsd.org

--- Comment #5 from Andriy Voskoboinyk  ---
Hi!

Try to apply fix from r283636 (there was similar issue with ndis(4)).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

--- Comment #4 from josla...@student.liu.se ---
65536 is better than the current (broken) state.

I think we should ask mav since he seems to have a strong opinion on define
names ;).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

--- Comment #3 from Adrian Chadd  ---
Yeah, but those defines are to do with physical IO for disks, not for various
network cards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

Adrian Chadd  changed:

   What|Removed |Added

 CC||adr...@freebsd.org

--- Comment #1 from Adrian Chadd  ---
* Can you try bwn on -HEAD and see if it works? I fixed a whole bunch of issues
and I'd like to move things ot use it.

* Is this okay:

Index: sys/dev/bwi/if_bwi.c
===
--- sys/dev/bwi/if_bwi.c(revision 302306)
+++ sys/dev/bwi/if_bwi.c(working copy)
@@ -1899,7 +1899,7 @@
   lowaddr, /* lowaddr */
   BUS_SPACE_MAXADDR,   /* highaddr */
   NULL, NULL,  /* filter, filterarg */
-  BUS_SPACE_MAXSIZE,   /* maxsize */
+  65536,   /* maxsize */
   BUS_SPACE_UNRESTRICTED,  /* nsegments */
   BUS_SPACE_MAXSIZE_32BIT, /* maxsegsize */
   0,   /* flags */

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

[Bug 210799] if_bwi broken

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210799

Bug ID: 210799
   Summary: if_bwi broken
   Product: Base System
   Version: 10.3-RELEASE
  Hardware: ppc
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: wireless
  Assignee: freebsd-wireless@FreeBSD.org
  Reporter: josla...@student.liu.se

After I upgraded from FreeBSD 9.0 to 10.3-RELEASE on my Mac Mini G4, I found
that "kldload if_bwi" would make the system unstable, and if I included it to
be loaded in loader.conf, I could not even boot. This used to work just fine.

Digging through the commits the bwi folder of the git clone of freebsd, I found
the issue:

commit ad311f67aaa6771c007f5046d032924146784a23
Author: mav 
Date:   Tue Apr 21 11:27:50 2015 +


MFC r280347: Remove MAXBSIZE use from drivers where it has nothing to do.

In some cases limits are just not needed, in others -- DFLTPHYS is the
right constant to use instead.

diff --git a/sys/dev/bwi/if_bwi.c b/sys/dev/bwi/if_bwi.c
index 911e49e..6ce433c1 100644
--- a/sys/dev/bwi/if_bwi.c
+++ b/sys/dev/bwi/if_bwi.c
@@ -1915,7 +1915,7 @@ bwi_dma_alloc(struct bwi_softc *sc)
   lowaddr, /* lowaddr */
   BUS_SPACE_MAXADDR,   /* highaddr */
   NULL, NULL,  /* filter, filterarg */
-  MAXBSIZE,/* maxsize */
+  BUS_SPACE_MAXSIZE,   /* maxsize */
   BUS_SPACE_UNRESTRICTED,  /* nsegments */
   BUS_SPACE_MAXSIZE_32BIT, /* maxsegsize */
   BUS_DMA_ALLOCNOW,/* flags */



Reverting this commit made the system stable, if_bwi started working, and I
could boot again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"