Re: Using net80211/IEEE80211_C_BITS macro
Appreciate it!
From: Adrian Chadd <adr...@freebsd.org>
To: Fehmi Noyan ISI <fnoyan...@yahoo.com>
Cc: Freebsd Wireless <freebsd-wireless@freebsd.org>
Sent: Monday, November 21, 2016 7:12 AM
Subject: Re: Using net80211/IEEE80211_C_BITS macro
I'll try to find someone to back port the wifi bits to stable/11 before they
get too problematic.
A
On Nov 20, 2016 12:12 AM, "Fehmi Noyan ISI" <fnoyan...@yahoo.com> wrote:
Thanks Adrian!
>
>Checked out revision 308871 and compiled the system from source. Had no issues
>during the built process.
>
>Also, verified the changes in the source tree
>
>
>Script started on Sun Nov 20 20:59:17 2016
>root@test:~ # grep IEEE80211_C_BITS /usr/src/sbin/ifconfig/*
>/usr/src/sbin/ifconfig/ ifieee80211.c: printb("drivercaps",
>dc->dc_drivercaps, IEEE80211_C_BITS);
>root@test:~ # grep IEEE80211_C_BITS /usr/src/sys/net80211/*
>/usr/src/sys/net80211/_ ieee80211.h:#define IEEE80211_C_BITS \
>/usr/src/sys/net80211/ ieee80211_ddb.c: db_printf("\tcaps=%b\n",
>vap->iv_caps, IEEE80211_C_BITS);
>/usr/src/sys/net80211/ ieee80211_ddb.c: db_printf("\tcaps=%b\n", ic->ic_caps,
>IEEE80211_C_BITS);
>root@test:~ # exit
>exit
>
>
>I used a VM (my only laptop has -RELEASE on it :{ , tried some bhyve trick
>like iwn passthru but did not succeed), hence could not specifically test
>"ifconfig wlan0 list caps" but since compilation went smooth, I would assume
>it should be OK. After all, changes do not constitute any new features or
>functions.
>
>Anything on the time frame till we could see this change on -RELEASE branch?
>
>Thanks
>
>
>- Original Message -
>From: Adrian Chadd <adrian.ch...@gmail.com>
>To: Fehmi Noyan ISI <fnoyan...@yahoo.com>
>Cc: Freebsd Wireless <freebsd-wireless@freebsd.org>
>Sent: Saturday, November 19, 2016 10:12 AM
>Subject: Re: Using net80211/IEEE80211_C_BITS macro
>
>Hi!
>
>Fixed in the latest -head. Two commits - one for net80211, one for ifconfig!
>
>
>
>-a
>
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
I'll try to find someone to back port the wifi bits to stable/11 before
they get too problematic.
A
On Nov 20, 2016 12:12 AM, "Fehmi Noyan ISI" <fnoyan...@yahoo.com> wrote:
> Thanks Adrian!
>
> Checked out revision 308871 and compiled the system from source. Had no
> issues during the built process.
>
> Also, verified the changes in the source tree
>
>
> Script started on Sun Nov 20 20:59:17 2016
> root@test:~ # grep IEEE80211_C_BITS /usr/src/sbin/ifconfig/*
> /usr/src/sbin/ifconfig/ifieee80211.c: printb("drivercaps",
> dc->dc_drivercaps, IEEE80211_C_BITS);
> root@test:~ # grep IEEE80211_C_BITS /usr/src/sys/net80211/*
> /usr/src/sys/net80211/_ieee80211.h:#define IEEE80211_C_BITS \
> /usr/src/sys/net80211/ieee80211_ddb.c: db_printf("\tcaps=%b\n",
> vap->iv_caps, IEEE80211_C_BITS);
> /usr/src/sys/net80211/ieee80211_ddb.c: db_printf("\tcaps=%b\n",
> ic->ic_caps, IEEE80211_C_BITS);
> root@test:~ # exit
> exit
>
>
> I used a VM (my only laptop has -RELEASE on it :{ , tried some bhyve trick
> like iwn passthru but did not succeed), hence could not specifically test
> "ifconfig wlan0 list caps" but since compilation went smooth, I would
> assume it should be OK. After all, changes do not constitute any new
> features or functions.
>
> Anything on the time frame till we could see this change on -RELEASE
> branch?
>
> Thanks
>
>
> - Original Message -
> From: Adrian Chadd <adrian.ch...@gmail.com>
> To: Fehmi Noyan ISI <fnoyan...@yahoo.com>
> Cc: Freebsd Wireless <freebsd-wireless@freebsd.org>
> Sent: Saturday, November 19, 2016 10:12 AM
> Subject: Re: Using net80211/IEEE80211_C_BITS macro
>
> Hi!
>
> Fixed in the latest -head. Two commits - one for net80211, one for
> ifconfig!
>
>
>
> -a
>
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
Thanks Adrian!
Checked out revision 308871 and compiled the system from source. Had no issues
during the built process.
Also, verified the changes in the source tree
Script started on Sun Nov 20 20:59:17 2016
root@test:~ # grep IEEE80211_C_BITS /usr/src/sbin/ifconfig/*
/usr/src/sbin/ifconfig/ifieee80211.c: printb("drivercaps", dc->dc_drivercaps,
IEEE80211_C_BITS);
root@test:~ # grep IEEE80211_C_BITS /usr/src/sys/net80211/*
/usr/src/sys/net80211/_ieee80211.h:#define IEEE80211_C_BITS \
/usr/src/sys/net80211/ieee80211_ddb.c: db_printf("\tcaps=%b\n", vap->iv_caps,
IEEE80211_C_BITS);
/usr/src/sys/net80211/ieee80211_ddb.c: db_printf("\tcaps=%b\n", ic->ic_caps,
IEEE80211_C_BITS);
root@test:~ # exit
exit
I used a VM (my only laptop has -RELEASE on it :{ , tried some bhyve trick like
iwn passthru but did not succeed), hence could not specifically test "ifconfig
wlan0 list caps" but since compilation went smooth, I would assume it should be
OK. After all, changes do not constitute any new features or functions.
Anything on the time frame till we could see this change on -RELEASE branch?
Thanks
- Original Message -
From: Adrian Chadd <adrian.ch...@gmail.com>
To: Fehmi Noyan ISI <fnoyan...@yahoo.com>
Cc: Freebsd Wireless <freebsd-wireless@freebsd.org>
Sent: Saturday, November 19, 2016 10:12 AM
Subject: Re: Using net80211/IEEE80211_C_BITS macro
Hi!
Fixed in the latest -head. Two commits - one for net80211, one for ifconfig!
-a
___
freebsd-wireless@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
Hi! Fixed in the latest -head. Two commits - one for net80211, one for ifconfig! -a ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
Sounds reasonable, thanks! if you make the change and give the revision number, I will give it a go to see if the code compiles (can do it in a VM, which wont have wlan interface but I'd assume it is OK if the world can be built without any issues) the ddb(4) support included in net80211 (implemented in ieee80211_ddb.c) also relies on data structures found in ieee80211_var.h, including IEEE80211_C_BITS(since this file includes lots of driver cap bits). I am not quite sure why I got so many compiler errors (in fact clang gave up listing them after having a few dozen errors) by just #includ'ing ieee80211_var.h. - Original Message - From: Adrian Chadd <adrian.ch...@gmail.com> To: Fehmi Noyan ISI <fnoyan...@yahoo.com> Cc: Freebsd Wireless <freebsd-wireless@freebsd.org> Sent: Friday, November 18, 2016 10:42 AM Subject: Re: Using net80211/IEEE80211_C_BITS macro Hiya, Ok. How about I move that into _ieee80211.h with the rest of this thing, and then remove the duplication from ifieee80211.c ? -adrian ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
Hiya, Ok. How about I move that into _ieee80211.h with the rest of this thing, and then remove the duplication from ifieee80211.c ? -adrian ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Using net80211/IEEE80211_C_BITS macro
Well, including ieee80211_var.h and attempting to compile the code throws dozens of error messages. In addition, I wonder why IEEE80211_C_BITS is re-defined in ifieee80211.c. - Original Message - From: Adrian Chadd <adrian.ch...@gmail.com> To: Fehmi Noyan ISI <fnoyan...@yahoo.com> Cc: Freebsd Wireless <freebsd-wireless@freebsd.org> Sent: Thursday, November 17, 2016 7:11 PM Subject: Re: Using net80211/IEEE80211_C_BITS macro Hi! Uhm, we could totally break out more bits into separate header files if including ieee80211_var.h doesn't work for you. a On 16 November 2016 at 14:53, Fehmi Noyan ISI via freebsd-wireless <freebsd-wireless@freebsd.org> wrote: > Hiya, > > I am working on an API (hopefully will post something about it soon) that, > beyond other stuff, checks wlan driver capabilities (just like ifconfig(1) > does). However, the capabilities macro, which is IEEE80211_C_BITS, is defined > in sys/net80211/ieee80211_var.h and I am not sure whether #include'ing > ieee80211_var.h just for this macro is a good idea or not. > > I have noticed that IEEE80211_C_BITS is re-defined in > sbin/ifconfig/ifieee80211.c to be used by list_capabilities() function; does > this not require update of IEEE80211_C_BITS macro in multiple source files? > > What would be the best approach to use IEEE80211_C_BITS in my source file; > including ieee80211_var.h or re-defining the macro in the source file > (similar to ifconfig(1))? > > Thanks > Fehmi > ___ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org" ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
