Re: [iwn] Review split 3

2013-07-29 Thread Adrian Chadd
Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. * $FreeBSD$ should be after the copyright header, not before * Your new file is missing the standard single-include stuff.. ie #ifndef __IF_IWN_DEVID_H__

Re: [iwn] Review split 3

2013-07-29 Thread Warren Block
On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. There is whitespace at the end of some of the comment lines also. textproc/igor will find problems like that:

RE: [iwn] Review split 3

2013-07-29 Thread Cedric GROSS
De : Warren Block [mailto:wbl...@wonkity.com] Envoyé : lundi 29 juillet 2013 20:11 À : Adrian Chadd Cc : Cedric GROSS; freebsd-wireless@freebsd.org On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and