Re: [iwn] Review split 3
Committed ,thanks! -adrian On 29 July 2013 11:39, Cedric GROSS wrote: > > >> De : Warren Block [mailto:wbl...@wonkity.com] >> Envoyé : lundi 29 juillet 2013 20:11 >> À : Adrian Chadd >> Cc : Cedric GROSS; freebsd-wireless@freebsd.org >> >> On Mon, 29 Jul 2013, Adrian Chadd wrote: >> >> > Hi! >> > >> > Cool! ok, the style niggles. >> > >> > * Your #define IWN_blah needs a TAB between #define and the IWN_blah >> > value. Right now you have spaces. > > Ok, I tough you need spaces between #define and values... > > standard single-include stuff : Done > $FreeBSD$ : Moved > > Each file is different. Really hard to find something common. Man 9 style is > quite useful but enough precise for tab and space usage I think. > >> >> There is whitespace at the end of some of the comment lines also. >> >> textproc/igor will find problems like that: >> >>igor -R filename | less -RS > > Thanks for that Warren ! ___ freebsd-wireless@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
RE: [iwn] Review split 3
> De : Warren Block [mailto:wbl...@wonkity.com] > Envoyé : lundi 29 juillet 2013 20:11 > À : Adrian Chadd > Cc : Cedric GROSS; freebsd-wireless@freebsd.org > > On Mon, 29 Jul 2013, Adrian Chadd wrote: > > > Hi! > > > > Cool! ok, the style niggles. > > > > * Your #define IWN_blah needs a TAB between #define and the IWN_blah > > value. Right now you have spaces. Ok, I tough you need spaces between #define and values... standard single-include stuff : Done $FreeBSD$ : Moved Each file is different. Really hard to find something common. Man 9 style is quite useful but enough precise for tab and space usage I think. > > There is whitespace at the end of some of the comment lines also. > > textproc/igor will find problems like that: > >igor -R filename | less -RS Thanks for that Warren ! deviceid.patch Description: Binary data ___ freebsd-wireless@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: [iwn] Review split 3
On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. There is whitespace at the end of some of the comment lines also. textproc/igor will find problems like that: igor -R filename | less -RS ___ freebsd-wireless@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: [iwn] Review split 3
Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. * $FreeBSD$ should be after the copyright header, not before * Your new file is missing the standard single-include stuff.. ie #ifndef __IF_IWN_DEVID_H__ #define __IF_IWN_DEVID_H__ (header contents go here..) #endif /* __IF_IWN_DEVID_H__ */ -adrian On 29 July 2013 08:49, Cedric GROSS wrote: > Hello, > > > > As discuss we Adrian, previous big patch is too heavy for direct application > in repo. > > So I resume splitting modification. > > > > Here is split 3. > > This one create if_iwn_devif.h for storing device ID and subdevice ID for > later use. > > If_iwn.c and If_iwnreg.h modified as needed. > > > > Cedric > > > ___ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org" ___ freebsd-wireless@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
[iwn] Review split 3
Hello, As discuss we Adrian, previous big patch is too heavy for direct application in repo. So I resume splitting modification. Here is split 3. This one create if_iwn_devif.h for storing device ID and subdevice ID for later use. If_iwn.c and If_iwnreg.h modified as needed. Cedric deviceid.patch Description: Binary data ___ freebsd-wireless@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
