Re: Add support for Realtek RTL8192EU
On Fri, Jan 20, 2017 at 02:14:09PM +0800, Kevin Lo wrote: > > On Fri, Jan 20, 2017 at 01:26:37AM +0200, Andriy Voskoboinyk wrote: > > > > Thu, 19 Jan 2017 10:36:43 +0200 було написано Kevin Lo : > > > > Hi Kevin, > > Hi Andriy, > > > thanks for the patch! few notes to it: > > - r92c_llt_write() seems to be used only in r92c_llt_init(); so, > > it may be called without sc->sc_llt_write indirection from it; > > - you can set rate for beacon directly in r12a_beacon_init() > > (it will be overridden anyway by r12a_beacon_set_rate()) and drop > > r92e_beacon_init() wrapper. > > Fixed. Thank you for the review :) > > > Are there some plans for merging it to -HEAD? > > I'd like to commit it next Tuesday, thanks. Committed as r312680. Kevin ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Add support for Realtek RTL8192EU
On Fri, Jan 20, 2017 at 01:26:37AM +0200, Andriy Voskoboinyk wrote: > > Thu, 19 Jan 2017 10:36:43 +0200 було написано Kevin Lo : > > Hi Kevin, Hi Andriy, > thanks for the patch! few notes to it: > - r92c_llt_write() seems to be used only in r92c_llt_init(); so, > it may be called without sc->sc_llt_write indirection from it; > - you can set rate for beacon directly in r12a_beacon_init() > (it will be overridden anyway by r12a_beacon_set_rate()) and drop > r92e_beacon_init() wrapper. Fixed. Thank you for the review :) > Are there some plans for merging it to -HEAD? I'd like to commit it next Tuesday, thanks. > > > Hi, > > > > This adds support for the RTL8192EU Realtek wireless chipset: > > https://people.freebsd.org/~kevlo/rtwn-rtl8192eu.diff > > > > Tested in station mode with D-Link DWA-131 rev E1 on amd64. > > > > Kevin ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
Re: Add support for Realtek RTL8192EU
Thu, 19 Jan 2017 10:36:43 +0200 було написано Kevin Lo : Hi Kevin, thanks for the patch! few notes to it: - r92c_llt_write() seems to be used only in r92c_llt_init(); so, it may be called without sc->sc_llt_write indirection from it; - you can set rate for beacon directly in r12a_beacon_init() (it will be overridden anyway by r12a_beacon_set_rate()) and drop r92e_beacon_init() wrapper. Are there some plans for merging it to -HEAD? Hi, This adds support for the RTL8192EU Realtek wireless chipset: https://people.freebsd.org/~kevlo/rtwn-rtl8192eu.diff Tested in station mode with D-Link DWA-131 rev E1 on amd64. Kevin ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org" ___ freebsd-wireless@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"
