Re: [IWN] Review

2013-10-23 Thread Adrian Chadd
Hi, Ok. I've reviewed this stuff in more depth. Split-6 is still way too big to commit as one commit. I was also hoping that we could get the updated hardware support into this without necessarily adding the PAN support. But, you're the one driving this, so it's up to you. :) * There's

Re: [IWN] Review

2013-10-23 Thread Adrian Chadd
.. and I've just done the if_iwn_debug.h stuff, so you should update your patchset to include that. Thanks, -adrian On 23 October 2013 17:43, Adrian Chadd adr...@freebsd.org wrote: Hi, Ok. I've reviewed this stuff in more depth. Split-6 is still way too big to commit as one commit.

Re: [IWN] Review

2013-10-15 Thread Adrian Chadd
Objet : RE: [IWN] Review On Mon, 2013-09-30 at 16:47 +0200, Cedric GROSS wrote: Hello, I forgot your lastest commit but it?s done now. So split_6 and split_7 are sync with most recent ?HEAD. Cedric Cedric: Hi Sean, Which branch should we be testing? As Adrian wish

RE: [IWN] Review

2013-09-30 Thread Cedric GROSS
-wireless@freebsd.org Objet : Re: [IWN] Review .. is this diff (split_6) against the most recent -HEAD? There looks like there's some extra stuff in there that I committed recently (ie, the rate control change and deref/free) I'll go check it out in more depth soon. Thanks, -a On 29

RE: [iwn]Review Split 6

2013-08-13 Thread Cedric GROSS
I guess '_u1' here is 'PAN VAP'. We'll eventually rename this stuff and maybe shift it into a separate source file so all the PAN stuff clearly lives elsewhere. Ok I'll do that. Here is new version of split 6 with new files and new function renamed. Cedric pan2.patch Description:

RE: [iwn]Review Split 6

2013-08-12 Thread Cedric GROSS
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part de Adrian Chadd Envoyé : dimanche 11 août 2013 19:09 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org Objet : Re: [iwn]Review Split 6 On 11 August 2013 10:06, Cedric GROSS c...@cgross.info wrote: U1 stand

Re: [iwn]Review Split 6

2013-08-12 Thread Adrian Chadd
On 12 August 2013 10:41, Cedric GROSS c...@cgross.info wrote: But again, as current version is not stable in normal operation, I haven't test it further. What could be interest of this ? Wifi relay, bridge or whatever usage of 2 wireless but only with 1 card. It's likely for STA on one VAP

Re: [iwn]Review Split 6

2013-08-12 Thread Adrian Chadd
Ok, so this PAN support is .. pretty terrifying. We'll have to tidy it up once the rest of this work is debugged. I guess '_u1' here is 'PAN VAP'. We'll eventually rename this stuff and maybe shift it into a separate source file so all the PAN stuff clearly lives elsewhere. I wonder which NICs

RE: [iwn]Review Split 6

2013-08-12 Thread Cedric GROSS
-Message d'origine- De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part de Adrian Chadd Envoyé : lundi 12 août 2013 20:25 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org Objet : Re: [iwn]Review Split 6 Ok, so this PAN support is .. pretty terrifying. We'll

Re: [iwn]Review Split 6

2013-08-11 Thread Adrian Chadd
Hi! What's 'u1' as a prefix supposed to represent? -adrian On 11 August 2013 06:09, Cedric GROSS c...@cgross.info wrote: Hello, Here is patch split 6. It's follow split 5 as it implement PAN context. This patch is purely based on work done by Sean Bruno. Cedric

RE: [iwn]Review Split 6

2013-08-11 Thread Cedric GROSS
-Message d'origine- De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part de Adrian Chadd Envoyé : dimanche 11 août 2013 18:34 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org Objet : Re: [iwn]Review Split 6 Hi! What's 'u1' as a prefix supposed

Re: [iwn]Review Split 6

2013-08-11 Thread Adrian Chadd
On 11 August 2013 10:06, Cedric GROSS c...@cgross.info wrote: U1 stand for unit 1. As you see, all function with this prefix will be call when unit==1 within iwn_vap_create. As previously, I haven't investigate a lot this side. I plan to do so when standard run will be ok. Right. But

Re: [iwn] Review split 5

2013-08-09 Thread Adrian Chadd
On 8 August 2013 03:43, Cedric GROSS c...@cgross.info wrote: So please go and fix that! Done. Cool. I'll test this out on the 4965 and 5100 today/tomorrow and get back to you. -adrian ___ freebsd-wireless@freebsd.org mailing list

Re: [iwn] Review split 5

2013-08-05 Thread Adrian Chadd
.. so what's this PAN context stuff? -adrian On 5 August 2013 10:23, Cedric GROSS c...@cgross.info wrote: Hello, Here is another split. This one update if_iwnvar.h with new structure for later but also modify iwn_softc for context selection. Context will be used later when PAN

Re: [iwn] Review split 4

2013-08-02 Thread Adrian Chadd
Committed! Thanks! -adrian On 2 August 2013 04:12, Cedric GROSS c...@cgross.info wrote: Hello, After split 3 applied and committed , you will find split 4. This one modify if_iwnreg.h Add nearly everything we will need for later use. Cedric

Re: [iwn] Review split 3

2013-07-29 Thread Adrian Chadd
Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. * $FreeBSD$ should be after the copyright header, not before * Your new file is missing the standard single-include stuff.. ie #ifndef __IF_IWN_DEVID_H__

Re: [iwn] Review split 3

2013-07-29 Thread Warren Block
On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. There is whitespace at the end of some of the comment lines also. textproc/igor will find problems like that:

RE: [iwn] Review split 3

2013-07-29 Thread Cedric GROSS
De : Warren Block [mailto:wbl...@wonkity.com] Envoyé : lundi 29 juillet 2013 20:11 À : Adrian Chadd Cc : Cedric GROSS; freebsd-wireless@freebsd.org On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and

RE: IWN Review

2013-07-21 Thread Cedric GROSS
De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part de Adrian Chadd Envoyé : dimanche 21 juillet 2013 06:06 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org; freebsd-driv...@freebsd.org Hi! so, my feedback! * Why'd you disable including opt_wlan.h ? It's required

RE: IWN Review

2013-07-20 Thread Cedric GROSS
De : Andrey Fesenko [mailto:f0and...@gmail.com] Envoyé : samedi 20 juillet 2013 16:29 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org; freebsd-driv...@freebsd.org On Sat, Jul 20, 2013 at 6:18 PM, Cedric GROSS c...@cgross.info wrote: Hello dear all, I'm please to announce that I

Re: IWN Review

2013-07-20 Thread Andrey Fesenko
On Sat, Jul 20, 2013 at 7:30 PM, Cedric GROSS c...@cgross.info wrote: De : Andrey Fesenko [mailto:f0and...@gmail.com] Envoyé : samedi 20 juillet 2013 16:29 À : Cedric GROSS Cc : freebsd-wireless@freebsd.org; freebsd-driv...@freebsd.org On Sat, Jul 20, 2013 at 6:18 PM, Cedric GROSS

Re: IWN Review

2013-07-20 Thread Lev Serebryakov
Hello, Andrey. You wrote 20 июля 2013 г., 19:42:41: AF I think whether to change AR9285 base card or not :) Atheros is better. And, yes, Intel doesn't support host AP mode. -- // Black Lion AKA Lev Serebryakov l...@freebsd.org ___

RE: IWN Review

2013-07-20 Thread Cedric GROSS
De : Andrey Fesenko [mailto:f0and...@gmail.com] [...] Great news, whether the driver supports n-mode? What do you mean by 'n-mode' ? 802.11n mode ? If so, answer is yes : #dmesg |grep iwn0 iwn0: Intel Centrino Wireless-N 2230 mem 0xf7c0-0xf7c01fff irq 18 at device 0.0 on

Re: IWN Review

2013-07-20 Thread Adrian Chadd
Hi! This is great news! Are you able to merge this into the iwn driver? Is it feasible? I'd rather not have two drivers in the tree for the same family of NICs. Thanks! -adrian On 20 July 2013 08:54, Cedric GROSS c...@cgross.info wrote: De : Andrey Fesenko [mailto:f0and...@gmail.com]