Re: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release all resources) after adding and removing NICs time and again

2017-02-15 Thread Roger Pau Monné
..@huawei.com> > > 主题: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release > > all resources) after adding and removing NICs time and again > > > > On Tue, Feb 07, 2017 at 04:55:34PM +, Liuyingdong wrote: > >> Hi Roger, > >> I

Re: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release all resources) after adding and removing NICs time and again

2017-02-15 Thread liuyingdong
awei.com>; Wanglinkai <wanglin...@huawei.com>; chuzhaosong > <chuzhaos...@huawei.com>; Wangchunfeng (Ivan) <chunfeng.w...@huawei.com>; > Gaoxiaodong (Leo) <leo.gaoxiaod...@huawei.com> > 主题: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release all >

Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release all resources) after adding and removing NICs time and again

2017-02-10 Thread roger....@citrix.com
On Tue, Feb 07, 2017 at 04:55:34PM +, Liuyingdong wrote: > Hi Roger, > I am so sorry and please review tne below URL: > https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.html Hello, Thanks for the patches, and sorry for the delay. It seems like you have not

答复: 答复: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2017-02-07 Thread Liuyingdong
Hi Roger, I am so sorry and please review tne below URL: https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.html 发件人：freebsd xen 收件人：刘迎冬 抄送：freebsd-xen@freebsd.org,索奔,赵军,王林凯,储召松,王春风,高晓东 时间：2017-02-07 18:44:16 主题:Re: 答复: [PATCH]netfront: need release all resources after

Re: 答复: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2017-02-07 Thread freebsd xen
On Mon, Feb 06, 2017 at 01:54:28PM +, Liuyingdong wrote: > Hello Roger, > I want to know what about these patch, Please let me know if you have > any questions. > If you think these patch are fine, I want to your checking-in plan. > Thanks! Hello, Which patches should I look

答复: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2017-02-06 Thread Liuyingdong
} > > DEVICE_RESUME(kids[i]); > > - xs_register_watch(>xd_otherend_watch); > + if(xenbusb_suspend_cancelled == 0) > + xs_register_watch(>xd_otherend_watch); Why don't you just add: if (xenbusb_

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2017-02-02 Thread Liuyingdong
> > - xs_register_watch(>xd_otherend_watch); > + if(xenbusb_suspend_cancelled == 0) > + xs_register_watch(>xd_otherend_watch); Why don't you just add: if (xenbusb_suspend_cancelled == 1) { DEVICE_RESU

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2017-01-06 Thread freebsd xen
if(xenbusb_suspend_cancelled == 0) > + xs_register_watch(>xd_otherend_watch); Why don't you just add: if (xenbusb_suspend_cancelled == 1) { DEVICE_RESUME(kids[i]); continue; } To the top of the loop? This would present adding a bun

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2016-12-14 Thread Liuyingdong
@freebsd.org; Zhaojun (Euler); Suoben; Ouyangzhaowei (Charles) 主题: Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again On Tue, Dec 13, 2016 at 02:03:08PM +0800, liuyingdong wrote: > Hello Roger, > I want to know how about this patch,Please let m

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2016-12-13 Thread freebsd xen
On Tue, Dec 13, 2016 at 02:03:08PM +0800, liuyingdong wrote: > Hello Roger, > I want to know how about this patch,Please let me know if you have any > questions. > Thanks. Hello, Thanks for the patches! This one is looking fine, it's just that I'm a little bit busy at the moment, and

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2016-12-12 Thread liuyingdong
f (info->copying_receiver) > + netif_release_rx_bufs_copy(info); > + > + gnttab_free_grant_references(info->gref_tx_head); > + gnttab_free_grant_references(info->gref_rx_head); > } > > static void > > > Yours Yingdong Liu > > &

Re: [PATCH]netfront: need release all resources after adding and removing NICs time and again

2016-11-10 Thread liuyingdong
erences(info->gref_rx_head); } static void Yours Yingdong Liu -邮件原件- 发件人: roger@citrix.com [mailto:roger@citrix.com] 发送时间: 2016年11月8日 21:05 收件人: Liuyingdong 抄送: freebsd-xen@freebsd.org; Zhaojun (Euler); Suoben 主题: Re: [PATCH]netfront: need release all resources after adding and r

[PATCH]netfront: need release all resources after adding and removing NICs time and again

2016-11-04 Thread Liuyingdong
On xen,freebsd 10.2 virtual machines hang after adding and removing NICs time and again(more than 30 times). I found error log is as follows: "netfront can't alloc tx grant refs" Signed-off-by: Liudong Liu diff --git a/dev/xen/netfront/netfront.c