On Thursday, December 19, 2013 1:54:43 pm Roger Pau Monne wrote:
> When running as a PVH guest, there's no emulated i8254, so we need to
> use the Xen PV timer as the early source for DELAY. This change allows
> for different implementations of the early DELAY function and
> implements a Xen variant for it.
This mostly looks good to me. I would perhaps move DELAY() itself into
delay.c if it isn't too ugly to do so. I guess it would look something
like:
#if !(defined(__i386__) && defined(XEN))
void
DELAY(int n)
{
if (delay_tc(n))
return;
#ifdef __amd64__
init_ops.early_delay(n);
#else
i8254_delay(n);
}
#endif
This would let you leave delay_tc() private to delay.c.
--
John Baldwin
_______________________________________________
freebsd-xen@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-xen
To unsubscribe, send any mail to "freebsd-xen-unsubscr...@freebsd.org"
