Re: Another blkback issue related to flush
On 04/09/13 19:49, Justin T. Gibbs wrote: > On Sep 4, 2013, at 11:07 AM, Roger Pau Monné wrote: > >> Hello, >> >> I've found another issue with blkback handling of flush operations, it >> was incorrectly setting one of the bio parameters when using a block >> device as backend. The attached patch fixes it, and also includes a >> small fix to correctly set the operation when writing the response on >> the ring (all responses written by FreeBSD blkback were of type >> BLKIF_OP_READ, because nreq->operation was not set). > > It seems that the req's pendcnt is unused and can be culled. Otherwise, > looks good to me. Here's the patch I have in my tree now. Thanks for catching this one. The patch looks OK to me. ___ freebsd-xen@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xen To unsubscribe, send any mail to "freebsd-xen-unsubscr...@freebsd.org"
Re: Another blkback issue related to flush
On Sep 4, 2013, at 11:07 AM, Roger Pau Monné wrote: > Hello, > > I've found another issue with blkback handling of flush operations, it > was incorrectly setting one of the bio parameters when using a block > device as backend. The attached patch fixes it, and also includes a > small fix to correctly set the operation when writing the response on > the ring (all responses written by FreeBSD blkback were of type > BLKIF_OP_READ, because nreq->operation was not set). It seems that the req's pendcnt is unused and can be culled. Otherwise, looks good to me. Here's the patch I have in my tree now. -- Justin blkback.diff Description: Binary data ___ freebsd-xen@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xen To unsubscribe, send any mail to "freebsd-xen-unsubscr...@freebsd.org"
