Re: kern/176471: commit references a PR

2013-06-18 Thread dfilter service
The following reply was made to PR kern/176471; it has been noted by GNATS.

From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:  
Subject: Re: kern/176471: commit references a PR
Date: Tue, 18 Jun 2013 23:14:35 + (UTC)

 Author: gibbs
 Date: Tue Jun 18 23:14:21 2013
 New Revision: 251973
 URL: http://svnweb.freebsd.org/changeset/base/251973
 
 Log:
   MFC Xen fixes:
   
   svn rev 250081 Author:gibbs Date:2013-04-29T23:08:13.552620Z
   ==
   xenstore/xenstore.c:
   Prevent access to invalid memory region when listing an empty
   directory in the XenStore.
   
   Reported by: Bei Guan
   
   svn rev 250913 Author:gibbs Date:2013-05-22T17:13:03.545339Z
   ==
   Correct panic on detach of Xen PV network interfaces.
   
   dev/xen/netfront:
   In netif_free(), properly stop the interface and drain any pending
   timers prior to disconnecting from the backend device.
   
   Remove all media and detach our interface object from the system
   prior to deleting it.
   
   PR:  kern/176471
   Submitted by:Roger Pau Monne roger@citrix.com
   Reviewed by: gibbs
   
   svn rev 250917 Author:gibbs Date:2013-05-22T19:22:44.923351Z
   ==
   Fix loss of the emulated keyboard on Xen PV HVM domains.
   
   xen/xenbus/xenbusb.c:
   In xenbusb_probe_children(), do not modify the XenBus state of
   devices for which we have no PV driver support. An emulated device
   we do support may share this backend.  Hide the node from XenBus
   instead.
   
   This prevents closing the vkbd device, which Qemu's emulated keyboard
   device is using as the source for keyboard events.
   
   Tested with qemu-xen-traditional, qemu-xen and qemu stubdomains, all
   working as expected.
   
   Submitted by:Roger Pau Monne roger@citrix.com
   Reviewed by: gibbs
   MFC after:   1 week
   
   svn rev 251175 Author:gibbs Date:2013-05-31T04:43:19.944993Z
   ==
   Apply the ad* = ada* IDE device name transition to the Xen block
   front driver.
   
   Submitted by:Bei Guan gbtj...@gmail.com
   Reviewed by: gibbs
   MFC after:   1 week
   
   svn rev 251176 Author:gibbs Date:2013-05-31T04:45:59.563195Z
   ==
   Make netif_free() safe to call on a partially initialized softc.
   
   Sponsored by:Spectra Logic Corporation
   MFC after:   1 week
   
   svn rev 251729 Author:gibbs Date:2013-06-14T03:31:11.033200Z
   ==
   sys/dev/xen/netfront/netfront.c:
   In netif_free(), call ifmedia_removeall() after ether_ifdetach()
   so that bpf listeners are detached, any link state processing
   is completed, and there is no chance for external reference to media
   information.
   
   Suggested by:yongari
 
 Modified:
   stable/9/sys/dev/xen/blkfront/blkfront.c
   stable/9/sys/dev/xen/netfront/netfront.c
   stable/9/sys/xen/xenbus/xenbusb.c
   stable/9/sys/xen/xenstore/xenstore.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/dev/   (props changed)
 
 Modified: stable/9/sys/dev/xen/blkfront/blkfront.c
 ==
 --- stable/9/sys/dev/xen/blkfront/blkfront.c   Tue Jun 18 23:11:36 2013
(r251972)
 +++ stable/9/sys/dev/xen/blkfront/blkfront.c   Tue Jun 18 23:14:21 2013
(r251973)
 @@ -148,16 +148,16 @@ blkfront_vdevice_to_unit(uint32_t vdevic
int base;
const char *name;
} info[] = {
 -  {3, 6,  0,  ad},  /* ide0 */
 -  {22,6,  2,  ad},  /* ide1 */
 -  {33,6,  4,  ad},  /* ide2 */
 -  {34,6,  6,  ad},  /* ide3 */
 -  {56,6,  8,  ad},  /* ide4 */
 -  {57,6,  10, ad},  /* ide5 */
 -  {88,6,  12, ad},  /* ide6 */
 -  {89,6,  14, ad},  /* ide7 */
 -  {90,6,  16, ad},  /* ide8 */
 -  {91,6,  18, ad},  /* ide9 */
 +  {3, 6,  0,  ada}, /* ide0 */
 +  {22,6,  2,  ada}, /* ide1 */
 +  {33,6,  4,  ada}, /* ide2 */
 +  {34,6,  6,  ada}, /* ide3 */
 +  {56,6,  8,  ada}, /* ide4 */
 +  {57,6,  10, ada}, /* ide5 */
 +  {88,6,  12, ada}, /* ide6 */
 +  {89,6,  14, ada}, /* ide7 */
 +  {90,6,  16, ada}, /* ide8 */
 +  {91,6,  18, ada}, /* ide9 */
  
{8, 4,  0,  da},  /* scsi disk0 */
{65,4,  16, da},  /* scsi disk1 */
 
 Modified: stable/9/sys/dev/xen/netfront/netfront.c
 ==
 --- stable/9/sys/dev/xen

Re: kern/176471: commit references a PR

2013-05-22 Thread dfilter service
The following reply was made to PR kern/176471; it has been noted by GNATS.

From: dfil...@freebsd.org (dfilter service)
To: bug-follo...@freebsd.org
Cc:  
Subject: Re: kern/176471: commit references a PR
Date: Wed, 22 May 2013 17:13:21 + (UTC)

 Author: gibbs
 Date: Wed May 22 17:13:03 2013
 New Revision: 250913
 URL: http://svnweb.freebsd.org/changeset/base/250913
 
 Log:
   Correct panic on detach of Xen PV network interfaces.
   
   dev/xen/netfront:
   In netif_free(), properly stop the interface and drain any pending
   timers prior to disconnecting from the backend device.
   
   Remove all media and detach our interface object from the system
   prior to deleting it.
   
   PR:  kern/176471
   Submitted by:Roger Pau Monne roger@citrix.com
   Reviewed by: gibbs
   MFC after:   1 week
 
 Modified:
   head/sys/dev/xen/netfront/netfront.c
 
 Modified: head/sys/dev/xen/netfront/netfront.c
 ==
 --- head/sys/dev/xen/netfront/netfront.c   Wed May 22 16:33:28 2013
(r250912)
 +++ head/sys/dev/xen/netfront/netfront.c   Wed May 22 17:13:03 2013
(r250913)
 @@ -2171,10 +2171,14 @@ netfront_detach(device_t dev)
  static void
  netif_free(struct netfront_info *info)
  {
 +  XN_LOCK(info);
 +  xn_stop(info);
 +  XN_UNLOCK(info);
 +  callout_drain(info-xn_stat_ch);
netif_disconnect_backend(info);
 -#if 0
 -  close_netdev(info);
 -#endif
 +  ifmedia_removeall(info-sc_media);
 +  ether_ifdetach(info-xn_ifp);
 +  if_free(info-xn_ifp);
  }
  
  static void
 ___
 svn-src-...@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
 
___
freebsd-xen@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-xen
To unsubscribe, send any mail to freebsd-xen-unsubscr...@freebsd.org