[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #18 from Jethro Nederhof --- OK so I've dug into this a bit further and I think there is a relevant bug in XFCE. For port x11/libxfce4menu, in libxfce4kbd-private/xfce-shortcuts-grabber.c and the xfce_shortcuts_grabber_keys_changed function. This function is called whenever the X11 keymap is updated, it 'ungrabs' all the current shortcut keys, then loops through again and 'grabs' them again. Grabs are implemented against the keycode value provided by the keymap, but the problem is the removal ungrabs with the current updated value from the keymap (keys[i].keycode), rather than the old one. So the problem manifests as: XFCE loads with a keymap XFCE registers shortcuts that use keys in that keymap The keymap updates The changes in the keymap update involve keys used in shortcuts XFCE ungrabs the shortcuts using the 'new' keymap codes The 'old' keymap codes never get ungrabbed, but the new keycodes are grabbed So for me when XFCE starts, gdk_keymap_get_entires_for_keyval() tells XFCE that "keycode 111 (Up) maps to keyval 65377 (Print)" (for whatever reason), XFCE maps the shortcut to it, then shortly after the keymap updates and says that "actually keycode 107 (Print) maps to keyval 65377 (Print)" and XFCE then ungrabs keycode 107, then grabs it again, and the grab against 111 just stays there forever without being cleaned up. I don't know much about X programming, but guess 'up' itself fails since even when it matches the grab, the keyval doesn't match keyval 65377 (Print) so it never tries to launch the associated shortcut in xfce_shortcuts_grabber_event_filter(), then the 'flash' is the keypress event getting sent to the root_window and unfocusing/refocusing the child window which never receives the event due to XGrabKey's owner_events being false. The setxkbmap workaround works by racing XFCE and updating the keymap so it's correct the first time and nothing needs to be cleaned up, but the problem would arise again if the keymap got updated mid-session (though why this happens every session for me I haven't discovered). -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #17 from Guido Falsi --- (In reply to Jethro Nederhof from comment #15) No offense taken! -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #16 from Guido Falsi --- After a quick look I'd say xfce is doing some default binding with the arrow keys. up and down ones at least. I have no idea which xfce component and which library function they may be calling to perform such mapping. Even grepping the sources is not going to help much, since I don't know what to grep and where. I'd suggest you file a bug report in the xfce bugzilla, describing the problem in simple terms. You should also state FreeBSD changed the Xorg default backend for input events. You should also state we are looking for some clue, maybe some XFCE developer with better knowledge of the code base can point us in the right direction. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #15 from Jethro Nederhof --- (In reply to Guido Falsi from comment #12) Sorry all, I think I've come across more rudely than intended! I didn't mean to claim disabling the shortcut was the best solution or a fix for everyone, just mentioned that it worked for me to hopefully give more information to help find the core issue. Likewise that my hardware situation seemed different to aryeh's I thought was just additional information. Apologies if I was pushy or rude in trying to help. I can easily enable/disable the issue now so if I can help test any further solutions I'm happy to help. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #14 from aryeh.fried...@gmail.com --- (In reply to Guido Falsi from comment #12) >From my testing other WM's for the most part see xev correctly -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #13 from Guido Falsi --- (In reply to Guido Falsi from comment #12) This was meant as a reply to comment #10 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #12 from Guido Falsi --- (In reply to aryeh.friedman from comment #11) As I have already stated, I have no clue, so I'm not proposing solutions. What I was asking if you "tested" some changes whch had an effect for other people. I really don't understand you point about "just working". We would all like everything to "just work" and sometimes they do, some others they don't. In your case it does not "just work" and a solution is needed. Testing with xbkconf may not rate as a solution but could be a test to see how things work out. Apart from this if for any reason your setup maps keys differently than other systems xkbconf could be the only solution. The xev output shows the key giving a different result. One interesting test would be to test in xev with another window manager (twm for example) to see if the key is read correctly there by xev. I don't know the internals of xfce parts. I only upgraded the ports and try to keep them working. I don't know if there is something fiddling with the input and have no idea where to start to look for that. I'm trying to help you, but since I'm not experiencing this issue I can only ask you to perform some operation to give me a clue. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #11 from aryeh.fried...@gmail.com --- (In reply to Jethro Nederhof from comment #10) Out of all the suggested solutions both here and in the mailing list thread the setxkbmap is the one that is: 1. The most universal (there have reports of other WM's doing the same thing as xfce4 and this is a one size fits all solution) 2. It is the one that "just works" and is the most transparent to the GUI/applications/user 3. It by far the simplest and most persistent I stand by comment I made in the mail thread that the entire thing is a CLUSTERF*CK but the simplest solution is to completely wipe and reinstall Xorg, XFCE4 and do the solution suggested (all others are true hacks). -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #10 from Jethro Nederhof --- (In reply to Guido Falsi from comment #9) I don't think Virtualbox/Windows are the problem because outside of XFCE in the VM it works 100% as expected so the kernel sees it fine. It is only an issue after XFCE is launched and with that Keyboard Shortcut enabled. Outside XFCE it is fine, or with that shortcut disabled it is fine. I have no xorg config after 20-evdev-kbd.conf except 40-libinput.conf, and commenting them each out only gave me the earlier behaviour I mentioned where it properly tries to actually launch xfce-screenshooter. I haven't tried the solution from comment #3 because I don't have setxkbmap and don't want to install it for something that should "just work", (and does work if I disable that shortcut). So I guess for me the problem is a subset of this issue, and more like "up arrow triggers Print action in xfce4 instead of up-arrow" -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #9 from Guido Falsi --- (In reply to Jethro Nederhof from comment #8) The fact that it is running in virtualbox on windows add a whole layer of things that could be interfering even before the FreeBSD kernel sees the input. While it is strange for it to work fine on twm, there could be some changes that affect xfce and not the rest of the system. I honestly have no clue here. Apart from this have you tried following the suggestion sin the mail thread posted in comment #7 ? -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #8 from Jethro Nederhof --- xev output, down arrow which works fine and is what you'd expect, followed by up arrow which fails: == # Down arrow, works OK KeyPress event, serial 37, synthetic NO, window 0x2a1, root 0x51, subw 0x0, time 9668719, (-1695,451), root:(138,1326), state 0x10, keycode 116 (keysym 0xff54, Down), same_screen YES, XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False KeyRelease event, serial 37, synthetic NO, window 0x2a1, root 0x51, subw 0x0, time 9668800, (-1695,451), root:(138,1326), state 0x10, keycode 116 (keysym 0xff54, Down), same_screen YES, XLookupString gives 0 bytes: XFilterEvent returns: False # Up arrow, doesn't work FocusOut event, serial 37, synthetic NO, window 0x2a1, mode NotifyGrab, detail NotifyAncestor FocusIn event, serial 37, synthetic NO, window 0x2a1, mode NotifyUngrab, detail NotifyAncestor KeymapNotify event, serial 37, synthetic NO, window 0x0, keys: 37 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 == If I disable the 'Print' shortcut above then I get the 'Up' KeyRelease event like in your xev output as expected. It affects everything in the XFCE session, terminal, firefox, text editors, menus. If I leave xfce and drop to a regular non-X console the up-arrow works fine, then I can run startxfce4 and the issue returns unless I remove that keyboard shortcut. This is a FreeBSD guest in VirtualBox running 13-CURRENT on a Windows 10 host with a Corsair K70 keyboard. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #7 from aryeh.fried...@gmail.com --- For those who want to see the -x11@ thread where this was discussed/solved at great length see https://lists.freebsd.org/pipermail/freebsd-x11/2020-February/024971.html -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #6 from aryeh.fried...@gmail.com --- (In reply to aryeh.friedman from comment #5) Forgot it is a standard old cheap 105 key wired keyboard on a generic desktop (Logitech K120 which I have used for years and cost less then $15 [I ware keyboards out to fast for it to be worth investing in anything more expensive]). -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #5 from aryeh.fried...@gmail.com --- (In reply to Guido Falsi from comment #4) xev is what gave us the clue to try the solution I mentioned in comment 3. Short answer is then events are not passed through to where xev can see them (something higher up eats them) -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 Guido Falsi changed: What|Removed |Added CC||madpi...@freebsd.org Status|New |Open Flags||maintainer-feedback+ --- Comment #4 from Guido Falsi --- Hi, I noticed now this PR. comment #1 says it does not happen in twm, it means you have tried running "startx" from a terminal with all workarounds disabled? I'm asking to understand the setup. I personally am not experiencing this problem. the up arrow works fine for the use I do of it, which is mostly navigating history on shells and using vi in xfce4-terminal. Is this what is not working for you? BTW what is your hardware? are you using a laptop? If you run xev and press the up arrow in it what do you get? I'm getting these events, for reference: KeyPress event, serial 37, synthetic NO, window 0x681, root 0x28b, subw 0x0, time 4786538, (75,-13), root:(786,349), state 0x0, keycode 111 (keysym 0xff52, Up), same_screen YES, XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False KeyRelease event, serial 37, synthetic NO, window 0x681, root 0x28b, subw 0x0, time 4786613, (75,-13), root:(786,349), state 0x0, keycode 111 (keysym 0xff52, Up), same_screen YES, XLookupString gives 0 bytes: XFilterEvent returns: False -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 --- Comment #3 from aryeh.fried...@gmail.com --- I should of updated the PR to show the temp solution that me and someone working together in -x11@ devised.. add the following line to your .xinitrc (or .xsession as the case may be): setxkbmap -model pc105 -layout us Only real draw back is there is a noticable delay after typing the first character in session and all additional ones -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 244290] x11-wm/xfce4 does not see up arrow after reinstall
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244290 Jethro Nederhof changed: What|Removed |Added CC||jet...@jethron.id.au --- Comment #2 from Jethro Nederhof --- Also experiencing this issue. Temporary workaround: XFCE Settings > Keyboard > Application Shortcuts > Selecting the 'Print' shortcut for 'xfce-screenshooter' and removing that option (it is a default entry in XFCE) restores the up-arrow after restarting the session. But presumably PrtScn will now no longer take screenshots? With the default in place and the evdev keyboard input driver you get this PR behaviour where it registers it as some kind of input, but not up arrow (cursors, scroll bars etc seem to 'flash' as a focus change or something when you press the key, but 'up' never registers). Switching to libinput makes the up-arrow actually try to run xfce-screenshooter which gives me an error (because I don't have that installed) which led me to this workaround. Why evdev doesn't try to run shooter and give the error, but disabling that shortcut still fixes the problem, is a different question... -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
