[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 Guido Falsi changed: What|Removed |Added Resolution|--- |Overcome By Events Status|Open|Closed --- Comment #11 from Guido Falsi --- The code causing this crash has been completely rewritten by upstream with recent updates. So this bug does not apply anymore. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #10 from Guido Falsi --- Hi, Looking at this bug report, it looks like the upstream code referenced here has undergone extensive changes with the latest releases, here are two relevant upstream commits: https://gitlab.xfce.org/apps/xfce4-taskmanager/-/commit/fd9e313e2e89ed0b81bec8c491842e7032e797ac https://gitlab.xfce.org/apps/xfce4-taskmanager/-/commit/b89684865d88bbb8399f70387cae9e8ae17d64d9 I'd like to close this one, and will do that in a few days unless prompted not to do so. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 Guido Falsi changed: What|Removed |Added Flags|maintainer-feedback?(xfce@F |maintainer-feedback+ |reeBSD.org) | CC||madpi...@freebsd.org --- Comment #9 from Guido Falsi --- (In reply to Ivan from comment #6) > Created attachment 174716 [details] > patch > > Problem is here > g_strlcpy (text, p, g_utf8_strlen (text, -1)); > > To utf-8 unaware function number of chars are passed instead of bytes, so > it's possible for 2 bytes chars it will split in half leading to incorrect > unicode sequence. > > Attached patch resolves the issue, however crash still can occur if p >= > text, however as p is substring of text, the situation is expected to never > happen in normal conditions. > > I found no safe analog in gtk functions for strlcpy, only strncpy which is > not considered safe. The alternative is switch to icu, however this is > another story. Hi, The fix looks simple enough, but I'm not sure that using non utf aware functions is better that using g_utf8_strncpy(), which would warrant utf8 conforming results. also, looking at the g_utf8_strncpy() sources here: https://github.com/GNOME/glib/blob/9c8c6094fdb3b7bff35c0f36a68e1da3fd2e8ff7/glib/gutf8.c#L413 it would be quite easy to cook up a g_utf8_strlcpy() (or any other name) using the safer system provided strlcpy() call. I'd like your opinion before proceeding though. Any patch we prepare should be created accounting for upstreaming it if possible. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 Jan Beich changed: What|Removed |Added Attachment #180531|text/x-log |text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #8 from Ivan --- Created attachment 180531 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=180531&action=edit QA with synth -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #7 from Ivan --- New version bump erased my local patch and I remembered about this issue. I can make the patch against current port tree if this is necessary or @Olivier Duchateau can commit it as is. I tested it today and it's still to what it does. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #6 from Ivan --- Created attachment 174716 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=174716&action=edit patch Problem is here g_strlcpy (text, p, g_utf8_strlen (text, -1)); To utf-8 unaware function number of chars are passed instead of bytes, so it's possible for 2 bytes chars it will split in half leading to incorrect unicode sequence. Attached patch resolves the issue, however crash still can occur if p >= text, however as p is substring of text, the situation is expected to never happen in normal conditions. I found no safe analog in gtk functions for strlcpy, only strncpy which is not considered safe. The alternative is switch to icu, however this is another story. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #5 from Ivan --- xfce4-taskmanager-Message: /usr/local/libexec/xfce4/panel-plugins/xfce4-xkb-plugin 8 18874411 xkb-plugin Раскладки клавиатуры Настройка и переключение клавиатурных раскладок xfce4-taskmanager-Message: xfce4-xkb-plugin xfce4-taskmanager-Message: xfce4-xkb-plugin 8 18874411 xkb-plugin Раскладки клавиатуры Настройка и переключение клавиатур\xd0 Ошибка сегментации(core dumped) See \xd0 after task->cmdline and task->name passed to pretty_cmdline() pretty_cmdline() can generate invalid utf-8 sequence (cutting 2-byte chars on half?). -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #4 from Olivier Duchateau --- (In reply to Ivan from comment #3) I try with ru_RU.UTF-8 and xfce4-taskmanager does not crash. Tested on my 11.0-RC2 machine, where default encoding is fr_FR.UTF-8, and 9.3-RELEASE where encoding is fr_FR.ISO8859-15. Everything is fine. Sometimes encoding can cause crash (on my 9.3-RELEASE machine, xfce4-screenshooter-plugin is broken). -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #3 from Ivan --- https://git.xfce.org/apps/xfce4-taskmanager/tree/src/task-manager.c#n184 According code and considering bug occurs only when X started with LANG env, I think something bad passed to tree. I use almost pure xfce, so can you try LANG=ru_RU.UTF-8 to see if it's reproducible on your system? If not, I'll try to instrument it with some debug code. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Comment #2 from Ivan --- This problem occurs when ru_RU.UTF-8 used. I have no problems with en_GB.UTF-8 or C. env LANG=ru_RU.UTF-8 xfce4-taskmanager works as well, only when entire X session is started with LANG var. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 Olivier Duchateau changed: What|Removed |Added Status|New |Open CC||olivi...@freebsd.org --- Comment #1 from Olivier Duchateau --- I'm using FreeBSD 11-RC2 and xfce4-taskmanager works fine. I use the binary package from the latest repository. -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
maintainer-feedback requested: [Bug 212176] x11/xfce4-taskmanager segfault
Ivan has reassigned Bugzilla Automation 's request for maintainer-feedback to x...@freebsd.org: Bug 212176: x11/xfce4-taskmanager segfault https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 --- Description --- I'm setting laptop with FreeBSD and xfce. However, taskmnager is crashing immediately after start. I tried GTK2 and GTK3 option. FreeBSD 11-RC1 Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 80a416000 (LWP 101105/xfce4-taskmanager)] 0x0008037f7a5f in strlen () from /lib/libc.so.7 (gdb) bt #0 0x0008037f7a5f in strlen () from /lib/libc.so.7 #1 0x0008037c6ca2 in strcoll_l () from /lib/libc.so.7 #2 0x000802b16ee9 in g_utf8_collate () from /usr/local/lib/libglib-2.0.so.0 #3 0x000800e3a8b8 in _gtk_tree_data_list_compare_func () from /usr/local/lib/libgtk-x11-2.0.so.0 #4 0x000800d53ed5 in gtk_list_store_insert_with_values () from /usr/local/lib/libgtk-x11-2.0.so.0 #5 0x000800d52687 in gtk_list_store_set_valuesv () from /usr/local/lib/libgtk-x11-2.0.so.0 #6 0x000800d52833 in gtk_list_store_set_valist () from /usr/local/lib/libgtk-x11-2.0.so.0 #7 0x000800d52cbb in gtk_list_store_set () from /usr/local/lib/libgtk-x11-2.0.so.0 #8 0x00413f05 in model_add_task () #9 0x00413791 in xtm_task_manager_update_model () #10 0x00409a5e in init_timeout () #11 0x004094a7 in main () ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
[Bug 212176] x11/xfce4-taskmanager segfault
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212176 Bug ID: 212176 Summary: x11/xfce4-taskmanager segfault Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: x...@freebsd.org Reporter: b...@abinet.ru Flags: maintainer-feedback?(x...@freebsd.org) Assignee: x...@freebsd.org I'm setting laptop with FreeBSD and xfce. However, taskmnager is crashing immediately after start. I tried GTK2 and GTK3 option. FreeBSD 11-RC1 Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 80a416000 (LWP 101105/xfce4-taskmanager)] 0x0008037f7a5f in strlen () from /lib/libc.so.7 (gdb) bt #0 0x0008037f7a5f in strlen () from /lib/libc.so.7 #1 0x0008037c6ca2 in strcoll_l () from /lib/libc.so.7 #2 0x000802b16ee9 in g_utf8_collate () from /usr/local/lib/libglib-2.0.so.0 #3 0x000800e3a8b8 in _gtk_tree_data_list_compare_func () from /usr/local/lib/libgtk-x11-2.0.so.0 #4 0x000800d53ed5 in gtk_list_store_insert_with_values () from /usr/local/lib/libgtk-x11-2.0.so.0 #5 0x000800d52687 in gtk_list_store_set_valuesv () from /usr/local/lib/libgtk-x11-2.0.so.0 #6 0x000800d52833 in gtk_list_store_set_valist () from /usr/local/lib/libgtk-x11-2.0.so.0 #7 0x000800d52cbb in gtk_list_store_set () from /usr/local/lib/libgtk-x11-2.0.so.0 #8 0x00413f05 in model_add_task () #9 0x00413791 in xtm_task_manager_update_model () #10 0x00409a5e in init_timeout () #11 0x004094a7 in main () -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
