[Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223937

Guido Falsi  changed:

   What|Removed |Added

  Flags|maintainer-feedback?(xfce@F |maintainer-feedback+
   |reeBSD.org) |
   Assignee|x...@freebsd.org|madpi...@freebsd.org
 CC||madpi...@freebsd.org
 Status|New |In Progress

--- Comment #1 from Guido Falsi  ---
Hi,

Thanks for the patch.

Just to make sure I understand correctly, the "recent upstream changes" are in
the GTK3 sources?

Since you are sending this upstream too, could you followup with a link to the
upstream bug so it can be tracked? It would allow avoiding to commit patches
different from what is accepted upstream.

In the while I'll also test it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

[Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223937

Bug ID: 223937
   Summary: [patch] sysutils/xfce4-wavelan-plugin fix memory leak
due to CSS changes
   Product: Ports & Packages
   Version: Latest
  Hardware: Any
OS: Any
Status: New
  Keywords: patch
  Severity: Affects Many People
  Priority: ---
 Component: Individual Port(s)
  Assignee: x...@freebsd.org
  Reporter: f...@opal.com
  Keywords: patch
 Flags: maintainer-feedback?(x...@freebsd.org)
  Assignee: x...@freebsd.org

Created attachment 188351
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188351&action=edit
patch to fix memory leak due to Gtk3 CSS changes

The recent upstream changes to support Gtk3 CSS introduce a rampant memory leak
because the css_provider is re-created every time through the loop.  Attached
patch ensures that the css_provider is only created once.

I am attaching a FreeBSD port patch as this memory leak is significant and
needs an immediate fix.

I will also submit a bug report upstream in order to have this problem fixed
there, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

maintainer-feedback requested: [Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes

[bugzilla-noreply]

J.R. Oldroyd  has reassigned Bugzilla Automation
's request for maintainer-feedback to x...@freebsd.org:
Bug 223937: [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS
changes
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223937



--- Description ---
Created attachment 188351
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188351&action=edit
patch to fix memory leak due to Gtk3 CSS changes

The recent upstream changes to support Gtk3 CSS introduce a rampant memory leak
because the css_provider is re-created every time through the loop.  Attached
patch ensures that the css_provider is only created once.

I am attaching a FreeBSD port patch as this memory leak is significant and
needs an immediate fix.

I will also submit a bug report upstream in order to have this problem fixed
there, too.
___
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

[package - 10amd64-default-ssp][sysutils/xfce4-wavelan-plugin] Failed for xfce4-wavelan-plugin-0.5.11_1 in build

[pkg-fallout]

You are receiving this mail as a port that you maintain
is failing to build on the FreeBSD package build server.
Please investigate the failure and submit a PR to fix
build.

Maintainer: x...@freebsd.org
Last committer: olivi...@freebsd.org
Ident:  $FreeBSD: head/sysutils/xfce4-wavelan-plugin/Makefile 354754 
2014-05-21 17:21:38Z olivierd $
Log URL:
http://beefy4.isc.freebsd.org/data/10amd64-default-ssp/2014-10-12_14h21m47s/logs/xfce4-wavelan-plugin-0.5.11_1.log
Build URL:  
http://beefy4.isc.freebsd.org/build.html?mastername=10amd64-default-ssp&build=2014-10-12_14h21m47s
Log:

>> Building sysutils/xfce4-wavelan-plugin
build started at Mon Oct 13 03:19:27 UTC 2014
port directory: /usr/ports/sysutils/xfce4-wavelan-plugin
building for: FreeBSD pkg.FreeBSD.org 10.0-RELEASE-p3 FreeBSD 10.0-RELEASE-p3 
amd64
maintained by: x...@freebsd.org
Makefile ident:  $FreeBSD: head/sysutils/xfce4-wavelan-plugin/Makefile 
354754 2014-05-21 17:21:38Z olivierd $
Poudriere version: 3.1-pre
Host OSVERSION: 1100027
Jail OSVERSION: 1000510

---Begin Environment---
OSVERSION=1000510
UNAME_v=FreeBSD 10.0-RELEASE-p3
UNAME_r=10.0-RELEASE-p3
BLOCKSIZE=K
MAIL=/var/mail/root
STATUS=1
SAVED_TERM=
MASTERMNT=/usr/local/poudriere/data/.m/10amd64-default-ssp/ref
PKG_EXT=txz
FORCE_PACKAGE=yes
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
POUDRIERE_BUILD_TYPE=bulk
PKGNG=1
PKGNAME=xfce4-wavelan-plugin-0.5.11_1
PKG_DELETE=/usr/local/sbin/pkg-static delete -y -f
PKG_ADD=/usr/local/sbin/pkg-static add
OLDPWD=/root
PWD=/usr/local/poudriere/data/.m/10amd64-default-ssp/ref/.p/pool
MASTERNAME=10amd64-default-ssp
USER=root
HOME=/root
POUDRIERE_VERSION=3.1-pre
LOCALBASE=/usr/local
PACKAGE_BUILDING=yes
PKG_VERSION=/.p/pkg-static version
PKG_BIN=/usr/local/sbin/pkg-static
---End Environment---

---Begin OPTIONS List---
---End OPTIONS List---

--CONFIGURE_ARGS--
--prefix=/usr/local ${_LATE_CONFIGURE_ARGS}
--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work TMPDIR="/tmp" 
PKG_CONFIG=pkgconf MAKE=gmake SHELL=/bin/sh CONFIG_SHELL=/bin/sh CPPFLAGS=" 
-I/usr/local/include -L/usr/local/lib"  ac_cv_prog_AWK="/usr/bin/awk"   
ac_cv_prog_AWK="/usr/bin/awk"   ac_cv_prog_AWK="/usr/bin/awk"   
ac_cv_prog_AWK="/usr/bin/awk" 
PATH=/usr/local/libexec/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
 CCACHE_DIR="/root/.ccache" CONFIG_SITE=/usr/ports/Templates/config.site 
lt_cv_sys_max_cmd_len=262144
--End CONFIGURE_ENV--

--MAKE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work TMPDIR="/tmp" 
NO_PIE=yes SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local  LOCALBASE=/usr/local  
LIBDIR="/usr/lib"  CC="cc" CFLAGS="-O2 -pipe -fstack-protector 
-fno-strict-aliasing"  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -fstack-protector" 
LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector -fno-strict-aliasing"  
MANPREFIX="/usr/local" 
PATH=/usr/local/libexec/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
 CCACHE_DIR="/root/.ccache" BSD_INSTALL_PROGRAM="install  -s -o root -g wheel 
-m 555"  BSD_INSTALL_LIB="install  -s -o root -g wheel -m 444"  
BSD_INSTALL_SCRIPT="install  -o root -g wheel -m 555"  
BSD_INSTALL_DATA="install  -o root -g wheel -m 0644"  BSD_INSTALL_MAN="install  
-o root -g wheel -m 444"
--End MAKE_ENV--

--PLIST_SUB--
OSREL=10.0
PREFIX=%D
LOCALBASE=/usr/local
RESETPREFIX=/usr/local
PORTDOCS=""
PORTEXAMPLES=""
LIB32DIR=lib
GTK2_VERSION="2.10.0"
GTK3_VERSION="3.0.0"
DOCSDIR="share/doc/xfce4-wavelan-plugin"
EXAMPLESDIR="share/examples/xfce4-wavelan-plugin"
DATADIR="share/xfce4-wavelan-plugin"
WWWDIR="www/xfce4-wavelan-plugin"
ETCDIR="etc/xfce4-wavelan-plugin"
--End PLIST_SUB--

--SUB_LIST--
PREFIX=/usr/local
LOCALBASE=/usr/local
DATADIR=/usr/local/share/xfce4-wavelan-plugin
DOCSDIR=/usr/local/share/doc/xfce4-wavelan-plugin
EXAMPLESDIR=/usr/local/share/examples/xfce4-wavelan-plugin
WWWDIR=/usr/local/www/xfce4-wavelan-plugin
ETCDIR=/usr/local/etc/xfce4-wavelan-plugin
--End SUB_LIST--

---Begin make.conf---
USE_PACKAGE_DEPENDS=yes
BATCH=yes
WRKDIRPREFIX=/wrkdirs
WITH_CCACHE_BUI

[package - 10amd64-default-ssp][sysutils/xfce4-wavelan-plugin] Failed for xfce4-wavelan-plugin-0.5.11_1 in build

[pkg-fallout]

You are receiving this mail as a port that you maintain
is failing to build on the FreeBSD package build server.
Please investigate the failure and submit a PR to fix
build.

Maintainer: x...@freebsd.org
Last committer: olivi...@freebsd.org
Ident:  $FreeBSD: head/sysutils/xfce4-wavelan-plugin/Makefile 354754 
2014-05-21 17:21:38Z olivierd $
Log URL:
http://beefy4.isc.freebsd.org/data/10amd64-default-ssp/2014-07-25_21h51m15s/logs/xfce4-wavelan-plugin-0.5.11_1.log
Build URL:  
http://beefy4.isc.freebsd.org/build.html?mastername=10amd64-default-ssp&build=2014-07-25_21h51m15s
Log:

>> Building sysutils/xfce4-wavelan-plugin
build started at Sat Jul 26 10:54:15 UTC 2014
port directory: /usr/ports/sysutils/xfce4-wavelan-plugin
building for: FreeBSD pkg.FreeBSD.org 10.0-RELEASE-p3 FreeBSD 10.0-RELEASE-p3 
amd64
maintained by: x...@freebsd.org
Makefile ident:  $FreeBSD: head/sysutils/xfce4-wavelan-plugin/Makefile 
354754 2014-05-21 17:21:38Z olivierd $
Poudriere version: 3.1-pre
Host OSVERSION: 1100027
Jail OSVERSION: 1000510

---Begin Environment---
OSVERSION=1000510
UNAME_v=FreeBSD 10.0-RELEASE-p3
UNAME_r=10.0-RELEASE-p3
BLOCKSIZE=K
MAIL=/var/mail/root
STATUS=1
SAVED_TERM=
MASTERMNT=/usr/local/poudriere/data/.m/10amd64-default-ssp/ref
PKG_EXT=txz
FORCE_PACKAGE=yes
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
POUDRIERE_BUILD_TYPE=bulk
PKGNG=1
PKGNAME=xfce4-wavelan-plugin-0.5.11_1
PKG_DELETE=/usr/local/sbin/pkg-static delete -y -f
PKG_ADD=/usr/local/sbin/pkg-static add
OLDPWD=/root
PWD=/usr/local/poudriere/data/.m/10amd64-default-ssp/ref/.p/pool
MASTERNAME=10amd64-default-ssp
USER=root
HOME=/root
POUDRIERE_VERSION=3.1-pre
LOCALBASE=/usr/local
PACKAGE_BUILDING=yes
PKG_VERSION=/.p/pkg-static version
PKG_BIN=/usr/local/sbin/pkg-static
---End Environment---

---Begin OPTIONS List---
---End OPTIONS List---

--CONFIGURE_ARGS--
--prefix=/usr/local ${_LATE_CONFIGURE_ARGS}
--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work TMPDIR="/tmp" 
PKG_CONFIG=pkgconf MAKE=gmake SHELL=/bin/sh CONFIG_SHELL=/bin/sh CPPFLAGS=" 
-I/usr/local/include -L/usr/local/lib"  ac_cv_prog_AWK="/usr/bin/awk"   
ac_cv_prog_AWK="/usr/bin/awk"   ac_cv_prog_AWK="/usr/bin/awk"   
ac_cv_prog_AWK="/usr/bin/awk" 
PATH=/usr/local/libexec/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
 CCACHE_DIR="/root/.ccache" CONFIG_SITE=/usr/ports/Templates/config.site 
lt_cv_sys_max_cmd_len=262144
--End CONFIGURE_ENV--

--MAKE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
XDG_CONFIG_HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work  
HOME=/wrkdirs/usr/ports/sysutils/xfce4-wavelan-plugin/work TMPDIR="/tmp" 
NO_PIE=yes SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local  LOCALBASE=/usr/local  
LIBDIR="/usr/lib"  CC="cc" CFLAGS="-O2 -pipe -fstack-protector 
-fno-strict-aliasing"  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -fstack-protector" 
LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector -fno-strict-aliasing"  
MANPREFIX="/usr/local" 
PATH=/usr/local/libexec/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
 CCACHE_DIR="/root/.ccache" BSD_INSTALL_PROGRAM="install  -s -o root -g wheel 
-m 555"  BSD_INSTALL_LIB="install  -s -o root -g wheel -m 444"  
BSD_INSTALL_SCRIPT="install  -o root -g wheel -m 555"  
BSD_INSTALL_DATA="install  -o root -g wheel -m 444"  BSD_INSTALL_MAN="install  
-o root -g wheel -m 444"
--End MAKE_ENV--

--PLIST_SUB--
OSREL=10.0
PREFIX=%D
LOCALBASE=/usr/local
PORTDOCS=""
PORTEXAMPLES=""
PORTDATA=""
LIB32DIR=lib
GTK2_VERSION="2.10.0"
GTK3_VERSION="3.0.0"
DOCSDIR="share/doc/xfce4-wavelan-plugin"
EXAMPLESDIR="share/examples/xfce4-wavelan-plugin"
DATADIR="share/xfce4-wavelan-plugin"
WWWDIR="www/xfce4-wavelan-plugin"
ETCDIR="etc/xfce4-wavelan-plugin"
--End PLIST_SUB--

--SUB_LIST--
PREFIX=/usr/local
LOCALBASE=/usr/local
DATADIR=/usr/local/share/xfce4-wavelan-plugin
DOCSDIR=/usr/local/share/doc/xfce4-wavelan-plugin
EXAMPLESDIR=/usr/local/share/examples/xfce4-wavelan-plugin
WWWDIR=/usr/local/www/xfce4-wavelan-plugin
ETCDIR=/usr/local/etc/xfce4-wavelan-plugin
--End SUB_LIST--

---Begin make.conf---
USE_PACKAGE_DEPENDS=yes
BATCH=yes
WRKDIRPREFIX=/wrkdirs
WITH_CCACHE_BUILD=yes
CCACHE_DIR=/root/.ccache
USE_PACKAGE_DEPENDS=yes
BATCH=yes
WRKDIRPREFIX=/wrkdirs
PORTSDIR=/usr/ports
PACKAGES=/packages
DISTDIR=/distfiles
 /usr/local/etc/poudriere.d/make.

Re: sysutils/xfce4-wavelan-plugin

[J.R. Oldroyd]

On Tue, 20 May 2014 22:16:25 +0200 Olivier Duchateau 
 wrote:
>
> Patch [1] is it ok?
> I removed __FreeBSD_kernel_version macro, because FreeBSD <= 7.x is
> not anymore supported.
> 
> [1] https://people.freebsd.org/~olivierd/patches/xfce4-wavelan-plugin.diff
> 

Oui, il se compile et tourne comme il faut.  Et, c'est beaucoup plus
clair maintenant avec tes changements des ifdefs.

Merci !
-jr


signature.asc
Description: PGP signature

Re: sysutils/xfce4-wavelan-plugin

[Olivier Duchateau]

2014-05-16 18:52 GMT+02:00 J.R. Oldroyd :
> On Fri, 16 May 2014 18:31:04 +0200 Olivier Duchateau 
>  wrote:
>>
>> Thanks you for your help.
>>
> You're welcome.  Feel free to upstream these changes.
>
>> Check of kernel version is used for Debian GNU/kFreeBSD port (I know
>> it's overkill).
>>
> I won't touch that for now, then, although I do think it would be cleaner
> to check the kernel version once at the top, then use plain __FreeBSD__
> and __FreeBSD_version throughout the rest.
>
> And __FreeBSD_kernel_kernel__??  That can't be right.
>
> -jr
>
>

Patch [1] is it ok?
I removed __FreeBSD_kernel_version macro, because FreeBSD <= 7.x is
not anymore supported.

[1] https://people.freebsd.org/~olivierd/patches/xfce4-wavelan-plugin.diff

-- 
olivier
___
freebsd-xfce@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

Re: sysutils/xfce4-wavelan-plugin

[J.R. Oldroyd]

On Fri, 16 May 2014 18:31:04 +0200 Olivier Duchateau 
 wrote:
>
> Thanks you for your help.
> 
You're welcome.  Feel free to upstream these changes.
 
> Check of kernel version is used for Debian GNU/kFreeBSD port (I know
> it's overkill).
> 
I won't touch that for now, then, although I do think it would be cleaner
to check the kernel version once at the top, then use plain __FreeBSD__
and __FreeBSD_version throughout the rest.

And __FreeBSD_kernel_kernel__??  That can't be right.

-jr




signature.asc
Description: PGP signature

Re: sysutils/xfce4-wavelan-plugin

[Olivier Duchateau]

2014-05-16 18:03 GMT+02:00 J.R. Oldroyd :
> sysutils/xfce4-wavelan-plugin no longer works.
>
> Looking at the code, there are various problems.  It looks for a sysctl
> oid that doesn't exist, it returns the interface rssi value instead of
> properly calculating the signal quality, it uses that incorrect rssi
> value also as the signal percentage, but worse... all the FreeBSD code
> is compiled out anyway due to tests for FreeBSD_version being done before
> sys/param.h is included!!
>
> I've posted two patches (URLs below) that fix these problems and make it
> work again.  I also fix the percentage values at which the color changes,
> I use 25%, 50% and 75% instead of the strange values 40%, 55% and 70% that
> are there now.
>
> I've named these files extra-patch-foo for now, but they should be renamed
> to patch-foo and merged in with the existing patches already there.
>
> The code in wi_bsd.c is a mess!  There is no need to be using the kernel
> values __FreeBSD_kernel__ or __FreeBSD_kernel_version here or even
> __FreeBSD_kernel_kernel__ (yes, really)!  I didn't clean that stuff up
> with this patch, but if desired, I can do so.  Maybe there's a reason
> it's like this?
>
> -jr
>
> http://opal.com/jr/freebsd/ports/sysutils/xfce4-wavelan-plugin/extra-patch-panel-plugin__wavelan.c
> http://opal.com/jr/freebsd/ports/sysutils/xfce4-wavelan-plugin/extra-patch-panel-plugin__wi_bsd.c

Thanks you for your help.
When I upgraded this plugin, I removed some old code too [1], but
development seems to stop.

As I don't use this plugin, so I didn't notice odd behaviour of percentage.

Check of kernel version is used for Debian GNU/kFreeBSD port (I know
it's overkill).

[1] https://bugzilla.xfce.org/show_bug.cgi?id=8833

-- 
olivier
___
freebsd-xfce@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

sysutils/xfce4-wavelan-plugin

[J.R. Oldroyd]

sysutils/xfce4-wavelan-plugin no longer works.

Looking at the code, there are various problems.  It looks for a sysctl
oid that doesn't exist, it returns the interface rssi value instead of
properly calculating the signal quality, it uses that incorrect rssi
value also as the signal percentage, but worse... all the FreeBSD code
is compiled out anyway due to tests for FreeBSD_version being done before
sys/param.h is included!!

I've posted two patches (URLs below) that fix these problems and make it
work again.  I also fix the percentage values at which the color changes,
I use 25%, 50% and 75% instead of the strange values 40%, 55% and 70% that
are there now.

I've named these files extra-patch-foo for now, but they should be renamed
to patch-foo and merged in with the existing patches already there.

The code in wi_bsd.c is a mess!  There is no need to be using the kernel
values __FreeBSD_kernel__ or __FreeBSD_kernel_version here or even
__FreeBSD_kernel_kernel__ (yes, really)!  I didn't clean that stuff up
with this patch, but if desired, I can do so.  Maybe there's a reason
it's like this?

-jr

http://opal.com/jr/freebsd/ports/sysutils/xfce4-wavelan-plugin/extra-patch-panel-plugin__wavelan.c
http://opal.com/jr/freebsd/ports/sysutils/xfce4-wavelan-plugin/extra-patch-panel-plugin__wi_bsd.c


signature.asc
Description: PGP signature