Fwd: vendorinfo file
Oh Google, why Reply to all isn't the default? Forwarding to the mailing list -- Forwarded message -- From: Rostislav Krasny rosti@gmail.com Date: Tue, Nov 5, 2013 at 10:48 AM Subject: Re: vendorinfo file To: Olivier Duchateau duchateau.oliv...@gmail.com On Tue, Nov 5, 2013 at 8:10 AM, Olivier Duchateau duchateau.oliv...@gmail.com wrote: 2013/11/5 Rostislav Krasny rosti@gmail.com: On Tue, Nov 5, 2013 at 12:45 AM, Rostislav Krasny rosti@gmail.com wrote: On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau See commit log, here http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 See the full version of this file. If the VENDOR_INFO macro isn't defined, all that vendor specified code is disabled. http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems to be defined only when '--with-vendor-info' is used with some not empty value. Finally I tested it by changes attached in the libxfce4menu.diff file. After this change the xfce4-about program shows no vendor information (neither vendor name in the version text nor vendor tab) and doesn't print any warning in the console it is ran from. I don't insist in this change. If you want to keep '--with-vendor-info=FreeBSD' and to add some vendorinfo file with FreeBSD about and advertising information, it would be nice too. Just make a choice. I disagree with you, new tab will be created if length of file is greater than zero. If file doesn't exists or is empty nothing append (see xfce_about_vendor() function). --with-vendor-info=FreeBSD is used in main() function (from line 482) as xfce_about_vendor() doesn't initialize new tab, OS is only display. Yes you're right. I probably tested it with a file containing only a newline. Anyway the '--with-vendor-info=FreeBSD' seems to be unnecessary. You explained it as a workaround and my patch shows that no such workaround is needed. If you don't want the vendor tab with some appropriate text to appear in the xfce4-about, it's better to disable it completely than making an empty file that nobody really needs. ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
Re: vendorinfo file
2013/11/4 Rostislav Krasny rosti@gmail.com: Hi, I've noticed that 'xfce4-about' looks for the /usr/local/share/xfce4/vendorinfo file. If it's missed a warning message is printed in console: xfce4-about-Message: No vendor information found in /usr/local/share/xfce4/vendorinfo. It's odd x11/libxfce4menu is precisely compilled with option --with-vendor-info=FreeBSD It's an workaround, if we can't provide vendor info file. I know some Linux distros do same thing. I've never had this message in my log session. If this file exists then there is an additional tab (FreeBSD tab) in the xfce4-about window and content of the vendorinfo file is printed there. Is it a known feature? It seems to be added in the upstream 3 years ago by following commit: http://mail.xfce.org/pipermail/xfce4-commits/2010-November/013752.html I think some about and/or other FreeBSD advertising information could be put into that file. What do you think? Why not, but which file ? ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org -- olivier ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
Re: vendorinfo file
On Mon, Nov 4, 2013 at 9:59 PM, Olivier Duchateau duchateau.oliv...@gmail.com wrote: 2013/11/4 Rostislav Krasny rosti@gmail.com: Hi, I've noticed that 'xfce4-about' looks for the /usr/local/share/xfce4/vendorinfo file. If it's missed a warning message is printed in console: xfce4-about-Message: No vendor information found in /usr/local/share/xfce4/vendorinfo. It's odd x11/libxfce4menu is precisely compilled with option --with-vendor-info=FreeBSD It's an workaround, if we can't provide vendor info file. I know some Linux distros do same thing. I'm not familiar with autoconfig scripts, but is this workaround still necessary? According to following code chunk taken from http://git.xfce.org/archive/xfce-utils/tree/configure.in.in eliminating the --with-vendor-info script argument will make VENDOR_INFO undefined AC_ARG_WITH([vendor-info], AC_HELP_STRING([--with-vendor-info=NAME], [Specify an additional vendor name, optionally with a file in prefix/share/xfce4/NAME]), [with_vendor_info=$withval], [with_vendor_info=]) if test x$with_vendor_info != x; then AC_DEFINE_UNQUOTED([VENDOR_INFO], [$with_vendor_info], [Additional vendor name and/or info]) AC_MSG_RESULT([$vendorinfo]) else AC_MSG_RESULT([not set]) fi Then xfce4-about (in its main.c) will not look for any vendorinfo file and will show only xfce version without any vendor name. http://git.xfce.org/archive/xfce-utils/tree/xfce4-about/main.c I've never had this message in my log session. I see it in the console from wich I run startxfce4 If this file exists then there is an additional tab (FreeBSD tab) in the xfce4-about window and content of the vendorinfo file is printed there. Is it a known feature? It seems to be added in the upstream 3 years ago by following commit: http://mail.xfce.org/pipermail/xfce4-commits/2010-November/013752.html I think some about and/or other FreeBSD advertising information could be put into that file. What do you think? Why not, but which file ? The /usr/local/share/xfce4/vendorinfo file. Or did you ask what to write there? ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
Re: vendorinfo file
2013/11/4 Rostislav Krasny rosti@gmail.com: On Mon, Nov 4, 2013 at 9:59 PM, Olivier Duchateau duchateau.oliv...@gmail.com wrote: 2013/11/4 Rostislav Krasny rosti@gmail.com: Hi, I've noticed that 'xfce4-about' looks for the /usr/local/share/xfce4/vendorinfo file. If it's missed a warning message is printed in console: xfce4-about-Message: No vendor information found in /usr/local/share/xfce4/vendorinfo. It's odd x11/libxfce4menu is precisely compilled with option --with-vendor-info=FreeBSD It's an workaround, if we can't provide vendor info file. I know some Linux distros do same thing. I'm not familiar with autoconfig scripts, but is this workaround still necessary? According to following code chunk taken from http://git.xfce.org/archive/xfce-utils/tree/configure.in.in It's wrong file, xfce-utils is deprecated (located in archive folder). xfce4-about code now belongs to libxfce4ui (libxfce4menu in your ports tree). eliminating the --with-vendor-info script argument will make VENDOR_INFO undefined AC_ARG_WITH([vendor-info], AC_HELP_STRING([--with-vendor-info=NAME], [Specify an additional vendor name, optionally with a file in prefix/share/xfce4/NAME]), [with_vendor_info=$withval], [with_vendor_info=]) if test x$with_vendor_info != x; then AC_DEFINE_UNQUOTED([VENDOR_INFO], [$with_vendor_info], [Additional vendor name and/or info]) AC_MSG_RESULT([$vendorinfo]) else AC_MSG_RESULT([not set]) fi Then xfce4-about (in its main.c) will not look for any vendorinfo file and will show only xfce version without any vendor name. http://git.xfce.org/archive/xfce-utils/tree/xfce4-about/main.c I've never had this message in my log session. I see it in the console from wich I run startxfce4 To avoid this message create an empty file like this: touch /usr/local/share/xfce4/vendorinfo See commit log, here http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 If this file exists then there is an additional tab (FreeBSD tab) in the xfce4-about window and content of the vendorinfo file is printed there. Is it a known feature? It seems to be added in the upstream 3 years ago by following commit: http://mail.xfce.org/pipermail/xfce4-commits/2010-November/013752.html I think some about and/or other FreeBSD advertising information could be put into that file. What do you think? Why not, but which file ? The /usr/local/share/xfce4/vendorinfo file. Or did you ask what to write there? -- olivier ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
Re: vendorinfo file
On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau duchateau.oliv...@gmail.com wrote: 2013/11/4 Rostislav Krasny rosti@gmail.com: I'm not familiar with autoconfig scripts, but is this workaround still necessary? According to following code chunk taken from http://git.xfce.org/archive/xfce-utils/tree/configure.in.in It's wrong file, xfce-utils is deprecated (located in archive folder). xfce4-about code now belongs to libxfce4ui (libxfce4menu in your ports tree). libxfce4ui/tree/configure.ac.in has the same code with the same logic. Take a look on this: http://git.xfce.org/xfce/libxfce4ui/tree/configure.ac.in I've never had this message in my log session. I see it in the console from wich I run startxfce4 To avoid this message create an empty file like this: touch /usr/local/share/xfce4/vendorinfo It will make an empty and unneeded tab named FreeBSD. If you want to keep the vendor information, it's better to write something about FreeBSD in that file (i.e. in that tab). See commit log, here http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 See the full version of this file. If the VENDOR_INFO macro isn't defined, all that vendor specified code is disabled. http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems to be defined only when '--with-vendor-info' is used with some not empty value. ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
Re: vendorinfo file
2013/11/5 Rostislav Krasny rosti@gmail.com: On Tue, Nov 5, 2013 at 12:45 AM, Rostislav Krasny rosti@gmail.com wrote: On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau See commit log, here http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 See the full version of this file. If the VENDOR_INFO macro isn't defined, all that vendor specified code is disabled. http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems to be defined only when '--with-vendor-info' is used with some not empty value. Finally I tested it by changes attached in the libxfce4menu.diff file. After this change the xfce4-about program shows no vendor information (neither vendor name in the version text nor vendor tab) and doesn't print any warning in the console it is ran from. I don't insist in this change. If you want to keep '--with-vendor-info=FreeBSD' and to add some vendorinfo file with FreeBSD about and advertising information, it would be nice too. Just make a choice. I disagree with you, new tab will be created if length of file is greater than zero. If file doesn't exists or is empty nothing append (see xfce_about_vendor() function). --with-vendor-info=FreeBSD is used in main() function (from line 482) as xfce_about_vendor() doesn't initialize new tab, OS is only display. -- olivier ___ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to freebsd-xfce-unsubscr...@freebsd.org
