Author: sveinung Date: Fri Jul 15 13:32:04 2016 New Revision: 33252 URL: http://svn.gna.org/viewcvs/freeciv?rev=33252&view=rev Log: Make action probability a range.
In some cases the player may know enough to predict the range the action probability will be in even when the exact probability of success is unknown. Making action probability a range allows it to be sent. In some cases the probability of success can't be expressed as X * 0.5%. Rounding it wrong can cause problems. Example: bug #24802 was caused by a low probability being rounded to 0. 0 was seen as disabled. Making action probability a range allows the completely unknown action probability to become the regular value [0%, 100%]. See patch #7238 Modified: branches/S2_6/client/climisc.c branches/S2_6/client/gui-gtk-2.0/action_dialog.c branches/S2_6/client/gui-gtk-3.0/action_dialog.c branches/S2_6/client/gui-qt/dialogs.cpp branches/S2_6/client/gui-sdl/action_dialog.c branches/S2_6/client/gui-sdl2/action_dialog.c branches/S2_6/client/gui-stub/dialogs.c branches/S2_6/client/gui-xaw/action_dialog.c branches/S2_6/client/include/dialogs_g.h branches/S2_6/client/packhand.c branches/S2_6/common/actions.c branches/S2_6/common/actions.h branches/S2_6/common/dataio.c branches/S2_6/common/dataio.h branches/S2_6/common/fc_types.h branches/S2_6/common/packets.def branches/S2_6/common/unit.h branches/S2_6/fc_version branches/S2_6/server/unithand.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/S2_6/client/climisc.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/climisc.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-gtk-2.0/action_dialog.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-gtk-2.0/action_dialog.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-gtk-3.0/action_dialog.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-gtk-3.0/action_dialog.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-qt/dialogs.cpp URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-qt/dialogs.cpp?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-sdl/action_dialog.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-sdl/action_dialog.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-sdl2/action_dialog.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-sdl2/action_dialog.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-stub/dialogs.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-stub/dialogs.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/gui-xaw/action_dialog.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/gui-xaw/action_dialog.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/include/dialogs_g.h URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/include/dialogs_g.h?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/client/packhand.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/client/packhand.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/actions.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/actions.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/actions.h URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/actions.h?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/dataio.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/dataio.c?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/dataio.h URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/dataio.h?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/fc_types.h URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/fc_types.h?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/packets.def URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/packets.def?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/common/unit.h URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/common/unit.h?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/fc_version URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/fc_version?rev=33252&r1=33251&r2=33252&view=diff Modified: branches/S2_6/server/unithand.c URL: http://svn.gna.org/viewcvs/freeciv/branches/S2_6/server/unithand.c?rev=33252&r1=33251&r2=33252&view=diff _______________________________________________ Freeciv-commits mailing list Freeciv-commits@gna.org https://mail.gna.org/listinfo/freeciv-commits