[Freeciv-commits] r34274 - /trunk/server/unittools.c

2016-10-28 Thread sveinung84
Author: sveinung Date: Fri Oct 28 15:15:02 2016 New Revision: 34274 URL: http://svn.gna.org/viewcvs/freeciv?rev=34274&view=rev Log: order execution: prepare for > 1 found city. Get a city name if the action results in city founding rather than if its action id matches found city. See patch #7882

[Freeciv-commits] r34276 - in /trunk: server/ruleset.c tools/ruleutil/rulesave.c

2016-10-28 Thread sveinung84
Author: sveinung Date: Fri Oct 28 15:15:58 2016 New Revision: 34276 URL: http://svn.gna.org/viewcvs/freeciv?rev=34276&view=rev Log: Reusable action auto performer's rs conversion. Action auto performers aren't fully exposed in the ruleset because their semantic still isn't set in stone (see patch

[Freeciv-commits] r34289 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplay...

2016-10-29 Thread sveinung84
Author: sveinung Date: Sat Oct 29 19:54:17 2016 New Revision: 34289 URL: http://svn.gna.org/viewcvs/freeciv?rev=34289&view=rev Log: Let the ruleset exclude units from autoattack. Let the ruleset specify one or more unit type flags that prevents a unit from autoattacking. Remove the hard coding th

[Freeciv-commits] r34298 - in /trunk: common/actions.h server/actiontools.c

2016-10-31 Thread sveinung84
Author: sveinung Date: Mon Oct 31 10:31:49 2016 New Revision: 34298 URL: http://svn.gna.org/viewcvs/freeciv?rev=34298&view=rev Log: Action auto performer action iterator macro. See patch #7892 Modified: trunk/common/actions.h trunk/server/actiontools.c Modified: trunk/common/actions.h U

[Freeciv-commits] r34310 - in /trunk/common: actions.c actions.h

2016-11-01 Thread sveinung84
Author: sveinung Date: Tue Nov 1 19:02:31 2016 New Revision: 34310 URL: http://svn.gna.org/viewcvs/freeciv?rev=34310&view=rev Log: Action fall back act_prob utility function. In some cases it is useful to get the probability of doing action A, or if action A can't be done, action B. Introduce ac

[Freeciv-commits] r34329 - in /trunk/client: gui-gtk-2.0/sprite.c gui-gtk-3.0/sprite.c gui-gtk-3.22/sprite.c gui-qt/sprite.cpp

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 15:24:32 2016 New Revision: 34329 URL: http://svn.gna.org/viewcvs/freeciv?rev=34329&view=rev Log: crop_sprite(): assert that source sprite exists. Assert the existence of the source sprite in the crop_sprite() implementation of the Qt client and of the GTK client

[Freeciv-commits] r34330 - /trunk/client/tilespec.c

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 15:25:22 2016 New Revision: 34330 URL: http://svn.gna.org/viewcvs/freeciv?rev=34330&view=rev Log: tilespec_reread(): initialize dependency first. The function tileset_player_init() falls back to sprites.background.color if the player doesn't have a color. But spr

[Freeciv-commits] r34331 - /trunk/client/options.c

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 15:26:23 2016 New Revision: 34331 URL: http://svn.gna.org/viewcvs/freeciv?rev=34331&view=rev Log: client: stop storing server topology choice. The function client_start_server() sets topology based on tileset. Its conclusions have ended up in most client setting

[Freeciv-commits] r34332 - /branches/S2_6/client/tilespec.c

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 15:27:35 2016 New Revision: 34332 URL: http://svn.gna.org/viewcvs/freeciv?rev=34332&view=rev Log: tilespec_reread(): initialize dependency first. The function tileset_player_init() falls back to sprites.background.color if the player doesn't have a color. But spr

[Freeciv-commits] r34333 - /branches/S2_6/client/options.c

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 15:28:07 2016 New Revision: 34333 URL: http://svn.gna.org/viewcvs/freeciv?rev=34333&view=rev Log: client: stop storing server topology choice. The function client_start_server() sets topology based on tileset. Its conclusions have ended up in most client setting

[Freeciv-commits] r34336 - in /trunk/server: actiontools.c actiontools.h

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 17:14:25 2016 New Revision: 34336 URL: http://svn.gna.org/viewcvs/freeciv?rev=34336&view=rev Log: Auto performer forced to act probability. Introduce action_auto_perf_unit_act_prob(). It returns the probability for the specified actor unit to be forced to perform

[Freeciv-commits] r34337 - in /trunk/common: actions.c actions.h

2016-11-02 Thread sveinung84
Author: sveinung Date: Wed Nov 2 17:15:31 2016 New Revision: 34337 URL: http://svn.gna.org/viewcvs/freeciv?rev=34337&view=rev Log: Add an action probability comparison function. Introduce action_prob_cmp_pessimist(). It compares two act_prob structs first by minimum probability and then by maxim

[Freeciv-commits] r34358 - /trunk/client/tilespec.c

2016-11-03 Thread sveinung84
Author: sveinung Date: Thu Nov 3 16:09:28 2016 New Revision: 34358 URL: http://svn.gna.org/viewcvs/freeciv?rev=34358&view=rev Log: tilesets: make the act dec want icon use offsets. Make the action_decision_want icon support activity offsets. See patch #7913 Modified: trunk/client/tilespec.

[Freeciv-commits] r34359 - /trunk/server/unittools.c

2016-11-03 Thread sveinung84
Author: sveinung Date: Thu Nov 3 16:09:45 2016 New Revision: 34359 URL: http://svn.gna.org/viewcvs/freeciv?rev=34359&view=rev Log: autoattack: consider the odds of all actions. An auto attack can result in "Capture Units", "Bombard" or "Attack". What unit tries to auto attack first is determined

[Freeciv-commits] r34357 - in /trunk/common: actions.c actions.h

2016-11-03 Thread sveinung84
Author: sveinung Date: Thu Nov 3 16:09:06 2016 New Revision: 34357 URL: http://svn.gna.org/viewcvs/freeciv?rev=34357&view=rev Log: Add an action probability to [0, 1] converter. Introduce action_prob_to_0_to_1_pessimist(). It converts an act_prob struct to a double from 0 to 1. When an action pr

[Freeciv-commits] r34383 - /trunk/server/actiontools.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:10:03 2016 New Revision: 34383 URL: http://svn.gna.org/viewcvs/freeciv?rev=34383&view=rev Log: actiontools: act perf acquire target to macro. The acquire target code for action_auto_perf_unit_sel() and action_auto_perf_unit_prob() is and should be identical. M

[Freeciv-commits] r34384 - /trunk/server/unittools.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:10:26 2016 New Revision: 34384 URL: http://svn.gna.org/viewcvs/freeciv?rev=34384&view=rev Log: autoattack: cargo attacks before transporters. The function compare_units() tried to make a cargo unit auto attack before its transporter by sorting the autoattacker

[Freeciv-commits] r34385 - /trunk/common/actions.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:10:44 2016 New Revision: 34385 URL: http://svn.gna.org/viewcvs/freeciv?rev=34385&view=rev Log: action_prob(): assert that act_prob is in range. See patch #7929 Modified: trunk/common/actions.c Modified: trunk/common/actions.c URL: http://svn.gna.org/vie

[Freeciv-commits] r34386 - /trunk/common/actions.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:10:56 2016 New Revision: 34386 URL: http://svn.gna.org/viewcvs/freeciv?rev=34386&view=rev Log: Keep attack action probability in range. Fix a rounding error that could result in "Attack"'s action probability to go outside the act_prob struct's range for non si

[Freeciv-commits] r34387 - /branches/S2_6/server/unittools.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:41:59 2016 New Revision: 34387 URL: http://svn.gna.org/viewcvs/freeciv?rev=34387&view=rev Log: autoattack: cargo attacks before transporters. The function compare_units() tried to make a cargo unit auto attack before its transporter by sorting the autoattacker

[Freeciv-commits] r34388 - /branches/S2_6/common/actions.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:42:08 2016 New Revision: 34388 URL: http://svn.gna.org/viewcvs/freeciv?rev=34388&view=rev Log: action_prob(): assert that act_prob is in range. See patch #7929 Modified: branches/S2_6/common/actions.c Modified: branches/S2_6/common/actions.c URL: http:/

[Freeciv-commits] r34389 - /branches/S2_5/server/unittools.c

2016-11-04 Thread sveinung84
Author: sveinung Date: Fri Nov 4 13:44:22 2016 New Revision: 34389 URL: http://svn.gna.org/viewcvs/freeciv?rev=34389&view=rev Log: autoattack: cargo attacks before transporters. The function compare_units() tried to make a cargo unit auto attack before its transporter by sorting the autoattacker

[Freeciv-commits] r34426 - in /trunk: ./ common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multip...

2016-11-06 Thread sveinung84
Author: sveinung Date: Mon Nov 7 01:00:09 2016 New Revision: 34426 URL: http://svn.gna.org/viewcvs/freeciv?rev=34426&view=rev Log: Introduce the new utype flag "Provoking". A unit considering if it should autoattack a unit that just moved next to it will normally decide not to attack if it has b

[Freeciv-commits] r34432 - /trunk/server/unittools.c

2016-11-07 Thread sveinung84
Author: sveinung Date: Mon Nov 7 13:42:27 2016 New Revision: 34432 URL: http://svn.gna.org/viewcvs/freeciv?rev=34432&view=rev Log: autoattack: have the best attacker go first. A unit will only auto attack if its probability of success is above a certain threshold. The threshold is currently 90%

[Freeciv-commits] r34433 - /branches/S2_6/server/unittools.c

2016-11-07 Thread sveinung84
Author: sveinung Date: Mon Nov 7 13:44:50 2016 New Revision: 34433 URL: http://svn.gna.org/viewcvs/freeciv?rev=34433&view=rev Log: autoattack: have the best attacker go first. A unit will only auto attack if its probability of success is above a certain threshold. The threshold is currently 90%

[Freeciv-commits] r34448 - /trunk/ai/default/aidiplomat.c

2016-11-08 Thread sveinung84
Author: sveinung Date: Wed Nov 9 02:38:22 2016 New Revision: 34448 URL: http://svn.gna.org/viewcvs/freeciv?rev=34448&view=rev Log: ai: any hostile unit != any hostile diplomat. Freeciv 3.0 has hostile enabler controlled actions that aren't diplomatic. The function is_city_surrounded_by_our_spies

[Freeciv-commits] r34460 - in /trunk/data: civ2civ3/ classic/ experimental/ multiplayer/ sandbox/ webperimental/

2016-11-09 Thread sveinung84
Author: sveinung Date: Wed Nov 9 20:07:37 2016 New Revision: 34460 URL: http://svn.gna.org/viewcvs/freeciv?rev=34460&view=rev Log: Declare all GameLoss units autoattack Provoking. It is, in all bundled rulesets, reasonable to attack a GamleLoss unit at once rather than hoping that it will attack

[Freeciv-commits] r34461 - /trunk/server/unithand.c

2016-11-09 Thread sveinung84
Author: sveinung Date: Wed Nov 9 20:08:43 2016 New Revision: 34461 URL: http://svn.gna.org/viewcvs/freeciv?rev=34461&view=rev Log: Make city conquest able to cause an incident. See patch #7960 Modified: trunk/server/unithand.c Modified: trunk/server/unithand.c URL: http://svn.gna.org/view

[Freeciv-commits] r34462 - in /trunk: common/unittype.c doc/README.actions server/citytools.c server/unittools.c

2016-11-09 Thread sveinung84
Author: sveinung Date: Thu Nov 10 01:22:12 2016 New Revision: 34462 URL: http://svn.gna.org/viewcvs/freeciv?rev=34462&view=rev Log: "Paradrop Unit": Don't rely on "Conquer City". Determine if a particular drop is a city conquest based on the old rules rather than on if the actor unit ever can do

[Freeciv-commits] r34463 - /trunk/common/requirements.c

2016-11-09 Thread sveinung84
Author: sveinung Date: Thu Nov 10 01:22:46 2016 New Revision: 34463 URL: http://svn.gna.org/viewcvs/freeciv?rev=34463&view=rev Log: A nation contradicts its group's absence. See patch #7962 Modified: trunk/common/requirements.c Modified: trunk/common/requirements.c URL: http://svn.gna.org/

[Freeciv-commits] r34464 - in /trunk: client/packhand.c common/actions.c common/actions.h server/ruleset.c

2016-11-09 Thread sveinung84
Author: sveinung Date: Thu Nov 10 01:23:32 2016 New Revision: 34464 URL: http://svn.gna.org/viewcvs/freeciv?rev=34464&view=rev Log: Prepare for ruleset derived action data. Introduce the new function actions_rs_pre_san_gen(). It generates data that is based on the loaded ruleset but needed before

[Freeciv-commits] r34474 - in /trunk: common/actions.c doc/README.actions fc_version

2016-11-10 Thread sveinung84
Author: sveinung Date: Thu Nov 10 10:40:27 2016 New Revision: 34474 URL: http://svn.gna.org/viewcvs/freeciv?rev=34474&view=rev Log: Conquer City: make !animal hard req obligatory. See patch #7966 Modified: trunk/common/actions.c trunk/doc/README.actions trunk/fc_version Modified: tr

[Freeciv-commits] r34475 - in /trunk/server: actiontools.c actiontools.h

2016-11-10 Thread sveinung84
Author: sveinung Date: Thu Nov 10 10:41:01 2016 New Revision: 34475 URL: http://svn.gna.org/viewcvs/freeciv?rev=34475&view=rev Log: An act_prob struct isn't a pointer. The function action_auto_perf_unit_prob() returns an act_prob struct, not a pointer to an act_prob struct. Remove the const from

[Freeciv-commits] r34495 - /trunk/server/scripting/api_server_edit.c

2016-11-13 Thread sveinung84
Author: sveinung Date: Sun Nov 13 16:42:42 2016 New Revision: 34495 URL: http://svn.gna.org/viewcvs/freeciv?rev=34495&view=rev Log: Lua server scripts: don't rely on "Conquer City". Determine if a particular Lua triggered unit move is a city conquest based on the old rules rather than on if the a

[Freeciv-commits] r34496 - in /trunk/common/scriptcore: api_game_find.c api_game_find.h tolua_game.pkg

2016-11-13 Thread sveinung84
Author: sveinung Date: Sun Nov 13 16:43:01 2016 New Revision: 34496 URL: http://svn.gna.org/viewcvs/freeciv?rev=34496&view=rev Log: Lua API: introduce find.action() methods. See patch #7973 Modified: trunk/common/scriptcore/api_game_find.c trunk/common/scriptcore/api_game_find.h trun

[Freeciv-commits] r34497 - /trunk/common/actions.c

2016-11-13 Thread sveinung84
Author: sveinung Date: Sun Nov 13 19:29:46 2016 New Revision: 34497 URL: http://svn.gna.org/viewcvs/freeciv?rev=34497&view=rev Log: An unknown target can't make an action possible. An action can be known to be impossible because of the actor unit. When this is true it doesn't matter what the targ

[Freeciv-commits] r34498 - in /trunk/server: unithand.c unithand.h

2016-11-13 Thread sveinung84
Author: sveinung Date: Sun Nov 13 19:30:22 2016 New Revision: 34498 URL: http://svn.gna.org/viewcvs/freeciv?rev=34498&view=rev Log: Action not enabled explain missing target. See patch #7978 Modified: trunk/server/unithand.c trunk/server/unithand.h Modified: trunk/server/unithand.c URL:

[Freeciv-commits] r34507 - /trunk/server/unithand.c

2016-11-13 Thread sveinung84
Author: sveinung Date: Mon Nov 14 07:55:59 2016 New Revision: 34507 URL: http://svn.gna.org/viewcvs/freeciv?rev=34507&view=rev Log: handle_unit_get_actions(): actor target distance. Replace the cached calculation if the actor and the target are at the same tile with caching the distance between a

[Freeciv-commits] r34508 - /trunk/server/unithand.c

2016-11-13 Thread sveinung84
Author: sveinung Date: Mon Nov 14 07:56:58 2016 New Revision: 34508 URL: http://svn.gna.org/viewcvs/freeciv?rev=34508&view=rev Log: Shorten unit_perform_action() via macros. See patch #7977 Modified: trunk/server/unithand.c [This mail would be too long, it was shortened to contain the URLs

[Freeciv-commits] r34511 - /trunk/server/unithand.c

2016-11-14 Thread sveinung84
Author: sveinung Date: Tue Nov 15 07:44:31 2016 New Revision: 34511 URL: http://svn.gna.org/viewcvs/freeciv?rev=34511&view=rev Log: Force all action target kinds to be handled. Use a switch statement in handle_unit_get_actions() when getting the probabilities of all actions. This forces all actio

[Freeciv-commits] r34585 - /trunk/client/gui-gtk-3.22/action_dialog.c

2016-11-20 Thread sveinung84
Author: sveinung Date: Sun Nov 20 13:41:14 2016 New Revision: 34585 URL: http://svn.gna.org/viewcvs/freeciv?rev=34585&view=rev Log: Gtk 3.22 doesn't support mnemonics. Remove the in band mnemonic marker ('_') from the "Keep Moving" action selection dialog button so it doesn't show up as text. Re

[Freeciv-commits] r34586 - /branches/S2_6/client/gui-gtk-3.22/action_dialog.c

2016-11-20 Thread sveinung84
Author: sveinung Date: Sun Nov 20 13:46:47 2016 New Revision: 34586 URL: http://svn.gna.org/viewcvs/freeciv?rev=34586&view=rev Log: Gtk 3.22 doesn't support mnemonics. Remove the in band mnemonic marker ('_') from the "Keep Moving" action selection dialog button so it doesn't show up as text. Re

[Freeciv-commits] r26953 - /trunk/client/gui-qt/dialogs.cpp

2014-11-02 Thread sveinung84
Author: sveinung Date: Sun Nov 2 15:22:49 2014 New Revision: 26953 URL: http://svn.gna.org/viewcvs/freeciv?rev=26953&view=rev Log: Qt client: Fix an instance of bad indention in dialogs.cpp See patch #5404 Modified: trunk/client/gui-qt/dialogs.cpp Modified: trunk/client/gui-qt/dialogs.cpp

[Freeciv-commits] r26954 - in /trunk/common: requirements.c requirements.h unittype.c

2014-11-02 Thread sveinung84
Author: sveinung Date: Sun Nov 2 16:10:58 2014 New Revision: 26954 URL: http://svn.gna.org/viewcvs/freeciv?rev=26954&view=rev Log: Make the idea behind getting the enumerator of a requirement clearer. Make the names and the comments related to getting the enumerator of a requirement in the enume

[Freeciv-commits] r26955 - in /trunk/common: unit.c unit.h unittype.c unittype.h

2014-11-02 Thread sveinung84
Author: sveinung Date: Sun Nov 2 16:45:47 2014 New Revision: 26955 URL: http://svn.gna.org/viewcvs/freeciv?rev=26955&view=rev Log: Track each individual action in the cache of what unit types can act. Continue caching if any action at all is possible so users won't have to check every action to

[Freeciv-commits] r26964 - in /trunk: client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ common/

2014-11-05 Thread sveinung84
Author: sveinung Date: Wed Nov 5 16:21:07 2014 New Revision: 26964 URL: http://svn.gna.org/viewcvs/freeciv?rev=26964&view=rev Log: Centralize action selection button tool tip generation. See patch #5407 Modified: trunk/client/gui-gtk-2.0/action_dialog.c trunk/client/gui-gtk-3.0/action_d

[Freeciv-commits] r27131 - in /trunk: client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui-sdl2/ client/gui-xaw/ ...

2014-11-26 Thread sveinung84
Author: sveinung Date: Wed Nov 26 11:04:18 2014 New Revision: 27131 URL: http://svn.gna.org/viewcvs/freeciv?rev=27131&view=rev Log: Make it possible for the client to insert custom text in an action UI name. Some clients adds extra information to caravan actions. Make it possible to keep doing th

[Freeciv-commits] r27136 - /trunk/common/actions.c

2014-11-27 Thread sveinung84
Author: sveinung Date: Thu Nov 27 15:29:49 2014 New Revision: 27136 URL: http://svn.gna.org/viewcvs/freeciv?rev=27136&view=rev Log: Assert that is_action_possible() is supplied with the correct target. This is just for documentation. All paths that lead to it are already checked. See patch #5463

[Freeciv-commits] r27137 - in /trunk/common: aicore/pf_tools.c combat.c

2014-11-27 Thread sveinung84
Author: sveinung Date: Thu Nov 27 15:36:53 2014 New Revision: 27137 URL: http://svn.gna.org/viewcvs/freeciv?rev=27137&view=rev Log: Revert bug #22381 fix This makes rulesets where it is illegal to attack out of harbor possible again. See bug #22794 Modified: trunk/common/aicore/pf_tools.c

[Freeciv-commits] r27138 - in /trunk: ./ ai/default/ client/ client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl/ client/gui...

2014-11-27 Thread sveinung84
Author: sveinung Date: Fri Nov 28 05:12:26 2014 New Revision: 27138 URL: http://svn.gna.org/viewcvs/freeciv?rev=27138&view=rev Log: Add action enablers for "Establish Trade Route" and "Enter Marketplace". Start making the caravan actions "Establish Trade Route" and "Enter Marketplace" action enab

[Freeciv-commits] r27151 - /trunk/ai/default/advdomestic.c

2014-11-28 Thread sveinung84
Author: sveinung Date: Fri Nov 28 14:28:33 2014 New Revision: 27151 URL: http://svn.gna.org/viewcvs/freeciv?rev=27151&view=rev Log: AI: Don't count a unit that can't establish a trade route as a trade route. Action enabler controll of Establish Trade Route makes it possible to create a ruleset we

[Freeciv-commits] r27164 - /trunk/server/unithand.c

2014-12-01 Thread sveinung84
Author: sveinung Date: Tue Dec 2 07:04:18 2014 New Revision: 27164 URL: http://svn.gna.org/viewcvs/freeciv?rev=27164&view=rev Log: Remove redundant TradeRoute flag check in base_handle_unit_establish_trade() Whether a unit should be allowed to establish a trade route or not is now action enabler

[Freeciv-commits] r27169 - /trunk/ai/default/aiunit.c

2014-12-03 Thread sveinung84
Author: sveinung Date: Wed Dec 3 21:48:25 2014 New Revision: 27169 URL: http://svn.gna.org/viewcvs/freeciv?rev=27169&view=rev Log: AI: Don't try to establish a trade route with a unit that can't do it. A unit may be unable to establish a trade route even if its unit type has the TradeRoute flag

[Freeciv-commits] r27171 - in /trunk/ai/default: advdomestic.c aicity.c

2014-12-03 Thread sveinung84
Author: sveinung Date: Wed Dec 3 21:48:49 2014 New Revision: 27171 URL: http://svn.gna.org/viewcvs/freeciv?rev=27171&view=rev Log: AI: Don't build units that can't establish trade routes for that purpose. Because of action enabler control over Establish Trade Route a unit type may have the Trade

[Freeciv-commits] r27172 - /trunk/ai/default/aiunit.c

2014-12-03 Thread sveinung84
Author: sveinung Date: Wed Dec 3 22:00:49 2014 New Revision: 27172 URL: http://svn.gna.org/viewcvs/freeciv?rev=27172&view=rev Log: AI: It is possible to do a caravan action from the neighbor tile. See patch #5480 Modified: trunk/ai/default/aiunit.c Modified: trunk/ai/default/aiunit.c URL:

[Freeciv-commits] r27173 - /trunk/ai/default/aidiplomat.c

2014-12-03 Thread sveinung84
Author: sveinung Date: Wed Dec 3 22:01:00 2014 New Revision: 27173 URL: http://svn.gna.org/viewcvs/freeciv?rev=27173&view=rev Log: AI: It is possible to do a spy action from the same tile as the target. See patch #5481 Modified: trunk/ai/default/aidiplomat.c Modified: trunk/ai/default/aidi

[Freeciv-commits] r27184 - /trunk/server/unithand.c

2014-12-05 Thread sveinung84
Author: sveinung Date: Fri Dec 5 13:43:56 2014 New Revision: 27184 URL: http://svn.gna.org/viewcvs/freeciv?rev=27184&view=rev Log: Remove checks in handle_unit_help_build_wonder() that only are about rules. Whether or not a unit should be allowed to help a city build a wonder is now action enabl

[Freeciv-commits] r27185 - in /trunk: ai/default/advdomestic.c ai/default/aiunit.c common/aicore/caravan.c

2014-12-05 Thread sveinung84
Author: sveinung Date: Fri Dec 5 13:44:29 2014 New Revision: 27185 URL: http://svn.gna.org/viewcvs/freeciv?rev=27185&view=rev Log: AI: Support the Enter Marketplace action. - Consider to do Enter Marketplace when a unit can't do Establish Trade Route - Calculate the correct one time bonus for En

[Freeciv-commits] r27225 - in /trunk/common: actions.c actions.h unittype.c unittype.h

2014-12-09 Thread sveinung84
Author: sveinung Date: Wed Dec 10 03:18:51 2014 New Revision: 27225 URL: http://svn.gna.org/viewcvs/freeciv?rev=27225&view=rev Log: Make finding out if a unit type can perform hostile actions fast. In the future it may be a good idea to make a scale in stead of a binary classification. Thanks to

[Freeciv-commits] r27226 - /trunk/ai/default/aiunit.c

2014-12-09 Thread sveinung84
Author: sveinung Date: Wed Dec 10 03:23:53 2014 New Revision: 27226 URL: http://svn.gna.org/viewcvs/freeciv?rev=27226&view=rev Log: AI: Don't build a unit to chase a foreign unit that can't do hostile actions. The AI function find_something_to_kill() tests if it is worth to build a new unit to ch

[Freeciv-commits] r27227 - /trunk/common/aicore/pf_tools.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 13:53:16 2014 New Revision: 27227 URL: http://svn.gna.org/viewcvs/freeciv?rev=27227&view=rev Log: Path finding: Caravan actions can now be limited by source tile terrain. Since caravan actions now are action enabler controlled it is possible to create a ruleset w

[Freeciv-commits] r27228 - /trunk/common/aicore/pf_tools.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 13:54:04 2014 New Revision: 27228 URL: http://svn.gna.org/viewcvs/freeciv?rev=27228&view=rev Log: Path finding: Be precise when classifying a unit as a diplomat or trader. A unit that is able to perform a caravan actions but no spy action isn't a diplomat. A unit

[Freeciv-commits] r27229 - /trunk/client/goto.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 13:55:36 2014 New Revision: 27229 URL: http://svn.gna.org/viewcvs/freeciv?rev=27229&view=rev Log: Client goto: Base tile behavior of actors on action hostility. Don't give all actors the same tile behavior no matter if they can perform hostile acts or not. See p

[Freeciv-commits] r27230 - /trunk/ai/default/aitools.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:17:14 2014 New Revision: 27230 URL: http://svn.gna.org/viewcvs/freeciv?rev=27230&view=rev Log: AI: Path finding: Give non hostile actor units the same tile behavior. Actor units only capable of performing non hostile actions will now avoid fights on the way bu

[Freeciv-commits] r27231 - /trunk/ai/default/aitools.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:17:35 2014 New Revision: 27231 URL: http://svn.gna.org/viewcvs/freeciv?rev=27231&view=rev Log: AI: Path finding: Don't base tile behavior on the unit flags Spy and Diplomat. A unit may be unable to perform spy actions even if it has the flags. Look for the abi

[Freeciv-commits] r27232 - /trunk/ai/default/advdomestic.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:18:19 2014 New Revision: 27232 URL: http://svn.gna.org/viewcvs/freeciv?rev=27232&view=rev Log: AI: Don't count units that can't help wonder as wonder helpers. Action enabler control of Help build Wonder makes it possible to create a ruleset were a unit has the

[Freeciv-commits] r27233 - in /trunk: ai/default/aiunit.c common/aicore/caravan.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:18:32 2014 New Revision: 27233 URL: http://svn.gna.org/viewcvs/freeciv?rev=27233&view=rev Log: AI: Don't try to make a unit that never can help build a wonder help build one. Wonder building help is now controlled by action enablers. It is therefore possible f

[Freeciv-commits] r27234 - /trunk/client/control.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:29:36 2014 New Revision: 27234 URL: http://svn.gna.org/viewcvs/freeciv?rev=27234&view=rev Log: Client: Make the sanity test in key_unit_trade_route() stricter. The common client code's function key_unit_trade_route() checks that the actor unit given to it by t

[Freeciv-commits] r27235 - /trunk/client/control.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 14:29:46 2014 New Revision: 27235 URL: http://svn.gna.org/viewcvs/freeciv?rev=27235&view=rev Log: Client: Make the sanity test in key_unit_build_wonder() stricter. The common client code's function key_unit_build_wonder() checks that the actor unit given to it by

[Freeciv-commits] r27236 - /trunk/server/unithand.c

2014-12-10 Thread sveinung84
Author: sveinung Date: Wed Dec 10 16:19:06 2014 New Revision: 27236 URL: http://svn.gna.org/viewcvs/freeciv?rev=27236&view=rev Log: Update comment in unit_move_handling()'s actor handling. The section now takes care of all actor units, not just diplomats. Modified: trunk/server/unithand.c M

[Freeciv-commits] r27251 - /trunk/common/actions.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Thu Dec 11 11:41:18 2014 New Revision: 27251 URL: http://svn.gna.org/viewcvs/freeciv?rev=27251&view=rev Log: Change the "Help build Wonder" button's mnemonic to 'b'. This makes it consistent with the menu short cut. See patch #5518 Modified: trunk/common/actions.c Mo

[Freeciv-commits] r27252 - /trunk/server/unithand.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Thu Dec 11 11:50:00 2014 New Revision: 27252 URL: http://svn.gna.org/viewcvs/freeciv?rev=27252&view=rev Log: Check that there is a city to help build the wonder in. Restore the check that handle_unit_help_build_wonder() has a target city to help that accidentally got remove

[Freeciv-commits] r27253 - in /trunk: ai/default/aiunit.c common/aicore/caravan.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Thu Dec 11 12:12:09 2014 New Revision: 27253 URL: http://svn.gna.org/viewcvs/freeciv?rev=27253&view=rev Log: AI: Try a new target when a caravan can't act against its current target. A ruleset may have restrictions on caravan actions the AI don't understand. Try a different

[Freeciv-commits] r27254 - /trunk/client/gui-qt/dialogs.cpp

2014-12-11 Thread sveinung84
Author: sveinung Date: Thu Dec 11 12:20:28 2014 New Revision: 27254 URL: http://svn.gna.org/viewcvs/freeciv?rev=27254&view=rev Log: Qt client: make the Help Wonder button's custom info label creation more robust. See patch #5528 Modified: trunk/client/gui-qt/dialogs.cpp Modified: trunk/clie

[Freeciv-commits] r27255 - in /trunk/client: gui-gtk-2.0/action_dialog.c gui-gtk-3.0/action_dialog.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Thu Dec 11 12:20:38 2014 New Revision: 27255 URL: http://svn.gna.org/viewcvs/freeciv?rev=27255&view=rev Log: Gtk clients: make the Help Wonder button's custom info label creation more robust. See patch #5529 Modified: trunk/client/gui-gtk-2.0/action_dialog.c trunk

[Freeciv-commits] r27261 - /trunk/server/unittools.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Fri Dec 12 05:09:01 2014 New Revision: 27261 URL: http://svn.gna.org/viewcvs/freeciv?rev=27261&view=rev Log: Auto attack: Don't treat an actor incapable of doing hostile actions like a spy. Check if the unit type can do hostile actions in stead of if it can act. See bug #2

[Freeciv-commits] r27262 - in /trunk/ai/default: advmilitary.c aidiplomat.c aihunt.c

2014-12-11 Thread sveinung84
Author: sveinung Date: Fri Dec 12 05:09:16 2014 New Revision: 27262 URL: http://svn.gna.org/viewcvs/freeciv?rev=27262&view=rev Log: AI: Don't treat an actor incapable of doing hostile actions like a spy. Check if the unit type can do hostile actions in stead of if it can act. See bug #23050 Mod

[Freeciv-commits] r27263 - /trunk/common/actions.c

2014-12-12 Thread sveinung84
Author: sveinung Date: Fri Dec 12 13:44:26 2014 New Revision: 27263 URL: http://svn.gna.org/viewcvs/freeciv?rev=27263&view=rev Log: Make the "can't establish an embassy when you already got one"-rule permanent. I don't think it will move it to the ruleset for 2.6. It should therefore live in is_a

[Freeciv-commits] r27264 - /trunk/server/unithand.c

2014-12-12 Thread sveinung84
Author: sveinung Date: Fri Dec 12 14:00:39 2014 New Revision: 27264 URL: http://svn.gna.org/viewcvs/freeciv?rev=27264&view=rev Log: Make explanation when no action is possible action kind neutral. The user may have tried to do a caravan action. The explanation therefore shouldn't talk about diplo

[Freeciv-commits] r27265 - in /trunk/client: gui-sdl/action_dialog.c gui-sdl2/action_dialog.c

2014-12-12 Thread sveinung84
Author: sveinung Date: Fri Dec 12 14:01:10 2014 New Revision: 27265 URL: http://svn.gna.org/viewcvs/freeciv?rev=27265&view=rev Log: SDL clients: Check for specific action in sanity test. Check that the actor unit type is capable of the respective action when sanity checking the reply to the follo

[Freeciv-commits] r27266 - in /trunk: ai/default/aitools.c client/goto.c

2014-12-12 Thread sveinung84
Author: sveinung Date: Fri Dec 12 14:08:50 2014 New Revision: 27266 URL: http://svn.gna.org/viewcvs/freeciv?rev=27266&view=rev Log: Remove redundant is_actor_unit() calls. Checking if a unit type can perform any action at all AND that it can perform any hostile actions is redundant. If it can per

[Freeciv-commits] r27284 - in /trunk/data: civ2/ civ2civ3/ classic/ experimental/ multiplayer/

2014-12-13 Thread sveinung84
Author: sveinung Date: Sat Dec 13 18:43:15 2014 New Revision: 27284 URL: http://svn.gna.org/viewcvs/freeciv?rev=27284&view=rev Log: Allow Spy units to do the untargeted version of steal tech and sabotage city. At the moment the targeted version includes the untargeted version. This will save a pl

[Freeciv-commits] r27285 - in /trunk: data/civ2civ3/units.ruleset doc/README.ruleset_civ2civ3

2014-12-13 Thread sveinung84
Author: sveinung Date: Sat Dec 13 18:43:27 2014 New Revision: 27285 URL: http://svn.gna.org/viewcvs/freeciv?rev=27285&view=rev Log: civ2civ3: Crusaders no longer cause military unhappiness This makes the religious tech path more attractive. Patch by David Fernandez See patch #5543 Modified:

[Freeciv-commits] r27309 - in /branches/S2_5: data/civ2civ3/units.ruleset doc/README.ruleset_civ2civ3

2014-12-15 Thread sveinung84
Author: sveinung Date: Mon Dec 15 12:43:38 2014 New Revision: 27309 URL: http://svn.gna.org/viewcvs/freeciv?rev=27309&view=rev Log: civ2civ3: Crusaders no longer cause military unhappiness This makes the religious tech path more attractive. Patch by David Fernandez See patch #5543 Modified:

[Freeciv-commits] r27318 - /trunk/server/unithand.c

2014-12-16 Thread sveinung84
Author: sveinung Date: Tue Dec 16 17:55:23 2014 New Revision: 27318 URL: http://svn.gna.org/viewcvs/freeciv?rev=27318&view=rev Log: Clean up: Only select the target city if acting against it is possible. This makes tgt_city() behave consistent with tgt_unit() See patch #5553 Modified: trunk

[Freeciv-commits] r27319 - in /trunk: client/gui-gtk-2.0/ client/gui-gtk-3.0/ client/gui-qt/ client/gui-sdl2/ client/gui-xaw/ server/

2014-12-16 Thread sveinung84
Author: sveinung Date: Tue Dec 16 17:56:00 2014 New Revision: 27319 URL: http://svn.gna.org/viewcvs/freeciv?rev=27319&view=rev Log: Allow units that can do action enabler controlled actions to attack. Creating a unit type that can do caravan actions but still attack was broken when the caravan ac

[Freeciv-commits] r27320 - in /trunk: data/civ2civ3/buildings.ruleset doc/README.ruleset_civ2civ3

2014-12-16 Thread sveinung84
Author: sveinung Date: Tue Dec 16 18:06:24 2014 New Revision: 27320 URL: http://svn.gna.org/viewcvs/freeciv?rev=27320&view=rev Log: civ2civ3: make wonders obsolete by own techs. With this patch, you have to compete against the other players to build the wonders, as always. But once built, it is u

[Freeciv-commits] r27323 - /trunk/client/control.c

2014-12-17 Thread sveinung84
Author: sveinung Date: Wed Dec 17 13:07:10 2014 New Revision: 27323 URL: http://svn.gna.org/viewcvs/freeciv?rev=27323&view=rev Log: Clean up: Remove the unused variable caravan_arrival_queue. It should have been removed as a part of patch #5482. See patch #5570 Modified: trunk/client/contro

[Freeciv-commits] r27324 - in /trunk: client/control.c client/packhand.c common/packets.def fc_version server/unithand.c

2014-12-17 Thread sveinung84
Author: sveinung Date: Wed Dec 17 13:08:01 2014 New Revision: 27324 URL: http://svn.gna.org/viewcvs/freeciv?rev=27324&view=rev Log: Allow the client to select what target to get action probabilities for. Use this to make sure that the targets won't accidentally change when the client requests an

[Freeciv-commits] r27325 - /trunk/common/actions.c

2014-12-17 Thread sveinung84
Author: sveinung Date: Wed Dec 17 13:08:46 2014 New Revision: 27325 URL: http://svn.gna.org/viewcvs/freeciv?rev=27325&view=rev Log: Give some action UI names new mnemonics to make each mnemonic unique. See bug #23088 Modified: trunk/common/actions.c Modified: trunk/common/actions.c URL: ht

[Freeciv-commits] r27345 - /trunk/client/helpdata.c

2014-12-19 Thread sveinung84
Author: sveinung Date: Fri Dec 19 13:05:34 2014 New Revision: 27345 URL: http://svn.gna.org/viewcvs/freeciv?rev=27345&view=rev Log: Help: Specify that population cost is the price payed. Reported by David Lowe See bug #23039 Modified: trunk/client/helpdata.c Modified: trunk/client/helpdat

[Freeciv-commits] r27346 - /branches/S2_5/client/helpdata.c

2014-12-19 Thread sveinung84
Author: sveinung Date: Fri Dec 19 13:23:24 2014 New Revision: 27346 URL: http://svn.gna.org/viewcvs/freeciv?rev=27346&view=rev Log: Help: Specify that population cost is the price payed. Reported by David Lowe See bug #23039 Modified: branches/S2_5/client/helpdata.c Modified: branches/S2_

[Freeciv-commits] r27361 - /trunk/server/unithand.c

2014-12-20 Thread sveinung84
Author: sveinung Date: Sat Dec 20 20:20:35 2014 New Revision: 27361 URL: http://svn.gna.org/viewcvs/freeciv?rev=27361&view=rev Log: Merge the Help build Wonder success message text. Put the only difference, if work is remaining or surplus, in a variable. See patch #5581 Modified: trunk/serv

[Freeciv-commits] r27362 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplay...

2014-12-20 Thread sveinung84
Author: sveinung Date: Sat Dec 20 20:20:45 2014 New Revision: 27362 URL: http://svn.gna.org/viewcvs/freeciv?rev=27362&view=rev Log: Put the only-domestic-wonder-building-can-receive-help-rule in the ruleset. The restriction against helping foreign wonders is added to the Help Wonder action of all

[Freeciv-commits] r27363 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ doc/

2014-12-20 Thread sveinung84
Author: sveinung Date: Sat Dec 20 20:20:52 2014 New Revision: 27363 URL: http://svn.gna.org/viewcvs/freeciv?rev=27363&view=rev Log: Let units without TradeRoute establish trade routes and enter marketplaces. Move the rule that a unit must have the TradeRoute flag to establish a trade route or ent

[Freeciv-commits] r27364 - in /trunk: common/ data/alien/ data/civ1/ data/civ2/ data/civ2civ3/ data/classic/ data/experimental/ data/multiplay...

2014-12-20 Thread sveinung84
Author: sveinung Date: Sat Dec 20 20:20:59 2014 New Revision: 27364 URL: http://svn.gna.org/viewcvs/freeciv?rev=27364&view=rev Log: Let units without the HelpWonder flag help build wonders. Move the rule that a unit must have the HelpWonder flag to help build a wonder to the ruleset. The HelpWon

[Freeciv-commits] r27382 - /branches/S2_4/client/helpdata.c

2014-12-22 Thread sveinung84
Author: sveinung Date: Mon Dec 22 10:35:48 2014 New Revision: 27382 URL: http://svn.gna.org/viewcvs/freeciv?rev=27382&view=rev Log: Help: Specify that population cost is the price payed. Reported by David Lowe See bug #23039 Modified: branches/S2_4/client/helpdata.c Modified: branches/S2_

[Freeciv-commits] r27383 - /trunk/client/text.c

2014-12-22 Thread sveinung84
Author: sveinung Date: Mon Dec 22 12:06:06 2014 New Revision: 27383 URL: http://svn.gna.org/viewcvs/freeciv?rev=27383&view=rev Log: Show trade in middle click info based on ability to establish trade route. See patch #5585 Modified: trunk/client/text.c Modified: trunk/client/text.c URL: ht

[Freeciv-commits] r27384 - /trunk/client/gui-qt/menu.cpp

2014-12-22 Thread sveinung84
Author: sveinung Date: Mon Dec 22 18:37:21 2014 New Revision: 27384 URL: http://svn.gna.org/viewcvs/freeciv?rev=27384&view=rev Log: Qt client: Improve test before understanding "b" as Help build Wonder. Look for the unit type's ability to do the Help Wonder action rather than checking if it has t

[Freeciv-commits] r27398 - in /trunk: data/civ2civ3/effects.ruleset doc/README.ruleset_civ2civ3

2014-12-24 Thread sveinung84
Author: sveinung Date: Wed Dec 24 14:41:30 2014 New Revision: 27398 URL: http://svn.gna.org/viewcvs/freeciv?rev=27398&view=rev Log: civ2civ3: adjust Federation and Fundamentalism governments Make Fundamentalism a good government to maximize the production of gold/money, even in the middle of the

<    5   6   7   8   9   10   11   12   13   14   >