[Freeciv-commits] r30078 - in /trunk/client: gui-gtk-2.0/gui_main.c gui-gtk-3.0/gui_main.c

[cazfi74]

Author: cazfi
Date: Wed Oct 14 17:59:58 2015
New Revision: 30078

URL: http://svn.gna.org/viewcvs/freeciv?rev=30078&view=rev
Log:
Fixed duoble unref of gtk-clients' messagebuffer.

See bug #23895

Modified:
    trunk/client/gui-gtk-2.0/gui_main.c
    trunk/client/gui-gtk-3.0/gui_main.c

Modified: trunk/client/gui-gtk-2.0/gui_main.c
URL: 
http://svn.gna.org/viewcvs/freeciv/trunk/client/gui-gtk-2.0/gui_main.c?rev=30078&r1=30077&r2=30078&view=diff
==============================================================================
--- trunk/client/gui-gtk-2.0/gui_main.c (original)
+++ trunk/client/gui-gtk-2.0/gui_main.c Wed Oct 14 17:59:58 2015
@@ -1707,6 +1707,7 @@
   cma_fe_done();
   free_unit_table();
   gtk_widget_destroy(toplevel_tabs);
+  message_buffer = NULL; /* Result of destruction of everything */
   tileset_free_tiles(tileset);
 }
 
@@ -1723,8 +1724,10 @@
 **************************************************************************/
 void ui_exit(void)
 {
-  g_object_unref(message_buffer);
-  message_buffer = NULL;
+  if (message_buffer != NULL) {
+    g_object_unref(message_buffer);
+    message_buffer = NULL;
+  }
 }
 
 /**************************************************************************

Modified: trunk/client/gui-gtk-3.0/gui_main.c
URL: 
http://svn.gna.org/viewcvs/freeciv/trunk/client/gui-gtk-3.0/gui_main.c?rev=30078&r1=30077&r2=30078&view=diff
==============================================================================
--- trunk/client/gui-gtk-3.0/gui_main.c (original)
+++ trunk/client/gui-gtk-3.0/gui_main.c Wed Oct 14 17:59:58 2015
@@ -1743,6 +1743,7 @@
   cma_fe_done();
   free_unit_table();
   gtk_widget_destroy(toplevel_tabs);
+  message_buffer = NULL; /* Result of destruction of everything */
   tileset_free_tiles(tileset);
 }
 
@@ -1759,8 +1760,10 @@
 **************************************************************************/
 void ui_exit(void)
 {
-  g_object_unref(message_buffer);
-  message_buffer = NULL;
+  if (message_buffer != NULL) {
+    g_object_unref(message_buffer);
+    message_buffer = NULL;
+  }
 }
 
 /**************************************************************************


_______________________________________________
Freeciv-commits mailing list
Freeciv-commits@gna.org
https://mail.gna.org/listinfo/freeciv-commits