Author: sveinung
Date: Tue Jun 28 12:38:51 2016
New Revision: 33080
URL: http://svn.gna.org/viewcvs/freeciv?rev=33080&view=rev
Log:
Stop "Attack" action probability info leak.
A unit in a city isn't seen by the attacking player.
See bug #24801
Modified:
trunk/common/actions.c
Modified: trunk/common/actions.c
URL:
http://svn.gna.org/viewcvs/freeciv/trunk/common/actions.c?rev=33080&r1=33079&r2=33080&view=diff
==============================================================================
--- trunk/common/actions.c (original)
+++ trunk/common/actions.c Tue Jun 28 12:38:51 2016
@@ -2418,10 +2418,15 @@
case ACTION_ATTACK:
{
struct unit *defender_unit = get_defender(actor_unit,
- target_tile);
- double unconverted = unit_win_chance(actor_unit, defender_unit);
-
- chance = (int)((double)200 * unconverted);
+ target_tile);
+
+ if (can_player_see_unit(actor_player, defender_unit)) {
+ double unconverted = unit_win_chance(actor_unit, defender_unit);
+
+ chance = (int)((double)200 * unconverted);
+ } else if (known == TRI_YES) {
+ known = TRI_MAYBE;
+ }
}
break;
case ACTION_COUNT:
_______________________________________________
Freeciv-commits mailing list
Freeciv-commits@gna.org
https://mail.gna.org/listinfo/freeciv-commits
