URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
Marko Lindqvist wrote:
As a part of feature development, #18380 is not meant to be ported to S2_1.
As primarily a bug fix, #18380 should have been ported to S2_1, still
unreleased. And it's not too late
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
On 19/08/07, William Allen Simpson [EMAIL PROTECTED] wrote:
Marko Lindqvist wrote:
As a part of feature development, #18380 is not meant to be ported to S2_1.
As primarily a bug fix, #18380 should have been ported to S2_1, still
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
On 04/07/07, William Allen Simpson [EMAIL PROTECTED] wrote:
Ulrik Sverdrup wrote:
This patch reinstates the ptype local variable that is needed after
punit is wiped to print the user messages.
Thanks! Added comments. Probably
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
William Allen Simpson wrote:
Thanks! Added comments. Probably shouldn't be destroyed until after
the messages are sent, but the logic isn't readily apparent.
Comparing against trunk, found that this has been substantially
rewritten
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
Now I suspect it is simply that punit is not a valid pointer after
server_remove_unit(punit);
and we should extract the unit type of the punit before destroying it?
Or is this a sign of something else at fault here?
In the simple case,
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434
This patch reinstates the ptype local variable that is needed after
punit is wiped to print the user messages.
Patch against S2_1 r13044
Index: server/unittools.c
===
---
