Update of bug #20744 (project freeciv):
Status: Ready For Test = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #3, bug #20744 (project freeciv):
As we're heading to beta2, I'll commit this with extra argument intact. That's
what's been extensively tested (like in: several autogames (on multicore
system) constantly running almost from the day trunk patch was first
introduced). We may
Update of bug #20744 (project freeciv):
Planned Release: 2.4.0, 2.5.0, 2.6.0 = 2.4.0-beta2, 2.5.0, 2.6.0
___
Follow-up Comment #4:
Correction: Had to make new version anyway due to other changes to codebase,
so removed S2_4
Follow-up Comment #5, bug #20744 (project freeciv):
I think it's safe either way: I just tend to avoid having unused arguments or
functions if possible, to ease later reading of the code (but given the volume
of testing to which this was subjected, there is a strong argument for leaving
it
URL:
http://gna.org/bugs/?20744
Summary: Recursive wipe_unit() saving drowning units from
calling wipe_unit()
Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 19 Apr 2013 11:52:39 AM EEST
Category: general
Follow-up Comment #1, bug #20744 (project freeciv):
- S2_4 version of the patch
(file #17768)
___
Additional Item Attachment:
File name: WipeUnitLists-S2_4.patch Size:8 KB
Follow-up Comment #2, bug #20744 (project freeciv):
try_to_save_unit() doesn't need to take the helpless argument for S2_4, as
this only exists as a base for future extension, but leaving it there should
cause no problem and it may be helpful to have the S2_4 and S2_5 functions be
identical to
