URL:
<http://gna.org/bugs/?24981>
Summary: spaceship part placement order
Project: Freeciv
Submitted by: log65536
Submitted on: Tue Aug 16 04:40:26 2016
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
Contains string changes: None
_______________________________________________________
Details:
If there are multiple spaceship parts newly built in a turn, the logic of
*next_spaceship_component()* in *common/spaceship.c* suggests that the modules
should be placed first, then the components, then the structurals, with the
structurals being placed in a particularly smart order that is guided by the
*modules/components* that are already placed. That would work if
*next_spaceship_component()* was called with *ship->modules*,
*ship->components* and *ship->structurals* already set to their final values
for that turn. Unfortunately, it seems to be called with intermediate values.
For example, a minimal spaceship consists of 3 modules, 2 components and 8
structurals; if I
build them all in a single turn, some structurals might be encountered first,
and since there are no components/modules to guide the placement, those
structurals will be placed in a default "numerical" order. Due to the
misplacement, the spaceship will not be launchable without building further
structurals next turn.
I think that placement is client's choice, so it should generally be made to
the user's advantage. In order to take advantage of the smart placement of
structurals we already have in *next_spaceship_component()*, the client should
do it after it has information about all newly built parts on that turn.
(Sorry if I am reading this wrong; not sure whether the server mandates
placement before moving on to the next city).
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24981>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
