[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Update of patch #1659 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #6, patch #1659 (project freeciv): update (08/10) (file #9287) ___ Additional Item Attachment: File name: 20100609-08-trunk-use-specenum_gen-for-enum-terrain_class-and-enum-ter.patch Size:10 KB

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #5, patch #1659 (project freeciv): SPECENUM_LAST doesn't make sense for bitwise definitions. There maybe a SPECENUM_MASK would be required in some case, but it seems a bit more complex to implement. ___ Reply to this ite

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #4, patch #1659 (project freeciv): > Static arrays cannot use a function. Maybe there is a simple way to add a SPECENUM_LAST value? Would something like the following work? I don't know if this is OK for bitwise definitions. Or should it only be defined if !bitwise? #define S

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #3, patch #1659 (project freeciv): Static arrays cannot use a function. Maybe there is a simple way to add a SPECENUM_LAST value? ___ Reply to this item at: __

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #2, patch #1659 (project freeciv): Yes; I did notice this at the time I send the patches. I will add the needed checks. Most of the time the *_LAST value is needed for the definition of arrays (see network code). Or could _class_max() be used there? ___

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

Follow-up Comment #1, patch #1659 (project freeciv): Notice here that the code before and after don't do the same thing; TC_LAST is a valid value since it is defined in the enumeration like the others. The new code will consider 'TC_LAST' to be the name of a valid terrain class. I have not confi

[Freeciv-Dev] [patch #1659] use specenum_gen for enum terrain_class and enum terrain_alteration

URL: Summary: use specenum_gen for enum terrain_class and enum terrain_alteration Project: Freeciv Submitted by: syntron Submitted on: Sonntag 02.05.2010 um 23:35 Category: general