Update of patch #3726 (project freeciv):
Planned Release: 2.5.0 =
___
Reply to this item at:
http://gna.org/patch/?3726
___
Message sent
Update of patch #3726 (project freeciv):
Assigned to: cazfi = None
___
Reply to this item at:
http://gna.org/patch/?3726
___
Message sent
Follow-up Comment #5, patch #3726 (project freeciv):
Could you produce new version of this patch to go in before S2_5 branching in
a month?
___
Reply to this item at:
http://gna.org/patch/?3726
Follow-up Comment #4, patch #3726 (project freeciv):
save_command() should cmd_reply(C_FAIL) when appropriate and return FALSE in
such a case.
___
Reply to this item at:
http://gna.org/patch/?3726
Follow-up Comment #1, patch #3726 (project freeciv):
Reading the patch alone (not checking existing context from sources) it seems
that even after noticed failure you still continue to try to do everything
inside that particular function as if everything succeeded. At least executing
Follow-up Comment #2, patch #3726 (project freeciv):
In its current state, the proposed patch doesn't touch how the save functions
behave, and it just reports upwards in the functions chain whether a failure
has been detected.
Such report emerges up to save_command() in form of return value, and
Follow-up Comment #3, patch #3726 (project freeciv):
[ Ending piece - browser authonomously submitted the post before I completed
it ]
...
I could complete the return value's climbing chain of function up to
handle_stdin_input_real(), making things logically cleaner.
URL:
http://gna.org/patch/?3726
Summary: Booleanize all save functions for savegame v2
Project: Freeciv
Submitted by: davide_at_debian
Submitted on: Thu 21 Feb 2013 04:16:25 AM GMT
Category: general
Update of patch #3726 (project freeciv):
Priority: 3 - Low = 5 - Normal
Assigned to:None = cazfi
Planned Release: = 2.5.0
