Follow-up Comment #4, patch #5364 (project freeciv):
'tgt_tile' may be used uninitialized
Untested patch to fix this attached.
(file #22654)
___
Additional Item Attachment:
File name: trunk-patch5364-warning.patch Size:2 KB
Follow-up Comment #6, patch #5364 (project freeciv):
Could you please test if the warning goes away on your system?
Yes, it does (sorry, I should have said).
So the build logs are public?
If you know where to look... (I had to dig this out of freeciv-dev archives)
Follow-up Comment #7, patch #5364 (project freeciv):
_Yes, it does_
In that case I think it should go in - it improves code quality and gets rid
of a warning on some gcc versions.
___
Reply to this item at:
http://gna.org/patch/?5364
Follow-up Comment #2, patch #5364 (project freeciv):
My gcc (4.6.3) is complaining about this change with -Werror:
packhand.c: In function 'handle_player_diplstate':
packhand.c:2347:36: error: 'tgt_tile' may be used uninitialized in this
function [-Werror=uninitialized]
Haven't looked into
Follow-up Comment #3, patch #5364 (project freeciv):
It seems this is what has upset Fullmoon the past two nights, too.
e.g. http://build.cazfi.net/freeciv/nightly/logs/stderr-141017.log
___
Reply to this item at:
Update of patch #5364 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #5364 (project freeciv):
Status: In Progress = Ready For Test
___
Reply to this item at:
http://gna.org/patch/?5364
___
Message sent
URL:
http://gna.org/patch/?5364
Summary: Ask for background updates to action selection
dialogs on diplstate change.
Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 12 Oct 2014 01:48:40 PM UTC
Category: client
